Skip to content

test: evaluate() with falsy result - #42728

Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:test-42661
Sep 16, 2026
Merged

Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:test-42661

Conversation

@dgozman

Copy link
Copy Markdown
Collaborator

Fixes #42661.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [firefox-library] › library/browsercontext-storage-state.spec.ts:453 › should work when service worker is intefering and the origin is not open @firefox-ubuntu-22.04-node20

9 flaky ⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:699 › screencast › should capture full viewport on hidpi `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:356 › screencast › should work for popups `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:664 › screencast › should capture full viewport `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`
⚠️ [webkit-page] › page/page-leaks.spec.ts:164 › waitFor should not leak `@webkit-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:827 › should update state on subsequent run `@windows-latest-node22`

51734 passed, 1247 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 The one failure is pre-existing — this PR is clear

Hi, I'm the Playwright bot and I took another look at the CI failures.

The only red test is browsercontext-storage-state.spec.ts:453 on Firefox, and it's been failing on main since 2026-09-10, independently of this PR. The two tests this PR adds now pass on chromium, firefox and webkit — the earlier Firefox failures are gone since the fix for #42661 landed.

Details

Pre-existing flake / infra

  • [firefox-library] › library/browsercontext-storage-state.spec.ts:453 › should work when service worker is intefering and the origin is not open — not a flake, a steady pre-existing failure. In the aggregated CI results it is red in 47 of 48 firefox-library runs, across 32 SHAs and 17 different PRs, first failing 2026-09-10 — before this PR. chromium-library (49 runs) and webkit-library (48 runs) are green throughout. Also red on bidi-chromium-library and moz-firefox-nightly-library. This PR touches only tests/page/page-evaluate.spec.ts, which the storage-state/service-worker path doesn't exercise.

No longer failing

  • [firefox-page] › page/page-evaluate.spec.ts › should reject when a falsy value is thrown and › should include a non-error rejection value in the error message — the two tests this PR adds. They failed on Firefox on the earlier sha 82abc76 (4 attempts each), and pass on all three browsers on the current sha 49b82ff. Nothing left to gate.

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [chrome] › mcp/webmcp.spec.ts:178 › browser_webmcp_call disambiguates duplicate tool names by frame @mcp-macos-latest-chrome
❌ [firefox] › mcp/cli-session.spec.ts:54 › idle timeout shuts the session down @mcp-windows-latest-firefox

8562 passed, 1446 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 All three failures are pre-existing — this PR is clear

Hi, I'm the Playwright bot and I took another look at the CI failures.

This PR only adds two tests to tests/page/page-evaluate.spec.ts, and those now pass on chromium, firefox and webkit. The three red tests — two MCP, one storage-state — all fail on other PRs and on main pushes, independently of this PR.

Details

Pre-existing flake / infra

Not failing anymore

Triaged by the Playwright bot - agent run

@dgozman
Dmitry Gozman (dgozman) merged commit 4a0e071 into microsoft:main Sep 16, 2026
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: evaluate() resolves instead of rejecting on Firefox when the page function throws a falsy value

2 participants