Skip to content

feat(firefox): roll to r1548 - #42747

Merged
Dmitry Gozman (dgozman) merged 1 commit into
mainfrom
roll-into-pw-firefox/1548
Sep 16, 2026
Merged

Dmitry Gozman (dgozman) merged 1 commit into
mainfrom
roll-into-pw-firefox/1548

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/2c149e66f5db026abc96f9dbbff922708b24c045. Build has full platform coverage - check that all tests pass there.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [firefox-library] › library/browsercontext-storage-state.spec.ts:453 › should work when service worker is intefering and the origin is not open @firefox-ubuntu-22.04-node20

9 flaky ⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:356 › screencast › should work for popups `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1333 › should abort requests when browser context closes `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:664 › screencast › should capture full viewport `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:388 › should reveal errors in the sourcetab `@windows-latest-node22`

51718 passed, 1247 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 The one failure is pre-existing — this PR is clear

Hi, I'm the Playwright bot and I triaged the failing CI run.

browsercontext-storage-state.spec.ts:453 is already broken on main, including this PR's own base commit 18205280, with a byte-identical error. Nothing in the roll is responsible.

Details

Pre-existing flake / infra

Caused by this PR

  • None.

The 9 flaky results all passed on retry and are outside the scope of this verdict.

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [firefox] › mcp/annotate.spec.ts:137 › should abort MCP annotation when last screenshot is removed @mcp-windows-latest-firefox
❌ [webkit] › mcp/cli-killall.spec.ts:42 › kill-all kills filtered dashboard pid @mcp-windows-latest-webkit

8562 passed, 1446 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 All three failures are pre-existing — the roll is clear

Hi, I'm the Playwright bot and I triaged the failing CI runs.

Both MCP failures are known flakes that fail with byte-identical errors on main at SHAs long before this roll, and the firefox-library storage-state failure is already broken on main (33 of its last 34 runs, most recently today). Nothing here points at Firefox r1548.

Details

This PR changes only the Firefox build: NetworkRequest._releaseReferences() in juggler/NetworkObserver.js, a proto-chain fix in juggler/content/Runtime.js::getObjectProperties, and the browsers.json revision bump. None of the three failing tests exercise that code — two are MCP UI/CLI tests (one of them WebKit-only), and the third predates the roll on main.

Pre-existing flake / infra

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

5 failed
❌ [firefox-library] › library/browsercontext-storage-state.spec.ts:453 › should work when service worker is intefering and the origin is not open @tracing-firefox
❌ [firefox-library] › library/browsercontext-storage-state.spec.ts:453 › should work when service worker is intefering and the origin is not open @firefox-macos-15-large
❌ [firefox-library] › library/browsercontext-storage-state.spec.ts:453 › should work when service worker is intefering and the origin is not open @firefox-windows-latest
❌ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe @firefox-macos-15-xlarge
❌ [firefox-library] › library/browsercontext-storage-state.spec.ts:453 › should work when service worker is intefering and the origin is not open @firefox-macos-15-xlarge

29 flaky ⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:361 › reuse launch › should work with routeWebSocket `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/browsercontext-reuse.spec.ts:361 › reuse connect › should work with routeWebSocket `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:105 › cli codegen › should upload a single file `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:28 › context.cookies() should work Radoslav Kirilov (@smoke) `@msedge-windows-latest`
⚠️ [chromium-page] › page/workers.spec.ts:63 › should have timestamp on worker console messages `@msedge-windows-latest`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1915 › should not leak recorders `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/capabilities.spec.ts:477 › should not crash on feature detection for PublicKeyCredential `@chrome-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:179 › serviceWorker(), and fromServiceWorker() work `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:70 › selector generator › should not escape spaces inside named attr selectors `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:556 › selector generator › should generate title selector `@chrome-macos-latest`
⚠️ [electron-page] › page/workers.spec.ts:63 › should have timestamp on worker console messages `@electron-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@tracing-firefox`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@tracing-firefox`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:121 › should show tracing.group in the action list with location `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1915 › should not leak recorders `@firefox-macos-15-xlarge`
⚠️ [webkit-library] › library/video.spec.ts:113 › screencast › should capture static page `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/capabilities.spec.ts:209 › make sure that XMLHttpRequest upload events are emitted correctly `@webkit-macos-15-large`
⚠️ [android-page] › page/selectors-frame.spec.ts:203 › should click in lazy iframe

111373 passed, 4739 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 Neither failure is caused by this roll

Hi, I'm the Playwright bot and I triaged the failing CI here.

Both failing tests are Firefox-only, but neither traces back to r1548: the storage-state one is a known break that fails on main too, and the partitioned-cookie one is a long-standing flake.

Details

This PR only touches NetworkObserver.js (releasing references on finished/redirected requests) and Runtime.js (getObjectProperties rewrite). Neither failure exercises those paths, and both reproduce off this branch.

Pre-existing flake / infra

No failure in this report needs a change to the roll.

Triaged by the Playwright bot - agent run

@dgozman
Dmitry Gozman (dgozman) merged commit ad86e96 into main Sep 16, 2026
68 of 75 checks passed
@dgozman
Dmitry Gozman (dgozman) deleted the roll-into-pw-firefox/1548 branch September 16, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant