Skip to content

test: JSHandle.getProperties() returns own properties only - #42749

Open
Dmitry Gozman (dgozman) wants to merge 1 commit into
microsoft:mainfrom
dgozman:test-42651
Open

Dmitry Gozman (dgozman) wants to merge 1 commit into
microsoft:mainfrom
dgozman:test-42651

Conversation

@dgozman

Copy link
Copy Markdown
Collaborator

Fixes #42651.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [firefox-library] › library/browsercontext-storage-state.spec.ts:453 › should work when service worker is intefering and the origin is not open @firefox-ubuntu-22.04-node20

5 flaky ⚠️ [chromium-library] › library/tracing.spec.ts:533 › should produce screencast frames fit `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:699 › screencast › should capture full viewport on hidpi `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`

51730 passed, 1247 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 The one failure is pre-existing — this PR is clear

Hi, I'm the Playwright bot and I triaged the CI failures here.

[firefox-library] › library/browsercontext-storage-state.spec.ts:453 › should work when service worker is intefering and the origin is not open is broken on main, not by this PR. It fails on the PR's own base sha ad86e96 (run 35130186999) and on every recent unrelated PR.

Details

This PR only adds a test to tests/page/jshandle-properties.spec.ts and renames a neighbouring one — no product code, and nothing the storage-state/service-worker path imports. The single failure is unrelated on every axis.

Pre-existing flake / infra

The 5 flaky results (tracing/video screencast on Chromium, third-party Partitioned; cookies on Firefox) all passed on retry and touch nothing this PR changes.

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [chrome] › mcp/annotate.spec.ts:137 › should abort MCP annotation when last screenshot is removed @mcp-windows-latest-chrome

8576 passed, 1446 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 The single MCP failure is a known flake — this PR is clear

Hi, I'm the Playwright bot and I triaged the CI failures here.

[chrome] › mcp/annotate.spec.ts:137 › should abort MCP annotation when last screenshot is removed has been failing the same way on unrelated PRs and on main for weeks. This PR is test-only (tests/page/jshandle-properties.spec.ts), so it can't reach the MCP annotate dashboard.

Details

The PR adds one test to tests/page/jshandle-properties.spec.ts and touches no product code, no shared helper, and nothing under packages/playwright/src/mcp. Both failures across the reports are unrelated on every axis.

Pre-existing flake / infra

The 5 flaky results in "tests 1" (tracing/video screencast on Chromium, third-party Partitioned; cookies on Firefox) all passed on retry and touch nothing this PR changes.

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: jsHandle.getProperties() returns inherited properties on Firefox, own-only on Chromium and WebKit

2 participants