Skip to content

fix(firefox): use bypassServiceWorker flag for storage state pages - #42741

Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:ff-fix-42656
Sep 16, 2026
Merged

Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:ff-fix-42656

Conversation

@dgozman

Copy link
Copy Markdown
Collaborator

References #42656.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

7 flaky ⚠️ [chromium-page] › page/page-history.spec.ts:94 › goBack/goForward should work with bfcache-able pages `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:356 › screencast › should work for popups `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`

51721 passed, 1247 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [firefox] › mcp/cli-session.spec.ts:54 › idle timeout shuts the session down @mcp-windows-latest-firefox

8563 passed, 1446 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 The one failure is a known pre-existing flake — this PR looks clear

Hi, I'm the Playwright bot and I took a look at the failing CI.

[firefox] › mcp/cli-session.spec.ts:54 › idle timeout shuts the session down on @mcp-windows-latest-firefox fails with the same Expected substring: "(no browsers)" assertion on main and on a dozen unrelated PRs — including commit 1820528, which is this PR's own base. It has failed 16 of 47 runs (34%) on that bot, and never once on any of the other 12 MCP bots.

Details

Pre-existing flake / infra

The 7 flaky tests in "tests 1" all passed on retry and none of them touch Firefox request interception or storage state, so there's nothing to triage there.

Triaged by the Playwright bot - agent run

@dgozman
Dmitry Gozman (dgozman) merged commit bb78937 into microsoft:main Sep 16, 2026
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants