Skip to content

feat(evaluate): opt in to Map and Set serialization - #42709

Open
Yury Semikhatsky (yury-s) wants to merge 3 commits into
microsoft:mainfrom
yury-s:feat-evaluate-extended-serialization
Open

Yury Semikhatsky (yury-s) wants to merge 3 commits into
microsoft:mainfrom
yury-s:feat-evaluate-extended-serialization

Conversation

@yury-s

@yury-s Yury Semikhatsky (yury-s) commented Sep 14, 2026

Copy link
Copy Markdown
Member
  • Add the JS-only serialize: ["Map", "Set"] option to evaluation APIs, with each type independently selectable and default behavior unchanged.
  • Preserve Map and Set values for component mount and update, including callbacks inside collections.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

🟡 Two of the three MCP failures are known flakes; the dialog timeout is unproven

Hi, I'm the Playwright bot and I triaged the MCP run.

Nothing here points at the serialization change: the webmcp and cli-core failures both have a track record on unrelated SHAs. The dialogs timeout has no prior occurrence, so I can't call it either way.

Details

Pre-existing flake / infra

Uncertain

  • [chrome] › mcp/dialogs.spec.ts:263 › alert dialog w/ raceTest timeout of 30000ms exceeded. McpError: MCP error -32000: Connection closed. This is the test's only failure in 2136 runs, so I have no prior occurrence to point at. The signature is generic infra noise though — Connection closed shows up across 54 runs and 20 different MCP tests — and it was the single failure on that shard while the other 8561 MCP tests passed. The PR adds a serialization: 'extended' option that defaults to the old behaviour and doesn't touch dialog handling or the MCP transport, so a causal link isn't obvious. A rerun of that shard would settle it.

Separately, the trace-viewer.spec.ts failures in the "tests 1" report are real and caused by this PR — see the other comment.

Triaged by the Playwright bot - agent run

Comment thread docs/src/api/params.md Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@yury-s Yury Semikhatsky (yury-s) changed the title feat(evaluate): expose extended serialization for component testing feat(evaluate): opt in to Map and Set serialization Sep 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

8564 passed, 1446 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [firefox-library] › library/browsercontext-storage-state.spec.ts:453 › should work when service worker is intefering and the origin is not open @firefox-ubuntu-22.04-node20

5 flaky ⚠️ [installation tests] › playwright-cli.spec.ts:21 › cli should work `@package-installations-macos-latest`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`

51760 passed, 1247 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 The one failure is pre-existing — it's broken on main, not by this PR

Hi, I'm the Playwright bot and I took a look at the CI failures here.

[firefox-library] › library/browsercontext-storage-state.spec.ts:453 › should work when service worker is intefering and the origin is not open fails in 39 of 39 runs in the aggregated CI results, including 22 push runs on main and a dozen unrelated PRs, all with the byte-identical error. Nothing here points at this PR.

Details

Overall: 1 failure, 5 flaky. The failure is a currently-broken test on main; the flakes are unrelated to the diff. Nothing in this PR's CI signal argues against it.

Pre-existing flake / infra

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants