feat: merge-state column in PR tables#4
Merged
Conversation
Add a colorblind-safe "State" column to the All PRs / Inbox / per-repo tables showing GitHub's mergeable status (✓ ok / ✗ cf / ? unknown). - queries: request mergeable + mergeStateStatus in search & repo PR queries - models: PullRequest.mergeable + merge_state_status (Option, #[serde(default)] so older cache entries still deserialize) - graphql: parse both fields; UNKNOWN/absent -> None (search API is lazy) - ui: State column with theme colors, widths adjusted - tests: parse roundtrip, CONFLICTING, and legacy-cache serde-default coverage Refs: zombocoder#1, zombo-sash-eco-rpjg
Contributor
Author
|
@zombocoder requesting your review 🙏 — this is task 1 of 2 (merge-state column). The stacked follow-up (detail pane) is coming as a separate cascade PR. |
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a colorblind-safe
Statecolumn to the All PRs / Inbox / per-repo tables,showing GitHub's
mergeablestatus (✓ ok/✗ cf/?).See the before/after mockup and rationale in the issue.
Changes
queries: requestmergeable+mergeStateStatusin search & repo PR queriesmodels:PullRequest.mergeable+merge_state_status(Option,#[serde(default)]so existing disk-cache entries still deserialize)
graphql: parse both fields; UNKNOWN/absent →Noneui:Statecolumn with theme colors, widths adjustedtests: parse roundtrip, CONFLICTING, legacy-cache serde-default coverageNote on
mergeableThe search API computes
mergeablelazily, so it is frequentlyUNKNOWNhere (renderedas a dim
?). The authoritative, freshly-computed value is delivered by the detail panein the stacked follow-up (#3).
Testing
cargo build,cargo test(all pass),cargo fmt --check,cargo clippy— clean(no new warnings).
Closes #2
Part of #1