fix: satisfy clippy unnecessary_sort_by (Rust 1.96)#8
Merged
Conversation
…ort_by Rust 1.96's clippy flags manual comparator closures that just reverse a key. Use sort_by_key(|x| Reverse(...)) instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI clippy (Rust 1.96) fails on
mainwithclippy::unnecessary_sort_by, which also blocks the open PRs (#4, #5) since they inherit the failure from the base branch.Fix
Replace the manual reversing comparator closures with
sort_by_key(|x| std::cmp::Reverse(...))as clippy suggests.Verified with
cargo clippy --all-targets --all-features(clean).