feat: filter PRs by merge state + help/legend overlay#11
Merged
Conversation
Contributor
Author
|
@zombocoder requesting your review 🙏 — final piece (filter + help/legend). Cascades on #7 (→ #5 → #4); please review/merge last. |
Rebased onto current main and reconciled with the git-log/diff overlay rework (zombocoder#9): the filter + help are additive and independent of the per-PR Overlay state. - `f` cycles the merge filter: all -> conflicting -> clean; active filter shown in the table title. Composes with `/` search (applied in filtered_prs). - `?` opens a help overlay documenting all keybindings (incl. l: log, d: diff) and the State/CI glyph legends (accessibility: glyphs are now documented). - state: MergeFilter enum + merge_filter/help_open; Esc/h close help first. - tests: cycle order, help toggle, back-closes-help, filter + search composition. Refs: zombocoder#10, zombo-sash-eco-pp0u
e23f477 to
7876b30
Compare
Contributor
Author
|
Rebased onto current
The filter/help are additive and independent of the per-PR @zombocoder ready for another look 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a merge-state filter (
f) and a help overlay (?) with the State/CI glyphlegends — the final piece of the merge-state visibility epic (#1).
fcycles all → conflicting → clean; active filter shown in the table title andcomposes with
/search.?opens a help overlay documenting every keybinding + both glyph legends (CI-5).Last in the cascade. Until the earlier PRs merge, the diff shows all four commits;
review/merge after #4, #5, #7. Only the last commit belongs to this PR.
Changes
state:MergeFilter{All, Conflicting, Clean} applied infiltered_prs(one place →every view);
help_openflag;Esc/hclose overlaysevent_loop:f→ cycle filter,?→ toggle helpui: table-title filter indicator;render_help_overlay; status-bar hints updatedtests: cycle order, help toggle, back-closes-help, filter selection + search compositionTesting
cargo build,cargo test(8 binaries; state_tests 38),cargo fmt --check,cargo clippy— clean (no new warnings).Closes #10
Part of #1