feat: PR detail-on-highlight pane (fresh mergeable + CI + git log)#5
Merged
Merged
Conversation
Add a colorblind-safe "State" column to the All PRs / Inbox / per-repo tables showing GitHub's mergeable status (✓ ok / ✗ cf / ? unknown). - queries: request mergeable + mergeStateStatus in search & repo PR queries - models: PullRequest.mergeable + merge_state_status (Option, #[serde(default)] so older cache entries still deserialize) - graphql: parse both fields; UNKNOWN/absent -> None (search API is lazy) - ui: State column with theme colors, widths adjusted - tests: parse roundtrip, CONFLICTING, and legacy-cache serde-default coverage Refs: zombocoder#1, zombo-sash-eco-rpjg
Press `d` on a highlighted PR to open a detail overlay that fetches the PR directly — forcing GitHub to compute a fresh mergeable/mergeStateStatus (the search API returns UNKNOWN) — plus the CI check rollup and recent commits. - queries: PR_DETAIL_QUERY (mergeable, mergeStateStatus, commits(last:5) + per-commit statusCheckRollup) - github: fetch_pr_detail + parse_pr_detail; CommitInfo + PrDetail models - state/update: detail_open + pr_details cache; ToggleDetail; Back closes the pane; Refresh clears cached details; resolved detail upgrades the list column - event_loop: `d` key; 200ms debounce so holding j/k never sprays API calls and navigation stays responsive; fetch runs behind the existing semaphore - ui: render_pr_detail_overlay (merge state + CI + commits), status-bar hint - tests: toggle, back-closes-pane, list-upgrade, refresh-clears, failure path Refs: zombocoder#1, zombo-sash-eco-zkk5
Contributor
Author
|
@zombocoder requesting your review 🙏 — task 2 of 2 (detail-on-highlight pane). This cascades on #4; please review/merge after #4. |
zombocoder
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Press
don a highlighted PR to open a detail pane that fetches the PR directly —forcing GitHub to compute a fresh
mergeable/mergeStateStatus(the list/search APIreturns UNKNOWN) — plus the CI check rollup and recent commits (git log). See the overlay
mockup in the issue.
This PR cascades on top of #4 (merge-state column). Until #4 merges, the diff here
shows both commits; review/merge after #4. The first commit (
add merge-state column)belongs to #4.
Changes
queries:PR_DETAIL_QUERY(mergeable, mergeStateStatus,commits(last:5)+per-commit
statusCheckRollup);fetch_pr_detailclient methodmodels:CommitInfo+PrDetailstate/update:detail_open+pr_detailscache;ToggleDetail;Backcloses thepane;
Refreshclears cached details; resolved detail upgrades the list columnevent_loop:dkey; 200ms debounce so holdingj/knever sprays API calls andnavigation stays responsive; fetch runs behind the existing semaphore
ui:render_pr_detail_overlay(merge state + CI + commits); status-bar hinttests: toggle, back-closes-pane, list-upgrade, refresh-clears, failure pathTesting
cargo build,cargo test(8 binaries pass),cargo fmt --check,cargo clippy— clean.Closes #3
Part of #1