Skip to content

PM-5775: show checkpoint winner indicator - #2082

Merged
jmgasper merged 1 commit into
devfrom
PM-5775
Jul 31, 2026
Merged

PM-5775: show checkpoint winner indicator#2082
jmgasper merged 1 commit into
devfrom
PM-5775

Conversation

@jmgasper

Copy link
Copy Markdown
Collaborator

What was broken

Checkpoint Review displayed review scores without identifying members who had won a checkpoint prize.

Root cause

The Review app did not preserve the Challenge API's checkpoint-winner data separately from final placements or render it in the checkpoint score column.

What was changed

  • Preserve dedicated checkpoint winners in the Review challenge model, with support for legacy combined winner data.
  • Show an accessible gold star beside the checkpoint score for every row belonging to a winning member.
  • Provide click, hover, and keyboard access to a tooltip explaining that the member is a checkpoint winner and is eligible for the associated checkpoint prize.
  • Preserve existing score links and pending-score rendering.

Checkpoint winner records are member-level and do not include a submission ID, so the indicator intentionally appears on every checkpoint row belonging to a winning member.

Any added/updated tests

  • Added table coverage for winner and non-winner rows, repeated submissions by a winner, score preservation, links, tooltip copy, and trigger behavior.
  • Updated challenge model coverage for dedicated checkpoint winners and legacy combined winner data.

Validation

  • yarn test:no-watch --runInBand src/apps/review/src — 39 suites and 143 tests passed.
  • yarn lint — passed.
  • yarn run build — passed with existing build warnings.
  • The repository-wide yarn test:no-watch still reports 13 pre-existing failing suites outside the Review app (Work, Wallet Admin, and Engagements); 195 of 208 suites and 921 of 957 tests pass, including all PM-5775 coverage.

Paired change

Requires Challenge API PR #141 to expose checkpoint winners after Checkpoint Review closes.

What was broken

Checkpoint Review showed scores without identifying members who had won a checkpoint prize.

Root cause

The review app did not model or render the Challenge API's separate checkpointWinners data.

What was changed

- Preserve checkpoint winners separately from final-placement winners.
- Show an accessible star beside checkpoint scores for winning members with click, hover, and keyboard tooltip details.
- Document the member-level winner matching used by the table.

Any added/updated tests

- Added checkpoint table coverage for winner and non-winner rows, repeated submissions, score links, and tooltip behavior.
- Updated challenge model coverage for dedicated and legacy checkpoint winner data.
@jmgasper
jmgasper requested a review from kkartunov as a code owner July 30, 2026 14:58
@jmgasper
jmgasper merged commit 82e2476 into dev Jul 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant