Conversation
What was broken A Review page opened while Checkpoint Review was active could retain a challenge response without checkpoint winners after the phase closed, so the existing winner star never received the data it needed. Root cause The Challenge API intentionally hides checkpoint winners until Checkpoint Review closes, while the Review app disabled automatic challenge refreshes and did not poll that transition. What was changed Poll challenge details every ten seconds only while an active Checkpoint Review is open and checkpoint winners are still unavailable. Polling stops once the phase closes, winner data arrives, the challenge completes, or another phase is active. Any added/updated tests Added refresh-interval coverage for active Checkpoint Review, closed review, populated winner data, completed challenges, and unrelated phases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
A Review page opened while Checkpoint Review was active could keep the earlier challenge response after the phase closed. That response intentionally omitted checkpoint winners, so the winner star added in PR #2082 had no data to render.
Root cause
The Challenge API exposes checkpoint winners only after Checkpoint Review closes. Platform UI globally disables focus revalidation and challenge-detail polling, leaving the pre-closure response cached for the lifetime of the mounted page.
What was changed
Any added/updated tests
yarn test:no-watch --runInBand src/apps/review/src— 47 suites and 170 tests passed.yarn lint— passed.yarn run build— passed with existing repository warnings.