Conversation
What was broken Checkpoint winner stars and eligibility tooltips appeared on below-threshold Checkpoint Review rows when the same member was listed as a checkpoint winner. Root cause Checkpoint winner records are member-level, and the table matched them only by member ID. It therefore marked every row for the member without considering the row's threshold-derived PASS or NO PASS result. What was changed Require a checkpoint-review row to have a PASS result before rendering the winner star and eligibility tooltip. Update the Review documentation to describe the row-level eligibility rule. Any added/updated tests Add a same-member 0.00 NO PASS row and verify it has no checkpoint-winner indicator while repeated passing rows remain marked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Platform UI PR #2082 added a checkpoint-winner star and eligibility tooltip by matching checkpoint winner member IDs, and PR #2096 refreshed winner data after Checkpoint Review closed. QA then found that a below-minimum checkpoint-review row for the same winning member also displayed the star and eligibility tooltip.
Root cause
Challenge checkpoint-winner records identify the member but do not identify a submission. The Review table therefore marked every row for that member and ignored the row's threshold-derived PASS or NO PASS result.
What was changed
Any added/updated tests
Validation
yarn test:no-watch --runInBand src/apps/review/src/lib/components/TableCheckpointSubmissions/TableCheckpointSubmissions.spec.tsx— 1 suite and 1 test passed.yarn test:no-watch --runInBand src/apps/review/src— 48 suites and 171 tests passed.yarn run build— passed with existing repository warnings.yarn lintwas run and is blocked only by a pre-existingno-confusing-arrowerror inReviewViewer.spec.tsxon the currentdevbaseline; that unrelated file is not changed by this PR.