Conversation
What was broken The Challenge API hid assigned checkpoint winners until the entire challenge was completed, so the review app could not identify winners after Checkpoint Review. Root cause Winner response sanitization removed both final-placement and checkpoint winner data for every non-completed challenge. What was changed - Expose checkpoint winners for active challenges only after Checkpoint Review has opened and closed. - Continue hiding final-placement winners until challenge completion. - Document when checkpoint winners are returned. Any added/updated tests - Added detail and listing coverage for open and closed Checkpoint Review states. - Verified placement winners remain hidden while checkpoint winners become visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Checkpoint winners assigned during an active challenge were hidden until the entire challenge completed, so the Review app could not tell a member that they had won a checkpoint prize.
Root cause
Challenge response sanitization treated checkpoint winners like final-placement winners and removed both from every non-completed challenge.
What was changed
Any added/updated tests
Validation
NODE_ENV=test pnpm exec mocha --require ts-node/register/transpile-only test/unit/ChallengeService.test.js --grep "returns checkpoint winners after checkpoint review closes" --timeout 30000 --exit— passed.pnpm lint— passed.pnpm build— passed.pnpm teststill reports 143 pre-existing failures caused by unavailable local mock services and existing harness/schema expectation issues; the PM-5775 regression test passes independently.Paired change
Paired with Platform UI PR #2082, which renders the checkpoint-winner indicator and tooltip.