Repository navigation
fix: fig6_26 and fig6_27 pass lidar=True to PoseGraph, not laser= - #56
Open
petercorke wants to merge 1 commit into
Open
petercorke wants to merge 1 commit into
petercorke wants to merge 1 commit into
Conversation
PoseGraph's argument has been called lidar since RTB 1.4.0; laser= raised TypeError so these two figure scripts could not run. The chapter 6 notebook already uses lidar=True. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fig6_26.pyandfig6_27.pycalledPoseGraph('data/killian.g2o.zip', laser=True). The argument islidar(it is in the released RTB 1.4.4 signature,PoseGraph(filename, lidar=False, verbose=False)), so both scripts raisedTypeErrorand could not run. The chapter 6 notebook already useslidar=True.Two lines changed; no other behaviour. Works with the released RTB, so this can merge now.
Test plan
PoseGraph.__init__signature of the released RTB 1.4.4 wheel checked:lidar=False🤖 Generated with Claude Code