Repository navigation
chore: use the argument names of RTB 1.4.5 in the chapter 5 and 6 figure scripts - #57
Draft
petercorke wants to merge 1 commit into
Draft
petercorke wants to merge 1 commit into
petercorke wants to merge 1 commit into
Conversation
…ure scripts Needs RTB 1.4.5: goal_style, path_style, edge_style, vertex_style, ellipse_style, text_opt/labels and the optimize/plot_map style arguments. colorbar=dict(shrink=1.2) (fig5_12) and inflated=True (fig5_16) were silently ignored by RTB 1.4.4 and are an error in 1.4.5, so they are dropped; the figures are unchanged by that. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Do not merge until RTB 1.4.5 is on PyPI. The scripts then only run with 1.4.5, and the book's rule is that every figure runs against the released RTB (1.4.4 today, which has only the old names). Opened as a draft so the change is ready and reviewable.
Renames the arguments that RTB 1.4.5 has deprecated, so the figure scripts run without
DeprecationWarnings and keep working when the old names are removed:fig5_12.pygoal_marker=→goal_style=fig5_16.pypath_marker=→path_style=fig5_19.py,fig5_20.pyedge=,vertex=→edge_style=,vertex_style=;path_marker=→path_style=fig6_11.py,fig6_13.pyplot_map(ellipse=)→ellipse_style=fig6_17.pyoptimize/ploteopt=,vopt=→edge_style=,vertex_style=;text=False→labels=False;text=dict(...)→text_opt=dict(...)Two arguments are dropped, because RTB 1.4.4 silently ignored them (it swallowed unknown keywords) and 1.4.5 makes them an error:
colorbar=dict(shrink=1.2)infig5_12.pyandinflated=Trueinfig5_16.py(it is the default anyway). The generated figures do not change by this.Visible changes to the figures (not from this PR, from RTB 1.4.5)
path_markerused to have no effect and now does.Not in this PR
notebooks/chap5.ipynbcells 55, 56:dx.plot(labelvalues=True), another keyword that was silently ignored. Waiting on a decision in RTB on whether unknown keywords are an error.laser=True→lidar=Trueinfig6_26.py,fig6_27.pyis fix: fig6_26 and fig6_27 pass lidar=True to PoseGraph, not laser= #56.🤖 Generated with Claude Code