Skip to content

Swap settings shortcuts#256

Merged
pascalpp merged 1 commit into
pascal/228-feature-multiple-rulersfrom
codex/250-swap-settings-shortcuts
Jun 19, 2026
Merged

Swap settings shortcuts#256
pascalpp merged 1 commit into
pascal/228-feature-multiple-rulersfrom
codex/250-swap-settings-shortcuts

Conversation

@pascalpp

@pascalpp pascalpp commented Jun 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • Swaps the keyboard shortcuts so Ruler Settings uses Command-Comma and app settings uses Command-Option-Comma.
  • Updates the main settings window title to Free Ruler Settings.
  • Keeps localized menu and window resources in sync with the shortcut/title changes.

Tests

  • xcodebuild -project "Free Ruler.xcodeproj" -scheme "Free Ruler" test -only-testing:FreeRulerTests

Closes #250

pascalpp commented Jun 19, 2026

Copy link
Copy Markdown
Owner Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pascalpp pascalpp force-pushed the codex/250-swap-settings-shortcuts branch from 4b388db to 94e4753 Compare June 19, 2026 18:47
@pascalpp pascalpp force-pushed the codex/249-cycle-rulers-command branch from db0f629 to 055b7b7 Compare June 19, 2026 18:47
@pascalpp

Copy link
Copy Markdown
Owner Author

[codex reviewer] Reviewed the settings shortcut swap. No blocking feedback from me; the XIB shortcut changes and localized menu/window title updates are consistent with the intended app settings vs ruler settings split.

@pascalpp pascalpp marked this pull request as ready for review June 19, 2026 19:11
@pascalpp pascalpp force-pushed the codex/250-swap-settings-shortcuts branch from 94e4753 to f720ed9 Compare June 19, 2026 19:28
@pascalpp pascalpp force-pushed the codex/249-cycle-rulers-command branch from 055b7b7 to f24f55d Compare June 19, 2026 19:28
@pascalpp pascalpp changed the base branch from codex/249-cycle-rulers-command to graphite-base/256 June 19, 2026 19:30
@pascalpp pascalpp force-pushed the codex/250-swap-settings-shortcuts branch from f720ed9 to c55cf7f Compare June 19, 2026 19:30
@pascalpp pascalpp force-pushed the graphite-base/256 branch from f24f55d to 593087f Compare June 19, 2026 19:30
@pascalpp pascalpp changed the base branch from graphite-base/256 to pascal/228-feature-multiple-rulers June 19, 2026 19:30
@pascalpp pascalpp merged commit 1580720 into pascal/228-feature-multiple-rulers Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant