Rename primary ruler window#257
Merged
pascalpp merged 1 commit intoJun 19, 2026
Merged
Conversation
This was referenced Jun 19, 2026
Owner
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 19, 2026
Merged
pascalpp
force-pushed
the
codex/250-swap-settings-shortcuts
branch
from
4b388db to
94e4753
Compare
pascalpp
force-pushed
the
codex/251-ruler-window-cleanup
branch
from
837d7c3 to
c4a404e
Compare
Owner
Author
|
[codex reviewer] Reviewed the primary ruler window rename. No blocking feedback from me; the legacy separate-window path is consistently moved to LegacyRulerWindow, stale GroupedRulerWindow type references are gone, and the top-stack unit test run builds this phase successfully. |
pascalpp
force-pushed
the
codex/250-swap-settings-shortcuts
branch
from
94e4753 to
f720ed9
Compare
pascalpp
force-pushed
the
codex/251-ruler-window-cleanup
branch
from
c4a404e to
c27b2d1
Compare
pascalpp
force-pushed
the
codex/250-swap-settings-shortcuts
branch
from
f720ed9 to
c55cf7f
Compare
pascalpp
force-pushed
the
codex/251-ruler-window-cleanup
branch
from
c27b2d1 to
7f8674c
Compare
pascalpp
changed the base branch from
codex/250-swap-settings-shortcuts
to
graphite-base/257
pascalpp
force-pushed
the
codex/251-ruler-window-cleanup
branch
from
7f8674c to
7322550
Compare
pascalpp
force-pushed
the
graphite-base/257
branch
from
c55cf7f to
1580720
Compare
pascalpp
changed the base branch from
graphite-base/257
to
pascal/228-feature-multiple-rulers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RulerWindowname.LegacyRulerWindow.Tests
xcodebuild -project "Free Ruler.xcodeproj" -scheme "Free Ruler" test -only-testing:FreeRulerTestsCloses #251