Constrain ruler settings controls#258
Merged
pascalpp merged 5 commits intoJun 19, 2026
Merged
Conversation
This was referenced Jun 19, 2026
Merged
Owner
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
pascalpp
force-pushed
the
codex/252-ruler-settings-constraints
branch
from
3e5c24b to
2716ef1
Compare
pascalpp
force-pushed
the
codex/251-ruler-window-cleanup
branch
from
837d7c3 to
c4a404e
Compare
pascalpp
force-pushed
the
codex/252-ruler-settings-constraints
branch
from
70d1b7a to
91f52fc
Compare
Owner
Author
|
[codex reviewer] Reviewed the constrained ruler-settings controls layout. No blocking feedback from me; the moved XIB labels have matching localized strings, the unit abbreviations are unchanged across existing localizations, and the top-stack FreeRulerTests run passed. |
pascalpp
force-pushed
the
codex/252-ruler-settings-constraints
branch
from
ebe59a9 to
25b6e87
Compare
pascalpp
force-pushed
the
codex/251-ruler-window-cleanup
branch
2 times, most recently
from
c27b2d1 to
7f8674c
Compare
pascalpp
force-pushed
the
codex/252-ruler-settings-constraints
branch
2 times, most recently
from
ae55608 to
e4833ea
Compare
pascalpp
force-pushed
the
codex/251-ruler-window-cleanup
branch
from
7f8674c to
7322550
Compare
…just frame sizes and positions for better alignment and usability across various views.
…oning and adding constraints for improved alignment and responsiveness.
pascalpp
changed the base branch from
codex/251-ruler-window-cleanup
to
graphite-base/258
pascalpp
force-pushed
the
codex/252-ruler-settings-constraints
branch
from
e4833ea to
f139303
Compare
pascalpp
force-pushed
the
graphite-base/258
branch
from
7322550 to
6e76cff
Compare
pascalpp
changed the base branch from
graphite-base/258
to
pascal/228-feature-multiple-rulers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
xcodebuild -project "Free Ruler.xcodeproj" -scheme "Free Ruler" test -only-testing:FreeRulerTestsCloses #252