You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Implements #232 as part of #228. Threads per-ruler settings through grouped windows and rule views so Preferences edits defaults for future rulers without mutating existing managed rulers.
[codex reviewer] Two issues I would fix in this phase:
Active ruler background opacity can leave the foreground window faded. In RulerSettingsController.setBackgroundOpacity (Free Ruler/PreferencesController.swift:441) the controller writes settings.backgroundOpacity, then sets rulerController?.opacity to the background value. Unlike the global Preferences flow, the ruler settings sheet does not post the preferences-window closed notification or otherwise restore foreground opacity in windowWillClose (Free Ruler/PreferencesController.swift:424). Repro: open Ruler Settings for a visible ruler, move Background Opacity to 5%, close the sheet. The active ruler stays at 5% alpha until app activation changes it. I would reset to state.settings.foregroundOpacity when the sheet closes, or only preview background opacity while the app is actually backgrounded. Please add a regression test around closing the settings controller after changing the background slider.
The new static Ruler Settings... menu item is only added to Base.lproj/MainMenu.xib (Free Ruler/Base.lproj/MainMenu.xib:107). I do not see matching rSt-Tg-232.title entries in de/es/fi/ja/zh-hans.lproj/MainMenu.strings, and the string catalog entry for the settings window title will not localize a XIB menu title. Non-English menus will show the English label. Please add the XIB localization entries or set this title programmatically with NSLocalizedString.
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #232 as part of #228. Threads per-ruler settings through grouped windows and rule views so Preferences edits defaults for future rulers without mutating existing managed rulers.