Repository navigation
feat(agentconfig): secret detection, redaction and digests (4/15) - #472
Merged
gusfcarvalho merged 2 commits intoOct 6, 2026
Merged
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gusfcarvalho
added this pull request to stack #484
October 5, 2026 17:30
This was referenced Oct 5, 2026
gusfcarvalho
force-pushed
the
lisa/agent-config/04-redaction
branch
from
October 5, 2026 19:35
645cfa5 to
9d54ab3
Compare
This was referenced Oct 6, 2026
Fourth layer of the agent remote-configuration stack (split from #465): secret detection by key name and by value (linear URL-password scan, token patterns, scheme-less DSNs), Redact/RedactDocument/ScrubSecretText, and Digest over the redacted canonical config. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tector TestContainsSecretValueLinear asserted a fixed 2s budget, which the race detector's instrumentation exceeds (about 5s). Keep the linearity check but scale the budget x10 when built with -race (raceEnabled, set by build tag). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ccf-lisa
Bot
force-pushed
the
lisa/agent-config/04-redaction
branch
from
October 6, 2026 13:06
9d54ab3 to
0ffe5eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 4/15 of the agent remote-configuration stack
This stack splits #465 into reviewable layers of at most ~1000 changed lines each (counted without
docs/,go.sumand Markdown). The last layer's tree is identical to #465, which already has its review history.Stacked on #471 (
lisa/agent-config/03-classify). Review and merge in order.What's in this layer
Fourth layer of the agent remote-configuration stack (split from #465): secret detection by key name and by value (linear URL-password scan, token patterns, scheme-less DSNs), Redact/RedactDocument/ScrubSecretText, and Digest over the redacted canonical config.
Size: +1129 -0 = 1129 changed lines (without docs/go.sum).
size-exception: over 1000 LOC because of the tests that cover this layer; the implementation part is well under 1000.
Verification
Each layer builds on its own:
go build,go vet(also with-tags integration),golangci-lint runandgo test ./...pass, andmake swagleaves the tree clean. Integration suites for the packages this layer touches pass locally on testcontainers Postgres.🤖 Generated with Claude Code