Skip to content

feat(agentconfig): JSON diff, env references, plugin sources and ETags (2/15) - #470

Open
ccf-lisa[bot] wants to merge 1 commit into
lisa/agent-config/01-overlay-modelfrom
lisa/agent-config/02-diff-envrefs-sources
Open

ccf-lisa[bot] wants to merge 1 commit into
lisa/agent-config/01-overlay-modelfrom
lisa/agent-config/02-diff-envrefs-sources

Conversation

@ccf-lisa

@ccf-lisa ccf-lisa Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Part 2/15 of the agent remote-configuration stack

This stack splits #465 into reviewable layers of at most ~1000 changed lines each (counted without docs/, go.sum and Markdown). The last layer's tree is identical to #465, which already has its review history.

Stacked on #469 (lisa/agent-config/01-overlay-model). Review and merge in order.

What's in this layer

Second layer of the agent remote-configuration stack (split from #465): pointer-level JSON diff, ${env:NAME} references and the forbidden-name rule, plugin source kinds (OCI via go-containerregistry, local), trusted-source and overridable-flag matching for remote_config, cron schedule parsing, and opaque revision/admin ETags.

Size: +855 -7 = 862 changed lines (without docs/go.sum).

Verification

Each layer builds on its own: go build, go vet (also with -tags integration), golangci-lint run and go test ./... pass, and make swag leaves the tree clean. Integration suites for the packages this layer touches pass locally on testcontainers Postgres.

🤖 Generated with Claude Code

Second layer of the agent remote-configuration stack (split from #465): pointer-level JSON diff, ${env:NAME} references and the forbidden-name rule, plugin source kinds (OCI via go-containerregistry, local), trusted-source and overridable-flag matching for remote_config, cron schedule parsing, and opaque revision/admin ETags.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 391436bb-b3c3-4ff0-bdd8-dcf5e27db749

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gusfcarvalho gusfcarvalho left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ccf-review: APPROVE

no findings.

Stack (gh stack 484): #469 → #470 → #471 → #472 → #473 → #474 → #475 → #476 → #477 → #478 → #479 → #480 → #481 → #482 → #483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant