feat(api): admin agent config preview, revision history and revert (14/15) - #482
Open
ccf-lisa[bot] wants to merge 3 commits into
Open
ccf-lisa[bot] wants to merge 3 commits into
ccf-lisa[bot] wants to merge 3 commits into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gusfcarvalho
added this pull request to stack #484
October 5, 2026 17:30
This was referenced Oct 5, 2026
gusfcarvalho
requested changes
Oct 5, 2026
Fourteenth layer of the agent remote-configuration stack (split from #465): POST /api/admin/agents/{id}/config/preview validates a candidate overlay and shows, per instance, the redacted effective config, its diff, classified changes and whether the agent would apply it (bounded to 50 instances / 16 MiB of reported config, validated first; omitted-instances counts the rest; needs agent:configure); GET …/config/revisions lists revisions (paginated, newest first); POST …/revisions/{rev}/revert saves an old overlay as a new revision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PreviewBases loaded and decoded every validated instance's base through ValidationBases, and Preview validated the overlay against all of them only to discard the per-instance results, so the 50-instance / 16 MiB preview bound did not cover the validation set. Preview now validates the overlay alone, and PreviewBases reads the validation set as instance ids only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gusfcarvalho
force-pushed
the
lisa/agent-config/14-admin-config-preview
branch
from
October 5, 2026 19:35
7993a9e to
0c378d0
Compare
gusfcarvalho
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 14/15 of the agent remote-configuration stack
This stack splits #465 into reviewable layers of at most ~1000 changed lines each (counted without
docs/,go.sumand Markdown). The last layer's tree is identical to #465, which already has its review history.Stacked on #481 (
lisa/agent-config/13-admin-config-save). Review and merge in order.What's in this layer
Fourteenth layer of the agent remote-configuration stack (split from #465): POST /api/admin/agents/{id}/config/preview validates a candidate overlay and shows, per instance, the redacted effective config, its diff, classified changes and whether the agent would apply it (bounded to 50 instances / 16 MiB of reported config, validated first; omitted-instances counts the rest; needs agent:configure); GET …/config/revisions lists revisions (paginated, newest first); POST …/revisions/{rev}/revert saves an old overlay as a new revision.
Size: +654 -1 = 655 changed lines (without docs/go.sum).
Verification
Each layer builds on its own:
go build,go vet(also with-tags integration),golangci-lint runandgo test ./...pass, andmake swagleaves the tree clean. Integration suites for the packages this layer touches pass locally on testcontainers Postgres.🤖 Generated with Claude Code