Configurable MTU for VR by Pearl1594 · Pull Request #6426 · apache/cloudstack

Pearl1594 · 2022-05-31T07:53:18Z

Description

Allow admins and accounts to be able to configure MTU for the VR which is public/private facing.

Adds new zone-level configurations:

vr.public.interface.max.mtu(default: 1500) - The maximum value the MTU can have on the VR's public interfaces
vr.private.interface.max.mtu (default: 1500) - The maximum value the MTU can have on the VR's private interfaces
allow.end.users.to.specify.vr.mtu (default: false) - Allow end users to specify VR MTU

Doc PR: apache/cloudstack-documentation#279

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Screenshots (if appropriate):

How Has This Been Tested?

[root@ref-trl-3314-k-M7-pearl-dsilva-marvin ~]# nosetests --with-xunit --xunit-file=results.xml --with-marvin --marvin-config=/marvin/ref-trl-3314-k-M7-pearl-dsilva-advanced-cfg -s -a tags=advanced --hypervisor=KVM  test_network_mtu.py 
/usr/local/lib/python3.6/site-packages/paramiko/transport.py:33: CryptographyDeprecationWarning: Python 3.6 is no longer supported by the Python core team. Therefore, support for it is deprecated in cryptography and will be removed in a future release.
  from cryptography.hazmat.backends import default_backend

==== Marvin Init Started ====

=== Marvin Parse Config Successful ===

=== Marvin Setting TestData Successful===

==== Log Folder Path: /marvin/MarvinLogs/Jun_24_2022_13_14_12_8WONQQ All logs will be available here ====

=== Marvin Init Logging Successful===

==== Marvin Init Successful ====

=== TestName: test_01_create_isolated_network_with_mtu | Status : SUCCESS ===

=== TestName: test_02_update_isolated_network_with_mtu | Status : SUCCESS ===

=== Final results are now copied to: /marvin//MarvinLogs//YXRF3E ===

acs-robot · 2022-05-31T07:54:22Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-05-31T07:57:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-05-31T08:02:08Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6426 (SL-JID-1642)

acs-robot · 2022-06-01T12:22:53Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-01T12:26:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-06-01T12:32:50Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6426 (SL-JID-1654)

acs-robot · 2022-06-01T16:59:47Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-01T17:00:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-06-01T17:06:43Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6426 (SL-JID-1656)

DaanHoogland · 2022-06-03T08:53:43Z

@Pearl1594 can you look at the sonar cube code smells? they make sense mostly

Pearl1594 · 2022-06-03T09:05:04Z

Yes @DaanHoogland will do it. It's still work in progress. Thanks

acs-robot · 2022-06-09T10:53:24Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-09T10:54:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Pearl1594 · 2022-06-09T10:58:10Z

@blueorangutan package

blueorangutan · 2022-06-09T10:59:02Z

@Pearl1594 a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-12-28T08:15:03Z

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-12-28T09:20:18Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5106

yadvr · 2022-12-28T09:30:34Z

Building new 4.18 systemvmtemplate with this PR changes; will replace and kick pkging/builds once done. cc @shwstppr

shwstppr · 2022-12-28T11:25:48Z

@blueorangutan package

blueorangutan · 2022-12-28T11:26:04Z

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-12-28T12:19:32Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5119

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2022-12-30T06:20:37Z

@blueorangutan package

blueorangutan · 2022-12-30T06:21:05Z

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sonarqubecloud · 2022-12-30T07:02:44Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
5 Code Smells

20.5% Coverage
0.7% Duplication

blueorangutan · 2022-12-30T07:09:31Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5134

alexandremattioli · 2022-12-30T12:50:58Z

Reviewed and tested, LGTM

DaanHoogland · 2022-12-30T13:57:10Z

@blueorangutan test matrix

blueorangutan · 2022-12-30T13:58:03Z

@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2022-12-31T01:36:26Z

Trillian test result (tid-5719)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40645 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6426-t5719-xenserver-71.zip
Smoke tests completed. 106 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2022-12-31T02:35:47Z

Trillian test result (tid-5720)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 44207 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6426-t5720-vmware-67u3.zip
Smoke tests completed. 106 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2022-12-31T04:13:46Z

Trillian test result (tid-5721)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49965 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6426-t5721-kvm-centos7.zip
Smoke tests completed. 105 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	558.44	test_kubernetes_clusters.py

DaanHoogland · 2022-12-31T14:08:51Z

@weizhouapache @shwstppr @GutoVeronezi @jbampton do you approve now?

weizhouapache

code lgtm

NuxRo

LGTM

DaanHoogland · 2023-01-04T11:06:46Z

@blueorangutan package

blueorangutan · 2023-01-04T11:07:04Z

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

This reverts commit 3044d63.

blueorangutan · 2023-01-04T11:19:02Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 5171

boring-cyborg Bot added component:api component:compute component:kubernetes component:networking component:orchestration component:vpc labels May 31, 2022

Pearl1594 force-pushed the configurable-mtu branch from 61e34fa to 61a07bd Compare June 1, 2022 16:58

nvazquez force-pushed the main branch from c56220f to 0f4c3af Compare June 6, 2022 15:14

boring-cyborg Bot added the component:kvm label Jun 9, 2022

Pearl1594 added 4 commits June 9, 2022 16:23

VR: Support configurable MTU

74e9599

add support for vpc networks

95fa5f5

pass mtu for vpc tier network

a43c40a

add support to update interface mtu

633a84d

update upgrade path

d096549

Pearl1594 force-pushed the configurable-mtu branch from 11bdf29 to d096549 Compare June 9, 2022 10:55

shwstppr closed this Dec 30, 2022

shwstppr reopened this Dec 30, 2022

ui; fix label

8884051

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

DaanHoogland marked this pull request as ready for review December 30, 2022 14:01

weizhouapache approved these changes Dec 31, 2022

View reviewed changes

NuxRo approved these changes Jan 3, 2023

View reviewed changes

DaanHoogland merged commit 3044d63 into apache:main Jan 4, 2023

DaanHoogland added a commit that referenced this pull request Jan 4, 2023

Revert "Configurable MTU for VR (#6426)"

b4d51d0

This reverts commit 3044d63.

DaanHoogland mentioned this pull request Jan 4, 2023

Revert "Configurable MTU for VR" #7048

Closed

weizhouapache mentioned this pull request Jan 23, 2023

vpc/network: set mtu of networks/vpcs/nics during 4.18 upgrade #7124

Merged

12 tasks

Uh oh!

Conversation

Pearl1594 commented May 31, 2022 • edited by shwstppr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

acs-robot commented May 31, 2022

Uh oh!

blueorangutan commented May 31, 2022

Uh oh!

blueorangutan commented May 31, 2022

Uh oh!

acs-robot commented Jun 1, 2022

Uh oh!

blueorangutan commented Jun 1, 2022

Uh oh!

blueorangutan commented Jun 1, 2022

Uh oh!

acs-robot commented Jun 1, 2022

Uh oh!

blueorangutan commented Jun 1, 2022

Uh oh!

blueorangutan commented Jun 1, 2022

Uh oh!

DaanHoogland commented Jun 3, 2022

Uh oh!

Pearl1594 commented Jun 3, 2022

Uh oh!

acs-robot commented Jun 9, 2022

Uh oh!

blueorangutan commented Jun 9, 2022

Uh oh!

Pearl1594 commented Jun 9, 2022

Uh oh!

blueorangutan commented Jun 9, 2022

Uh oh!

blueorangutan commented Dec 28, 2022

Uh oh!

blueorangutan commented Dec 28, 2022

Uh oh!

yadvr commented Dec 28, 2022

Uh oh!

shwstppr commented Dec 28, 2022

Uh oh!

blueorangutan commented Dec 28, 2022

Uh oh!

blueorangutan commented Dec 28, 2022

Uh oh!

shwstppr commented Dec 30, 2022

Uh oh!

blueorangutan commented Dec 30, 2022

Uh oh!

sonarqubecloud Bot commented Dec 30, 2022

Uh oh!

blueorangutan commented Dec 30, 2022

Uh oh!

alexandremattioli commented Dec 30, 2022

Uh oh!

DaanHoogland commented Dec 30, 2022

Uh oh!

blueorangutan commented Dec 30, 2022

Uh oh!

blueorangutan commented Dec 31, 2022

Uh oh!

blueorangutan commented Dec 31, 2022

Uh oh!

blueorangutan commented Dec 31, 2022

Uh oh!

DaanHoogland commented Dec 31, 2022

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

NuxRo left a comment

Choose a reason for hiding this comment

Pearl1594 commented May 31, 2022 •

edited by shwstppr

Loading