vpc/network: set mtu of networks/vpcs/nics during 4.18 upgrade

[weizhouapache]

Description

This PR fixes a blocker issue in 4.18/main branch.

Steps to reproduce the issue

• deploy 4.17.2.0 environment
• create VPC and deploy vm
• upgrade to 4.18.0.0 nightly
• restart VPC with cleanup or restart VPC router

error logs

{"com.cloud.agent.api.PlugNicAnswer":{"result":"true","details":"success","wait":"0","bypassHostMaintenance":"false"}},{"com.cloud.agent.api.routing.GroupAnswer":{"results":["null - success: ","null - failed: Traceback (most recent call last):
  File "/opt/cloud/bin/update_config.py", line 144, in <module>
    process_file()
  File "/opt/cloud/bin/update_config.py", line 53, in process_file
    qf.load(None)
  File "/opt/cloud/bin/merge.py", line 309, in load
    updateDataBag(self)
  File "/opt/cloud/bin/merge.py", line 92, in __init__
    self.process()
  File "/opt/cloud/bin/merge.py", line 106, in process
    dbag = self.processGuestNetwork(self.db.getDataBag())
  File "/opt/cloud/bin/merge.py", line 158, in processGuestNetwork
    dp['mtu'] = str(d['mtu'])
KeyError: 'mtu'
"],"result":"false","wait":"0","bypassHostMaintenance":"false"}}] }

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[weizhouapache]

this issue is caused by #6426

The first mysql statement fixes the issue.
However, I do not know if there is other issue caused by the PR, so this PR updates the mtu of vpcs/nics as well.

cc @shwstppr @DaanHoogland

[weizhouapache]

@blueorangutan package

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5377

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[codecov]

Codecov Report

Merging #7124 (d1a4b70) into main (d74f64a) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7124      +/-   ##
============================================
- Coverage     11.78%   11.77%   -0.01%     
+ Complexity     7673     7669       -4     
============================================
  Files          2505     2505              
  Lines        246161   246161              
  Branches      38390    38390              
============================================
- Hits          29003    28995       -8     
- Misses       213385   213394       +9     
+ Partials       3773     3772       -1     

Impacted Files	Coverage Δ
...dstack/network/contrail/model/ModelObjectBase.java	21.15% <0.00%> (-7.70%)	⬇️
...apache/cloudstack/syslog/AlertsSyslogAppender.java	56.49% <0.00%> (-2.26%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[DaanHoogland]

statements look good. I don´t think we can test this othere than using it a lot in environments.

[stephankruggg]

CLGTM

[blueorangutan]

Trillian test result (tid-5965)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46741 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7124-t5965-kvm-centos7.zip
Smoke tests completed. 106 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_scale_kubernetes_cluster	Failure	3631.22	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	575.90	test_kubernetes_clusters.py