Configurable MTU for VR (#6426)

Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Author: Pearl1594

api/src/main/java/com/cloud/agent/api/to/IpAddressTO.java

@@ -39,10 +39,12 @@ public class IpAddressTO {
     private boolean newNic;
     private boolean isPrivateGateway;
     private NicTO nicTO;
+
+    private Integer mtu;
     Map<String, String> details;
 
     public IpAddressTO(long accountId, String ipAddress, boolean add, boolean firstIP, boolean sourceNat, String broadcastUri, String vlanGateway, String vlanNetmask,
-            String vifMacAddress, Integer networkRate, boolean isOneToOneNat) {
+                       String vifMacAddress, Integer networkRate, boolean isOneToOneNat) {
         this.accountId = accountId;
         this.publicIp = ipAddress;
         this.add = add;
@@ -56,6 +58,12 @@ public IpAddressTO(long accountId, String ipAddress, boolean add, boolean firstI
         this.oneToOneNat = isOneToOneNat;
     }
 
+    public IpAddressTO(String ipAddress, Integer mtu, String vlanNetmask ) {
+        this.publicIp = ipAddress;
+        this.mtu = mtu;
+        this.vlanNetmask = vlanNetmask;
+    }
+
     protected IpAddressTO() {
     }
 
@@ -155,6 +163,14 @@ public void setNicTO(NicTO nicTO) {
         this.nicTO = nicTO;
     }
 
+    public Integer getMtu() {
+        return mtu;
+    }
+
+    public void setMtu(Integer mtu) {
+        this.mtu = mtu;
+    }
+
 
     public Map<String, String> getDetails() {
         return details;

api/src/main/java/com/cloud/agent/api/to/NicTO.java

@@ -31,6 +31,7 @@ public class NicTO extends NetworkTO {
     List<String> nicSecIps;
     Map<NetworkOffering.Detail, String> details;
     boolean dpdkEnabled;
+    Integer mtu;
 
     public NicTO() {
         super();
@@ -118,4 +119,12 @@ public boolean isDpdkEnabled() {
     public void setDpdkEnabled(boolean dpdkEnabled) {
         this.dpdkEnabled = dpdkEnabled;
     }
+
+    public Integer getMtu() {
+        return mtu;
+    }
+
+    public void setMtu(Integer mtu) {
+        this.mtu = mtu;
+    }
 }

api/src/main/java/com/cloud/network/Network.java

@@ -493,4 +493,8 @@ public void setIp6Address(String ip6Address) {
     String getIp6Dns2();
 
     Date getCreated();
+
+    Integer getPublicMtu();
+
+    Integer getPrivateMtu();
 }

api/src/main/java/com/cloud/network/NetworkProfile.java

@@ -22,8 +22,10 @@
 import com.cloud.network.Networks.BroadcastDomainType;
 import com.cloud.network.Networks.Mode;
 import com.cloud.network.Networks.TrafficType;
+import org.apache.log4j.Logger;
 
 public class NetworkProfile implements Network {
+    static final Logger s_logger = Logger.getLogger(NetworkProfile.class);
     private final long id;
     private final String uuid;
     private final long dataCenterId;
@@ -357,4 +359,14 @@ public Date getCreated() {
         return null;
     }
 
+    @Override
+    public Integer getPublicMtu() {
+        return null;
+    }
+
+    @Override
+    public Integer getPrivateMtu() {
+        return null;
+    }
+
 }

api/src/main/java/com/cloud/network/NetworkService.java

@@ -34,6 +34,7 @@
 import org.apache.cloudstack.api.command.user.network.UpdateNetworkCmd;
 import org.apache.cloudstack.api.command.user.vm.ListNicsCmd;
 import org.apache.cloudstack.api.response.AcquirePodIpCmdResponse;
+import org.apache.cloudstack.framework.config.ConfigKey;
 
 import com.cloud.exception.ConcurrentOperationException;
 import com.cloud.exception.InsufficientAddressCapacityException;
@@ -59,6 +60,21 @@
  */
 public interface NetworkService {
 
+    public static final Integer DEFAULT_MTU = 1500;
+    public static final Integer MINIMUM_MTU = 68;
+
+    public static final ConfigKey<Integer> VRPublicInterfaceMtu = new ConfigKey<>("VirtualRouter", Integer.class,
+            "vr.public.interface.max.mtu", "1500", "The maximum value the MTU can have on the VR's public interfaces",
+            true, ConfigKey.Scope.Zone);
+
+    public static final ConfigKey<Integer> VRPrivateInterfaceMtu = new ConfigKey<>("VirtualRouter", Integer.class,
+            "vr.private.interface.max.mtu", "1500", "The maximum value the MTU can have on the VR's private interfaces",
+            true, ConfigKey.Scope.Zone);
+
+    public static final ConfigKey<Boolean> AllowUsersToSpecifyVRMtu = new ConfigKey<>("Advanced", Boolean.class,
+            "allow.end.users.to.specify.vr.mtu", "false", "Allow end users to specify VR MTU",
+            true, ConfigKey.Scope.Zone);
+
     List<? extends Network> getIsolatedNetworksOwnedByAccountInZone(long zoneId, Account owner);
 
     IpAddress allocateIP(Account ipOwner, long zoneId, Long networkId, Boolean displayIp, String ipaddress) throws ResourceAllocationException, InsufficientAddressCapacityException,

api/src/main/java/com/cloud/network/vpc/Vpc.java

@@ -96,6 +96,8 @@ public enum State {
 
     Date getCreated();
 
+    Integer getPublicMtu();
+
     String getIp4Dns1();
 
     String getIp4Dns2();

api/src/main/java/com/cloud/network/vpc/VpcService.java

@@ -53,7 +53,7 @@ public interface VpcService {
      * @throws ResourceAllocationException TODO
      */
     public Vpc createVpc(long zoneId, long vpcOffId, long vpcOwnerId, String vpcName, String displayText, String cidr, String networkDomain,
-                         String dns1, String dns2, String ip6Dns1, String ip6Dns2, Boolean displayVpc)
+                         String dns1, String dns2, String ip6Dns1, String ip6Dns2, Boolean displayVpc, Integer publicMtu)
             throws ResourceAllocationException;
 
     /**
@@ -73,11 +73,12 @@ public Vpc createVpc(long zoneId, long vpcOffId, long vpcOwnerId, String vpcName
      * @param vpcId
      * @param vpcName
      * @param displayText
-     * @param customId TODO
-     * @param displayVpc TODO
+     * @param customId    TODO
+     * @param displayVpc  TODO
+     * @param mtu
      * @return
      */
-    public Vpc updateVpc(long vpcId, String vpcName, String displayText, String customId, Boolean displayVpc);
+    public Vpc updateVpc(long vpcId, String vpcName, String displayText, String customId, Boolean displayVpc, Integer mtu);
 
     /**
      * Lists VPC(s) based on the parameters passed to the method call

api/src/main/java/com/cloud/vm/Nic.java

@@ -160,4 +160,6 @@ public enum ReservationStrategy {
     String getIPv6Cidr();
 
     String getIPv6Address();
+
+    Integer getMtu();
 }

api/src/main/java/com/cloud/vm/NicProfile.java

@@ -70,6 +70,7 @@ public class NicProfile implements InternalIdentity, Serializable {
     String iPv6Dns1;
     String iPv6Dns2;
     String requestedIPv6;
+    Integer mtu;
 
     //
     // CONSTRUCTORS
@@ -396,6 +397,15 @@ public void setOrderIndex(Integer orderIndex) {
         this.orderIndex = orderIndex;
     }
 
+    public Integer getMtu() {
+        return mtu;
+    }
+
+    public void setMtu(Integer mtu) {
+        this.mtu = mtu;
+    }
+
+
     //
     // OTHER METHODS
     //
@@ -426,6 +436,7 @@ public void deallocate() {
         isolationUri = null;
 
         orderIndex = null;
+        mtu = null;
 
     }
 

api/src/main/java/org/apache/cloudstack/alert/AlertService.java

@@ -71,6 +71,8 @@ private AlertType(short type, String name, boolean isDefault) {
         public static final AlertType ALERT_TYPE_HA_ACTION = new AlertType((short)30, "ALERT.HA.ACTION", true);
         public static final AlertType ALERT_TYPE_CA_CERT = new AlertType((short)31, "ALERT.CA.CERT", true);
         public static final AlertType ALERT_TYPE_VM_SNAPSHOT = new AlertType((short)32, "ALERT.VM.SNAPSHOT", true);
+        public static final AlertType ALERT_TYPE_VR_PUBLIC_IFACE_MTU = new AlertType((short)32, "ALERT.VR.PUBLIC.IFACE.MTU", true);
+        public static final AlertType ALERT_TYPE_VR_PRIVATE_IFACE_MTU = new AlertType((short)32, "ALERT.VR.PRIVATE.IFACE.MTU", true);
 
         public short getType() {
             return type;