add support to update interface mtu

Author: Pearl1594

api/src/main/java/com/cloud/agent/api/to/IpAddressTO.java

@@ -58,6 +58,12 @@ public IpAddressTO(long accountId, String ipAddress, boolean add, boolean firstI
         this.oneToOneNat = isOneToOneNat;
     }
 
+    public IpAddressTO(String ipAddress, Integer mtu, String vlanNetmask ) {
+        this.publicIp = ipAddress;
+        this.mtu = mtu;
+        this.vlanNetmask = vlanNetmask;
+    }
+
     protected IpAddressTO() {
     }
 

api/src/main/java/com/cloud/network/element/NetworkElement.java

@@ -137,4 +137,8 @@ boolean shutdownProviderInstances(PhysicalNetworkServiceProvider provider, Reser
      * @return true/false
      */
     boolean verifyServicesCombination(Set<Service> services);
+
+//    default boolean update(Network network) throws ResourceUnavailableException {
+//        return true;
+//    }
 }

api/src/main/java/org/apache/cloudstack/api/ApiConstants.java

@@ -912,6 +912,7 @@ public class ApiConstants {
     public static final String PUBLIC_MTU = "publicmtu";
     public static final String PRIVATE_MTU = "privatemtu";
 
+    public static final Integer DEFAULT_MTU = 1500;
     public enum BootType {
         UEFI, BIOS;
 

api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java

@@ -335,15 +335,15 @@ public Long getAclId() {
     }
 
     public Integer getPublicMtu() {
-        return publicMtu != null ? publicMtu : 0;
+        return publicMtu != null ? publicMtu : ApiConstants.DEFAULT_MTU;
     }
 
     public void setPublicMtu(Integer publicMtu) {
         this.publicMtu = publicMtu;
     }
 
     public Integer getPrivateMtu() {
-        return privateMtu != null ? privateMtu : 0;
+        return privateMtu != null ? privateMtu : ApiConstants.DEFAULT_MTU;
     }
 
     public void setPrivateMtu(Integer privateMtu) {

core/src/main/java/com/cloud/agent/api/SetupGuestNetworkCommand.java

@@ -36,8 +36,6 @@ public class SetupGuestNetworkCommand extends NetworkElementCommand {
     String routerIpv6Gateway = null;
     String routerIpv6Cidr = null;
 
-    Integer mtu = null;
-
     public NicTO getNic() {
         return nic;
     }
@@ -116,12 +114,4 @@ public void setDefaultIp6Dns1(String defaultIp6Dns1) {
     public void setDefaultIp6Dns2(String defaultIp6Dns2) {
         this.defaultIp6Dns2 = defaultIp6Dns2;
     }
-
-    public Integer getMtu() {
-        return mtu;
-    }
-
-    public void setMtu(Integer mtu) {
-        this.mtu = mtu;
-    }
 }

core/src/main/java/com/cloud/agent/api/routing/UpdateNetworkCommand.java

@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.agent.api.routing;
+
+import com.cloud.agent.api.to.IpAddressTO;
+import com.cloud.hypervisor.Hypervisor;
+
+public class UpdateNetworkCommand extends NetworkElementCommand{
+    IpAddressTO[] ipAddresses;
+
+    Hypervisor.HypervisorType hypervisorType;
+
+    public UpdateNetworkCommand(IpAddressTO[] ips) {
+        this.ipAddresses = ips;
+    }
+
+    @Override
+    public boolean executeInSequence() {
+        return false;
+    }
+
+    public IpAddressTO[] getIpAddresses() {
+        return ipAddresses;
+    }
+
+    @Override
+    public int getAnswersCount() {
+        return ipAddresses.length;
+    }
+
+    public Hypervisor.HypervisorType getHypervisorType() {
+        return hypervisorType;
+    }
+
+    public void setHypervisorType(Hypervisor.HypervisorType hypervisorType) {
+        this.hypervisorType = hypervisorType;
+    }
+}

core/src/main/java/com/cloud/agent/resource/virtualnetwork/VRScripts.java

@@ -78,5 +78,7 @@ public class VRScripts {
     public static final String RETRIEVE_DIAGNOSTICS = "get_diagnostics_files.py";
     public static final String VR_FILE_CLEANUP = "cleanup.sh";
 
+    public static final String VR_UPDATE_MTU = "update_interface_config.sh";
+
     public static final String ROUTER_FILESYSTEM_WRITABLE_CHECK = "filesystem_writable_check.py";
 }

core/src/main/java/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java

@@ -34,6 +34,8 @@
 
 import javax.naming.ConfigurationException;
 
+import com.cloud.agent.api.routing.UpdateNetworkCommand;
+import com.cloud.agent.api.to.IpAddressTO;
 import com.cloud.utils.PasswordGenerator;
 import org.apache.cloudstack.ca.SetupCertificateAnswer;
 import org.apache.cloudstack.ca.SetupCertificateCommand;
@@ -134,6 +136,10 @@ public Answer executeRequest(final NetworkElementCommand cmd) {
                 return execute((AggregationControlCommand)cmd);
             }
 
+            if (cmd instanceof UpdateNetworkCommand) {
+                return execute((UpdateNetworkCommand) cmd);
+            }
+
             if (_vrAggregateCommandsSet.containsKey(routerName)) {
                 _vrAggregateCommandsSet.get(routerName).add(cmd);
                 aggregated = true;
@@ -216,6 +222,44 @@ private Answer executeQueryCommand(NetworkElementCommand cmd) {
         }
     }
 
+    private static String getRouterSshControlIp(NetworkElementCommand cmd) {
+        String routerIp = cmd.getAccessDetail(NetworkElementCommand.ROUTER_IP);
+        if (s_logger.isDebugEnabled())
+            s_logger.debug("Use router's private IP for SSH control. IP : " + routerIp);
+        return routerIp;
+    }
+
+    private Answer execute(UpdateNetworkCommand cmd) {
+        IpAddressTO[] ipAddresses = cmd.getIpAddresses();
+        String routerIp = getRouterSshControlIp(cmd);
+        boolean finalResult = true;
+        for (IpAddressTO ipAddressTO : ipAddresses) {
+            try {
+                ExecutionResult result = _vrDeployer.executeInVR(routerIp, VRScripts.VR_UPDATE_MTU,
+                        ipAddressTO.getPublicIp() + " " + ipAddressTO.getVlanNetmask() + " " + ipAddressTO.getMtu() + " " + 15);
+                if (s_logger.isDebugEnabled())
+                    s_logger.debug("result: " + result.isSuccess() + ", output: " + result.getDetails());
+                if (!result.isSuccess()) {
+                    s_logger.warn(String.format("Failed to update interface mtu to %s on interface with ip: %s",
+                            ipAddressTO.getMtu(), ipAddressTO.getPublicIp()));
+                    finalResult = false;
+                    continue;
+                }
+                s_logger.info(String.format("Successfully updated mtu to %s on interface with ip: %s",
+                        ipAddressTO.getMtu(), ipAddressTO.getPublicIp()));
+                finalResult &= true;
+            } catch (Exception e) {
+                String msg = "Prepare UpdateNetwork failed due to " + e.toString();
+                s_logger.error(msg, e);
+                return new Answer(cmd, e);
+            }
+        }
+        if (finalResult) {
+            return new Answer(cmd, true, null);
+        }
+        return new Answer(cmd, new CloudRuntimeException("Failed to update interface mtu"));
+    }
+
     private ExecutionResult applyConfigToVR(String routerAccessIp, ConfigItem c) {
         return applyConfigToVR(routerAccessIp, c, VRScripts.VR_SCRIPT_EXEC_TIMEOUT);
     }

core/src/main/java/com/cloud/agent/resource/virtualnetwork/model/IpAddress.java

@@ -35,7 +35,6 @@ public class IpAddress {
     private boolean isPrivateGateway;
 
     private  Integer mtu;
-
     public IpAddress() {
         // Empty constructor for (de)serialization
     }

engine/schema/src/main/java/com/cloud/network/dao/IPAddressDao.java

@@ -94,4 +94,6 @@ public interface IPAddressDao extends GenericDao<IPAddressVO, Long> {
     IPAddressVO findByVmIdAndNetworkId(long networkId, long vmId);
 
     IPAddressVO findByAccountIdAndZoneIdAndStateAndIpAddress(long accountId, long dcId, State state, String ipAddress);
+
+    List<IPAddressVO> listByNetworkId(long networkId);
 }