Skip to content

fix(reporter): sort log tabs alphabetically instead of by creation time - #59

Merged
BenjaminAmos merged 1 commit into
masterfrom
soloturn-alphabetical-log-tabs
Aug 22, 2026
Merged

fix(reporter): sort log tabs alphabetically instead of by creation time#59
BenjaminAmos merged 1 commit into
masterfrom
soloturn-alphabetical-log-tabs

Conversation

@soloturn

Copy link
Copy Markdown
Contributor

AI-assisted change proposal. Filed by agent driven by @soloturn via GDD.

Summary

  • sortLogFiles() sorted by file creation time, reversed (newest first). With two log files from one session (Terasology-init.log, Terasology-menu.log) that reads as arbitrary - neither the order they were written in nor the order their names suggest - rather than a deliberate choice, per the original issue's own framing. Sorting by filename instead is deterministic and, for Terasology's own log naming, happens to match session order too.
  • Also carries the GlobalProperties NPE guard from fix(reporter): include every log file in the PasteBin upload #56 - needed just to construct GlobalProperties() at all in cr-core's own test classpath, same reasoning as there. Will collapse to a no-op merge once fix(reporter): include every log file in the PasteBin upload #56 lands first, since it's the identical diff.

First item from #53 (1 of 5); items 2 and 3 are #56 and #58.

Test plan

  • New ErrorMessagePanelTabOrderTest - writes two log files out of alphabetical order with a real gap between creation times, asserts the resulting tab order is alphabetical regardless.
  • ./gradlew build - clean.

Related

sortLogFiles() sorted by file creation time, reversed (newest first).
With two log files from one session (Terasology-init.log,
Terasology-menu.log) that reads as arbitrary - neither the order they
were written in nor the order their names suggest - rather than a
deliberate choice. Sorting by filename instead is deterministic and,
for Terasology's own log naming, happens to match session order too.

Also carries the GlobalProperties NPE guard from #56 (needed to
construct GlobalProperties() at all in cr-core's own test classpath,
same as there - see that PR for the full explanation). Will collapse
to a no-op merge once #56 lands first.

First item from #53 (1 of 5); items 2 and 3 are #56 and #58.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6c3ae4a1-d840-4ecc-b8fa-c53859abfe23


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BenjaminAmos
BenjaminAmos merged commit 92e0475 into master Aug 22, 2026
7 checks passed
@BenjaminAmos
BenjaminAmos deleted the soloturn-alphabetical-log-tabs branch August 22, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants