fix(reporter): remove the "Go to Forum" button and link - #60
Closed
soloturn wants to merge 1 commit into
Closed
Conversation
SUPPORT_FORUM_LINK pointed at a dead URL - confirmed via a direct request, the domain resolves but returns HTTP 500 - and cr-destsol's own forum sub-board is presumably in the same state. Rather than fix a link to a forum that no longer exists in a supportable form, remove the button entirely, per the issue's own acceptance criteria. Removed everywhere the button touched: the button and its action listener in FinalActionsPanel, SUPPORT_FORUM_LINK/RES_FORUM_ICON from both cr-terasology's and cr-destsol's crashreporter.properties and GlobalProperties.KEY, the forum icon resource, and the gotoForum i18n key from all 9 message bundles (base + de/es/fr/gl/it/ja/pl/pt/tr). Fourth item from #53 (item 5 of 5, forum link - Discord invite remains open); items 1-3 are #59, #56, #58. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 22, 2026
This was referenced Aug 22, 2026
Contributor
|
Before this is either merged or closed, I think a conclusion needs to be reached about if the forum is intended to be permanently unavailable or just offline for an extended period. |
4 tasks
Contributor
Author
|
no conclusion in discord. so close it to not distract. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SUPPORT_FORUM_LINKpointed at a dead URL - confirmed via a direct request, the domain resolves but returnsHTTP 500, andcr-destsol's own forum sub-board is presumably in the same state. Rather than fix a link to a forum that no longer exists in a supportable form, removes the button entirely - per the issue's own acceptance criteria ("or the button/link is removed if the forum no longer exists in a supportable form").Removed everywhere the button touched:
FinalActionsPanel.SUPPORT_FORUM_LINK/RES_FORUM_ICONfromGlobalProperties.KEY, and bothcr-terasology's andcr-destsol'scrashreporter.properties.gotoForumi18n key from all 9 message bundles (base + de/es/fr/gl/it/ja/pl/pt/tr).Fifth item from #53 (item 5 of 5, forum link - the Discord invite is the only one remaining); items 1-3 are #59, #56, #58.
Test plan
./gradlew build- clean, no lingering references anywhere in the tree.Related