fix(reporter): degrade to the placeholder image when a resource property is unset

[soloturn]

AI-assisted change proposal. Filed by agent driven by @soloturn via GDD.

Summary

Resources.loadImage(fname) built "/" + fname and looked that up regardless of whether fname was null, so a missing property produced the literal path "/null" - Resources.class.getResource("/null") returns null, and the method threw FileNotFoundException("/null") instead of falling back to its own placeholder image the way it already does for a genuinely-missing-but-named resource.

RES_BANNER_IMAGE/RES_SERVER_ICON only exist in a downstream consumer's crashreporter.properties (cr-terasology, cr-destsol, ...), not cr-core's own crashreporter_defaults.properties - so GlobalProperties.get() returning null for those keys is an expected, not exceptional, case whenever cr-core runs standalone. Confirmed while testing runInteractiveTest: this is exactly what crashed RootPanel's banner image lookup and stopped the reporter dialog from ever rendering when run outside a downstream consumer.

Test plan

• ./gradlew build - clean.

Related

• Found while getting runInteractiveTest to actually render end to end for fix(reporter): include every log file in the PasteBin upload #56/fix(reporter): pre-fill the GitHub issue form with a crash summary #58/fix(reporter): sort log tabs alphabetically instead of by creation time #59/fix(reporter): remove the "Go to Forum" button and link #60 manual testing.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4d9047a6-bf44-4470-9a21-fd315a914964

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}