Skip to content

fix(reporter): degrade to the placeholder image when a resource property is unset #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenjaminAmos merged 2 commits into from
Aug 22, 2026
+6 −1
Merged

fix(reporter): degrade to the placeholder image when a resource property is unset #63

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49112b2
fix(reporter): degrade to the placeholder image when a resource prope…
soloturn Aug 22, 2026
d92bf2c
style: clarify comment in Resources.java
BenjaminAmos Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cr-core/src/main/java/org/terasology/crashreporter/Resources.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,15 @@ private Resources() {
}

/**
* @param fname the absolute path in the jar/project
* @param fname the absolute path in the jar/project, or {@code null} if the property naming it
* was never set
* @return the buffered image, wrapped in an Icon
*/
public static BufferedImage loadImage(String fname) {
if (fname == null) {
System.err.println("No resource path given (missing property?) - using placeholder image");
return createDummyImage(64, 64, "?");
}
try {
String fullPath = "/" + fname;
URL rsc = Resources.class.getResource(fullPath);
Expand Down