fix(reporter): PasteBin upload - timeout, missing Jackson dep, silent failures

[soloturn]

AI-assisted change proposal. Filed by agent driven by @soloturn via GDD.

Combines #64 and #65 - both PasteBin-upload fixes found while manually testing the reporter dialog, closing both in favor of this one.

Summary

1. Upload hung forever with no feedback

PastebinUploadRunnable makes a real HTTP call with no timeout of its own. upload() now submits to a daemon-thread executor and waits up to 30s (awaitUpload(), a plain Swing-free method so the timeout/exception-unwrapping logic is directly testable) before treating it as failed, instead of leaving the button disabled and the status label reading "please wait" forever with no way to tell "still working" from "will never finish".

2. NoClassDefFoundError: com/fasterxml/jackson/core/type/TypeReference

Reproduced directly by calling PastebinUploadRunnable.call() outside the dialog. jpastebin's own embedded META-INF/maven/org/jpastebin/pom.xml (inside the jar) pins jackson-databind/jackson-core/jackson-annotations 2.9.7, but the POM Gradle actually resolves for org:jpastebin:1.0.1 from the JBoss repo is an empty Nexus-generated stub with no <dependencies> at all - so Gradle never pulled Jackson in, and it only ever surfaced the moment someone clicked the button.

Declared all three explicitly via the jackson-bom platform rather than three separately-pinned versions: jackson-annotations renumbered its own versioning away from core/databind's x.y.z scheme starting at 2.20, so hand-pinning all three to the same version string breaks depending which release line you pick. 2.9.7 is a 2018 release with known CVEs; Jackson's 2.x line keeps this level of API stable, so the current release is a safe drop-in.

3. Upload failures only ever showed a JOptionPane, with no trace anywhere else

Which is exactly what made bug #2 hard to pin down in the first place - the exception only ever appeared as a popup, gone the moment it's dismissed, with nothing printed anywhere for whoever launched the process (a script, a supervisor, a developer tailing output) to find afterward. uploadFailed() now unconditionally prints the exception to stderr before showing the dialog - the same fix applied to the timeout case above, since both funnel through the same failure path.

Test plan

• New UploadPanelTest - drives the timeout path directly via the injectable timeout constructor and awaitUpload().
• New UploadPanelFailureLoggingTest - drives a forced upload failure via a package-private test hook and asserts the exception lands on stderr.
• Reproduced the Jackson error directly against the real API before the fix, confirmed a successful real upload after.
• ./gradlew build - clean.

Related

• Found while manually testing fix(reporter): include every log file in the PasteBin upload #56/fix(reporter): pre-fill the GitHub issue form with a crash summary #58/fix(reporter): sort log tabs alphabetically instead of by creation time #59/fix(reporter): remove the "Go to Forum" button and link #60/build: seed runInteractiveTest with real log fixtures automatically #61/build: bump mockito-core to 5.23.0 for JDK 26 support #62/fix(reporter): degrade to the placeholder image when a resource property is unset #63/fix(reporter): Discord/GitHub-issue/forum buttons silently did nothing #66/fix(reporter): list exceptions from every log tab in the issue body #67 together via merge-train.
• Replaces fix(reporter): time out a PasteBin upload instead of hanging forever #64 and fix(reporter): fix PasteBin upload (missing Jackson dep) and always log upload failures #65.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 21d2efac-7cb7-44a2-a2b0-8c603a95bb72

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[soloturn]

Re: @BenjaminAmos's comment on #64 (now here) about tests reaching out to external URLs - clarifying, since that PR's gone: neither UploadPanelTest nor UploadPanelFailureLoggingTest ever touches the network.

• new URL("https://pastebin.com/...") only parses a URL string - it never opens a connection (that only happens on openConnection()/openStream(), which these tests never call).
• Every simulated upload is a hand-written Callable<URL> (sleep-then-return, return-immediately, or throw) passed straight to UploadPanel.awaitUpload()/uploadForTesting(). PastebinUploadRunnable - the class that actually makes the real HTTP POST - is never instantiated by any test here.

So these are already fully offline and deterministic; nothing to change on that front. Happy to add an explicit comment in the test file noting this if it'd help future reviewers.