Skip to content

docs(research): non-goals reassessment + cohort positioning + ship sequence (2026-05)#58

Merged
SutuSebastian merged 20 commits intomainfrom
docs/non-goals-reassessment
May 4, 2026
Merged

docs(research): non-goals reassessment + cohort positioning + ship sequence (2026-05)#58
SutuSebastian merged 20 commits intomainfrom
docs/non-goals-reassessment

Conversation

@SutuSebastian
Copy link
Copy Markdown
Contributor

@SutuSebastian SutuSebastian commented May 4, 2026

Summary

Research note proposing a reassessment of roadmap.md § Non-goals (v1) under the "extract maximum value from the SQL-index architecture; grow the ecosystem" mission. Capability inventory + non-goal flips + ship sequence + open-question resolutions, all grounded in re-runnable file path / codemap query / rg references.

Companion to existing research

Headline findings

  • §1 — 10 first-class agent-facing capabilities sitting in unwritten JOINs / formatters / verbs (components-touching-deprecated, unimported-exports, complexity per symbol, refactor-risk-ranking, boundary violations Shape A, unused type members advisory, Mermaid output with bounded-input contract, MCP file/symbol resources with disambiguation envelope, local recipe-recency tracking, rename-preview as recipe).
  • §2 — Five non-goals reframed via moat taxonomy: FTS5 + Mermaid extend moat B; output formatters align with moat A; LSP shim is moat-orthogonal transport; daemon + static-analysis flips reframed via the moats.
  • §3 — Two load-bearing moats declared and defended:
    • A. SQL is the API — predicate-as-API; verdicts are output mode, never primitives.
    • B. Extracted structure ≥ verdicts — schema breadth (CSS, markers, type_members, calls.caller_scope, components.hooks_used) is the substrate every recipe layers on.
    • Plus 6 ergonomic / safety floor rows including new "No telemetry upload" floor (resists accumulation pressure).
  • §4 — Open-spec inspection list for plan-PR authoring (LSP spec, SQLite docs, oxc, Lightning CSS, JSON-RPC + MCP, TC39, existing codemap surface).
  • §5 — Ship sequence with parallel plan-PR: shipping cadence (a) FTS5 + Mermaid → (c) complexity column → (b) C.9 plugin impl → (d) LSP shim. Plan track: (b) plan PR opens at T+0 in parallel with (a) shipping (pre-locked decisions cut cold-start; resists deferral-trap).
  • §6 — All 5 open questions resolved (Q1 daemon-default = ON for mcp/serve; Q2 FTS5 default = OFF, both config + CLI; Q3 LSP = thin shim only; Q4 plugin scope = entry-point hints only; Q5 history table = deferred with revisit triggers).

Cohort positioning (corrected mid-session)

Initial draft claimed codemap was "the only SQL-based code index in the market." Web-search fact-check surfaced a real cohort: srclight, Sverklo, ctxpp, KotaDB, codemogger, @squirrelsoft/code-index, QuickAST, etc. — all SQLite-backed code indexers for AI agents.

Corrected positioning anchors on three differentiation axes:

  1. Predicate-as-API — raw SQL + recipes as primary surface (peers ship pre-baked verbs / MCP tools).
  2. Pure structural — no embeddings, no LLM in box (peers add semantic search by default).
  3. JS/TS/CSS-ecosystem-deep extraction — CSS variables/classes/keyframes, React components.hooks_used, type_members, markers. Structurally enabled by parser choice (oxc + lightningcss are Rust-based and ecosystem-specialized vs tree-sitter's multi-language breadth).

Doc-governance compliance

  • Lives in docs/research/ per Rule 3 (research-class doc).
  • Cross-references roadmap, why-codemap, competitive-scan per Rule 5.
  • Doesn't duplicate non-goals (Rule 1) — proposes amendments to be applied when § 2 items ship, in lockstep with why-codemap.md per the Single source of truth table.
  • No inventory counts in narrative (Rule 6) — qualitative descriptors only.
  • All concrete claims grounded in re-runnable references (file paths, codemap query, rg invocations) per the new lesson in .agents/lessons.md.

Grill session outcomes (this PR — 15 commits)

Each grill round shipped one structural improvement to the doc as a separate commit:

Commit Change
2803d9d § 5 (c) effort fix (CodeRabbit catch — S → M for AST walker)
c3ed3e9 § 3 split into moats A/B + ergonomic floors
6f845ba § 5 parallel plan-PR for (b) at T+0; T-table added
0b9d878 § 2 reframed via moat taxonomy
96f6c4e § 1.7 Mermaid bounded-input contract
2933cf0 § 1.10 rename → recipe-shape + parametrised recipes infra
a636eb0 § 6 Q1/Q3/Q4 closed
1526d30 § 6 Q2 (FTS5 default) closed
7f78d9b § 6 Q5 (history table) closed with full analysis
67ed2d8 § 1.9 reframe + § 3 "No telemetry upload" floor
efc1ebf Fallow framing dropped throughout
537cbb4 Honest cohort positioning (post fact-check)
a5b75df § 1.4 refactor-risk formula (orphan + NULL fixes + caveat)
983c67f § 1.5 boundary violations — Shape A directional rules
5bdd0ca § 1.1, 1.6, 1.8 sanity sharpening (gotchas + envelopes)

Test plan

  • bun run format:check passes on every commit
  • All commits go through pre-commit hook (lint-staged); no --no-verify used
  • Anchor preservation verified (#resolved-2026-05 cited from § 2.1, § 2.4 verdicts)
  • Zero [Ff]allow mentions remain in the file (grep verified)
  • CodeRabbit Q1 (effort estimate inconsistency at line 167) resolved + thread closed
  • CodeRabbit re-review pass on the reshape (rate-limit refilled; will trigger on next push)

Follow-up PRs (out of scope for #58)

  1. docs/research/fallow.md — apply existence test under new positioning; likely Tier B slim or Tier C delete-and-lift via docs-lifecycle-sweep skill.
  2. docs/roadmap.md § Non-goals — lockstep update per docs/README.md Rule 10: the "(e.g. fallow, knip, jscpd)" parenthetical needs the same fallow-decoupling treatment.
  3. Tier-2 rule for plan-PR inspiration discipline — auto-attached to docs/plans/** + templates/recipes/**; primes plan-authoring with § 4's open-spec inspection list.

Discussion-ready

§ 6 is now all-resolved with revisit triggers. § 5 ship sequence is concrete (T-table). The doc's job — pin decisions before any plan PR — is done. Ready to merge after the CodeRabbit re-review settles.

…2026-05)

Companion to research/fallow.md (capability tracker — what to adopt FROM
fallow). This new doc inventories what THIS codebase already unlocks
that the current Non-goals (v1) list forbids, post-C.11.

User observation: many non-goals were defensive choices made when the
project was 1/10th its current size, then carried forward unchallenged
as the surface grew (15+ recipes, 12+ tables, 3 engines, watch mode,
coverage, audit, impact). The reframe: stop asking "what should we not
do?" and start asking "what does the SQL-index-with-three-transports
actually unlock that no other tool does?"

Findings:

§1 — 10 first-class agent capabilities sitting in unwritten JOINs /
formatters / verbs (components-touching-deprecated, unimported-exports,
complexity per symbol, refactor-risk-ranking, boundary violations,
unused type members, Mermaid output, MCP file/symbol resources, recipe
usage telemetry, rename --dry-run preview).

§2 — Five non-goals worth challenging:
- "No FTS5 / use ripgrep" — SQLite ships FTS5; ripgrep loses JOIN
  composition (TODOs inside @deprecated functions in <50% covered files
  is one query, vs three tools today).
- "No visualisation" — conflates rendering pixels with shaping render-
  ready data; Mermaid / D2 are JSON-shaped formatters (sibling of SARIF).
- "No static analysis" — we already ship deprecated-symbols, untested-
  and-dead, barrel-files, fan-in/out; the line was rhetorical. Real
  boundary is "no opinionated rule engine, no fix mutation".
- "No persistent daemon" — we have one (mcp --watch, serve --watch,
  watch); non-goal preserves a constraint that no longer exists.
- "No LSP replacement" — show + impact + watch is 80% of LSP read-side;
  ship a thin shim consuming existing engines, don't write an LSP.

§3 — Real architectural limits worth keeping (sub-100ms cold-start CLI,
no LLM in box, no fix engine, no runtime tracing, no JS exec at index
time).

§4 — Map of /Users/sutusebastian/Developer/OSS/fallow clone deep-dive
points: which crates / docs / configs to inspect before each shipped
feature so we adopt patterns rather than reinvent. Cite-the-source-path
discipline mirrors the existing research/fallow.md cite-the-PR habit.

§5 — Recommended sequence: (a) FTS5 + Mermaid one-PR non-goal flip →
(c) complexity column → (b) C.9 plugin layer (multi-tracer big surface)
→ (d) LSP shim. (a) is the cheapest non-goal flip; ships a confidence
move before the bigger surfaces.

§6 — 5 open questions (daemon-by-default for MCP/HTTP, FTS5 opt-in,
LSP shim vs standalone, plugin contract scope, history table shape).

Doc-governance compliance:
- Goes in docs/research/ per Rule 3 (research-class doc).
- Cross-references roadmap, why-codemap, fallow.md, competitive-scan
  per Rule 5.
- Doesn't duplicate non-goals (Rule 1) — proposes amendments to be
  applied when § 2 items ship, in lockstep with why-codemap per the
  Single source of truth table.
- No inventory counts in narrative (Rule 6) — uses qualitative "15+
  recipes / 12+ tables" only.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 4, 2026

⚠️ No Changeset found

Latest commit: 5bdd0ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

📝 Walkthrough

Walkthrough

Adds two documentation updates: new agent guidance bullets forbidding absolute local user paths in tracked content and requiring prescriptive research notes to pin every concrete claim with re-runnable references; and a comprehensive non-goals reassessment doc that inventories shipable capabilities, proposes non-goal flips, records architectural limits, and recommends a ship sequence.

Changes

Agent Guidance Rules

Layer / File(s) Summary
Guidance Restrictions
.agents/lessons.md
Two new lesson bullets added: (1) prohibit committing absolute local user paths or file:/// URIs in tracked files/docs/PRs, (2) require prescriptive research/plan notes to pin every concrete claim with re-runnable references (e.g., file:line, codemap queries, rg, --recipes-json).

Non-Goals Reassessment

Layer / File(s) Summary
Document Entry & Framing
docs/research/non-goals-reassessment-2026-05.md (lines 1–12)
Adds entry point, status/trigger, prescriptive lens and grounding policy, links to companion research, and notes errata/triangulation section.
Capability Inventory
docs/research/non-goals-reassessment-2026-05.md (lines 15–55)
Introduces an "already shippable today" capability table describing current DB substrate, exposure needs, and effort for listed capabilities.
Non-Goals Flip Proposals
docs/research/non-goals-reassessment-2026-05.md (lines 57–134)
Proposes five candidate non-goal flips (FTS5 opt-in, shape-only visualization, in-scope static analysis via predicate-as-API, daemon opt-in choices, LSP shim vs engine) with verdict-style ship implications and constraints.
Architectural Constraints
docs/research/non-goals-reassessment-2026-05.md (lines 137–157)
Documents "true architectural limits" and ergonomic/safety floors (e.g., SQL-as-API, no JS at index time, no runtime tracing, no fix/rule engine, sub-100ms CLI cold-start floor).
Inspection Checklist & Ship Sequence
docs/research/non-goals-reassessment-2026-05.md (lines 160–181, 184–212)
Adds a checklist of fallow source areas mapped to codemap relevance and a recommended ordered ship cadence with parallel plugin-layer planning and per-item effort notes.
Open Questions, Cross-refs & Errata
docs/research/non-goals-reassessment-2026-05.md (lines 214–251)
Lists resolved vs open questions (daemon defaults, FTS5 default/opt-in, history table), collects cross-references to schema/roadmap, and adds a triangulation errata section correcting three prior claims with re-runnable evidence.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

documentation

"I hopped through lines and footnotes bright,
Pinning claims by lantern light.
No stray /Users on my trail,
Research trails that never fail—
Hooray for docs that guide the flight!"

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding a research document reassessing non-goals and planning ship sequence. It is specific, concise, and clearly conveys the primary contribution.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/non-goals-reassessment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…eline

User cross-checked my prescriptive doc (non-goals-reassessment-2026-05.md)
against composer-2-fast's descriptive baseline (codemap-capability-
surface-2026-05.md) plus the codebase as source of truth. Found three
factual errors in mine; baseline doc held up clean.

Corrections applied:

1. § 1.2 (Exports never imported): codebase has `exports.re_export_source`
   column — original doc missed it. Re-exports require a JOIN through
   that column to avoid false positives on barrel-only exports. Effort
   bumped XS → S.

2. § 1.3 (Cyclomatic complexity): claimed "AST walker already counts
   nodes during parse" — false. `rg 'complexity|node_count|nodeCount'
   src/` returns zero matches. Node-counting is NOT in place; needs an
   extension to the AST walker in src/parser.ts. Effort bumped S → M.

3. § 2.3 ("no static analysis" non-goal): listed `fan-in` and `fan-out`
   as "static analysis we already ship" — too loose. Per `fan-in.sql`
   (`ORDER BY fan_in DESC LIMIT 15`) they're hotspot rankers, not
   orphan / dead-code detectors. They don't cover the closed-dead-
   subgraph case from research/fallow.md § 0 (8-file pack with non-
   zero fan-in via self-import). That gap motivates C.9 framework
   plugin layer, not the "no static analysis" flip. Caveat now spelled
   out in the doc.

Header updated: this doc is the **prescriptive** lens; the **descriptive
baseline** lives in codemap-capability-surface-2026-05.md (read first).
Cross-references list and § 8 errata block document the diff between v1
and v2 so future reviewers can see what changed and why.

Process lesson encoded in § 8: every prescriptive research note should
triangulate against a descriptive baseline (own doc or peer model) before
recommending a ship sequence. Caught all three errors before they
propagated into a plan PR.
User caught absolute-path leaks in the research note pointing at the
fallow clone on the maintainer's machine. Three references replaced with
the public upstream URL (https://github.com/fallow-rs/fallow):

- Header "Local clone for deep-dives" → "Source for deep-dives"
- § 4 heading "What to inspect in the local fallow clone" → "...in the
  fallow source tree"
- § 7 cross-references "Local fallow clone — /Users/..." → "fallow
  upstream"

Also adds a new general-purpose lesson to .agents/lessons.md:

  Never commit absolute local user paths — no /Users/<name>/…,
  /home/<name>/…, ~/…, or file:/// URIs in any tracked doc, code,
  comment, or PR body. Pattern: cite https://github.com/<org>/<repo>
  for upstream sources; repo-relative paths for in-tree references.

Sibling to the existing "PR bodies via temp file" lesson — same family
(committed strings need to be portable + non-leaking), different surface.
…ce test)

Per docs/README.md existence test, this doc fails 3 of 4 criteria:
- ❌ Doesn't document durable policy unavailable elsewhere — every fact
  reproducible from db.ts / builtin.ts / audit-engine.ts / --recipes-json
- ❌ Doesn't track open work — pure snapshot
- ❌ No unique historical context git log + architecture.md can't
  reconstruct
- ✅ Cited by another doc (only because non-goals-reassessment cited it)

Plus Rule 1 violation (duplicates architecture.md § Schema) and Rule 6
violation (hardcodes "15 recipes" / "9 of 15 ship actions" inventory
counts in narrative).

The real value the doc delivered was the **triangulation discipline** —
catching 3 errors in non-goals-reassessment v1. That discipline is the
durable artifact, not the doc. Codified in two places:

1. non-goals-reassessment § 8 errata + process lesson (kept)
2. .agents/lessons.md — new lesson explicitly bans the "dual descriptive
   + prescriptive doc" pattern as a Rule 1 violation. Right discipline:
   pin every concrete claim in the prescriptive doc itself, or self-audit
   against the canonical home before committing. Don't ship a parallel
   descriptive doc.

non-goals-reassessment header + § 7 + § 8 updated to drop the now-deleted
companion-doc references and point at canonical sources directly
(architecture.md § Schema, db.ts, builtin.ts, audit-engine.ts V1_DELTAS).
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.agents/lessons.md (1)

16-16: 💤 Low value

Minor grammatical awkwardness in rationale.

The phrase "a git clone of someone else's machine isn't a fact we can cite" is slightly awkward. Consider: "cloning someone else's local repository isn't a citable reference" or "local clones cannot serve as public references."

✨ Suggested rewording
-- **Never commit absolute local user paths** — no `/Users/<name>/…`, `/home/<name>/…`, `~/…`, or `file:///` URIs in any tracked doc, code, comment, or PR body. Reasons: (1) leaks the maintainer's directory structure / username to public mirrors; (2) every other contributor's paths differ — the reference is dead on their machine; (3) a `git clone` of someone else's machine isn't a fact we can cite as a "source for deep-dives" — public upstream URLs are. Pattern: cite `https://github.com/<org>/<repo>` (with optional `/tree/<sha>/<path>`) for upstream sources; use repo-relative paths (`docs/foo.md`, `src/bar.ts`) for in-tree references. Hit on PR `#58` first draft — referenced the local fallow clone path in the research note before the user caught it.
+- **Never commit absolute local user paths** — no `/Users/<name>/…`, `/home/<name>/…`, `~/…`, or `file:///` URIs in any tracked doc, code, comment, or PR body. Reasons: (1) leaks the maintainer's directory structure / username to public mirrors; (2) every other contributor's paths differ — the reference is dead on their machine; (3) local clones cannot serve as public references for "source deep-dives". Pattern: cite `https://github.com/<org>/<repo>` (with optional `/tree/<sha>/<path>`) for upstream sources; use repo-relative paths (`docs/foo.md`, `src/bar.ts`) for in-tree references. Hit on PR `#58` first draft — referenced the local fallow clone path in the research note before the user caught it.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.agents/lessons.md at line 16, The sentence in .agents/lessons.md ("a `git
clone` of someone else's machine isn't a fact we can cite as a "source for
deep-dives"") reads awkwardly; replace that clause in the bullet under "Never
commit absolute local user paths" with a clearer alternative such as "cloning
someone else's local repository isn't a citable reference" or "local clones
cannot serve as public references" so the rationale reads smoothly while
preserving the existing guidance and examples in that bullet.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/research/non-goals-reassessment-2026-05.md`:
- Line 167: The effort estimate for "(c) Cyclomatic complexity column" is
inconsistent: update the short-form estimate in the paragraph/row that currently
shows "S" to match the "M" effort shown in table row 1.3 (and in §1's discussion
of extending the AST walker), or alternatively reconcile both places by
adjusting the table row 1.3 text to justify "S"; specifically edit the text that
labels "(c) Cyclomatic complexity column" so both the inline mention and table
row 1.3 use the same effort value and add a brief justification line referencing
the AST walker work (the same rationale used in §1) to avoid future divergence.

---

Nitpick comments:
In @.agents/lessons.md:
- Line 16: The sentence in .agents/lessons.md ("a `git clone` of someone else's
machine isn't a fact we can cite as a "source for deep-dives"") reads awkwardly;
replace that clause in the bullet under "Never commit absolute local user paths"
with a clearer alternative such as "cloning someone else's local repository
isn't a citable reference" or "local clones cannot serve as public references"
so the rationale reads smoothly while preserving the existing guidance and
examples in that bullet.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6741d4a6-45cf-407d-a741-1c5d84a25767

📥 Commits

Reviewing files that changed from the base of the PR and between b5679a6 and a5cab90.

📒 Files selected for processing (2)
  • .agents/lessons.md
  • docs/research/non-goals-reassessment-2026-05.md

Comment thread docs/research/non-goals-reassessment-2026-05.md Outdated
CodeRabbit caught § 5 row (c) "Cyclomatic complexity column" listing
effort S, while § 1.3 + § 8 errata both list M (the v1→v2 bump after
`rg 'complexity|node_count|nodeCount' src/` returned zero — node-
counting isn't already in place; the AST walker in src/parser.ts has
to be extended). Effort propagation gap from the v2 errata pass.

§ 5 row (c) updated to M; "Why" cell now spells out the AST-walker
dependency inline so future readers don't re-litigate the figure.
Grill-me Q1 outcome (under "extract max from SQL-index + equal/surpass
fallow" mission): the original § 3 list conflated ergonomic floors
(sub-100ms cold-start, no LLM, no JS at index time) with the actual
moats. Most of the original entries are floors fallow also follows;
they're not differentiators.

The two real moats that needed naming as load-bearing limits:

  A. SQL is the API — every capability is a recipe (saved query) or a
     primitive recipes can compose. Verdicts are an OUTPUT mode
     (--format sarif, audit deltas), never a primitive. Reviewer test:
     "is this verb also expressible as query --recipe <id>?"

  B. Extracted structure ≥ verdicts — schema breadth (CSS, markers,
     type_members, calls.caller_scope, components.hooks_used) is what
     equals/surpasses fallow on agent-facing capability per
     fallow.md § 5. Reviewer test for any "drop column X" PR:
     "what recipe (bundled or hypothetical) does this kill?"

Both are now load-bearing rows above the ergonomic ones. The original
five preferences are kept verbatim but annotated with their relation
to the moat (floor / convergent / adjacent / rivalrous / safety).

Eroding either A or B is the most likely path from "codemap" to
"fallow with extra steps" — § 3 now equips a reviewer to spot it.
Grill-me Q2 outcome (under "equal/surpass fallow" mission): the
"cheapest non-goal flip first" ordering was a small-team confidence
move, but the § 3 moat rewrite already paid that confidence cost. The
real risk under the actual mission is the deferral trap — XL items
become "next quarter" while every new recipe inherits the noisy
substrate (untested-and-dead's Next.js page.tsx false-positive class).

Hybrid resolved:
- Shipping cadence stays (a) → (c) → (b) impl → (d).
- (b) plan PR opens at T+0, iterates in parallel during (a)+(c).
- Plan opens with ~30% of decisions pre-locked: entry-point hints only
  per Grill Q4, static config only per § 3 "no JS exec at index time"
  ergonomic limit. Not a blank-slate plan — structured from day 1.

Added a 5-row T-table in § 5 spelling out the parallel tracks. (b)'s
"Why" cell now names the deferral trap explicitly; (d)'s "Why" pins
its dep on (b) impl (not just (b)). Rationale list updated to flag
that the moat rewrite paid the confidence move so (a) doesn't pay it
again.

Cost-if-abandoned escape hatch: plan PR can close as
"Status: Rejected (YYYY-MM-DD)" per docs/README.md Rule 8. Design
surface captured either way.
…refs)

Grill-me Q3 outcome: § 2's five flips inherited their shape from
"original non-goals worth challenging" — but after § 3 locked in the
moats, that shape conflated three different categories:

- Moat-extending flips (2.1 FTS5, 2.3 static analysis) — substrate
  growth inside moat B
- Moat-aligned flip (2.2 output formatters) — verdicts as output mode
  per moat A
- Moat-orthogonal transport flips (2.4 daemon, 2.5 LSP shim) — neither
  moat is touched; flipping just re-exposes existing substrate

Anchors preserved (2.1-2.5 stay) — anchor-preservation discipline per
docs-governance § 3 / docs/README.md Rule 7. No cascading link updates
needed in § 3 / § 4 / § 5 / § 8.

Changes per section:

- § 2 header — added a reading note naming the three categories and
  pointing each flip at the moat row it relates to.
- § 2.3 — verdict no longer restates "no opinionated rule engine + no
  fix engine" (now canonical in § 3 moat A + ergonomic row); instead
  cross-references and names the static-analysis category as in-scope.
  Closed-dead-subgraph caveat preserved (it's the C.9 motivator).
- § 2.4 — added "Moat relation: orthogonal" subsection naming the
  transport / process-model framing. AST-caching capability claim
  preserved + cross-linked to § 6 Q1. Verdict points the daemon-default
  question at § 6 Q1 explicitly (single canonical home).
- § 2.5 — replaced the unmeasured "80% of LSP read-side" claim with a
  structural argument: shim wraps shipped engines (show / impact /
  watch) via stdio without re-extracting structure; an LSP *engine*
  would duplicate moat B substrate (the actual reason not to build
  one). Cited application/show-engine.ts + application/impact-engine.ts
  as the substrate the shim wraps.

- § 6 Q1 — enriched with the AST-caching downstream measurement note
  lifted from § 2.4 (single canonical home for the daemon-default
  decision; § 2.4 cross-refs here).

Vital-info preservation audit:
- ✅ Closed-dead-subgraph caveat (8-file widget pack via fallow.md § 0)
  — kept verbatim in § 2.3 caveat block.
- ✅ AST-caching capability claim — kept in § 2.4 "Capability unlocked"
  + cross-linked from § 6 Q1.
- ✅ Watch-mode receipts (codemap watch / mcp --watch / serve --watch)
  — kept verbatim in § 2.4 "What's actually true".
- ✅ Fan-in/fan-out hotspot-rankers framing — kept verbatim in § 2.3
  caveat (with errata cross-ref to § 8).
- ✅ Fallow `crates/lsp/` cross-ref — kept in § 2.5.

Dropped (intentional):
- "80% of LSP read-side" — unmeasured; replaced with structural
  argument that doesn't need a measurement.
Grill-me Q4 outcome: § 1.7's "What's needed" cell was loose ("new
--format mermaid formatter") — true but underspecified. Real-project
edge counts on dependencies / calls are 1k-10k+; rendering them is
either Mermaid-choking or a hairball, and silently auto-truncating
(or "best-effort") would be a verdict-shaped affordance masquerading
as an output mode — violates moat A.

Locked in:

- Allow on: impact engine output (depth-bounded), LIMIT N-shipped
  recipes (fan-in / fan-out), ad-hoc SQL with explicit LIMIT ≤ 50.
- Reject (with scope-suggestion message) on unbounded inputs.
- No auto-truncation — that's a verdict (recipe author's job to scope).

Threshold (50 edges) is configurable; chosen as a default-readable
upper bound for chat-client rendering. Calibrate during (a) impl PR
against fixtures/golden / external corpus.

DX framing: hairballed Mermaid in MCP / Cursor / Slack chat clients
renders as garbage; a clear error naming knobs (LIMIT / --via / WHERE
from_path LIKE) is the better consumer signal.

This keeps Mermaid an output mode (moat A clean) and forces recipe
authors to scope graphs — correct because they own the structural
meaning of the result set.
…recipes

Grill-me Q5 outcome: § 1.10's verb-shape ("codemap rename <old> <new>
--dry-run") was downstream of the OLD § 3 ("no fix engine" as a top-
level non-goal). After the moat reframe, the actual test is moat A:
verdict-shape vs recipe-shape. Verb hides every implicit rename
choice (visibility filter, type-only re-exports, test files, aliases)
inside argv parsing — not auditable. Recipe-shape puts those choices
in reviewable SQL.

Locked in:

- Bundled recipe rename-preview.sql with --params key=value
  substitution (?-placeholder binding via db.ts prepared statements).
- --format diff output mode (sibling of --format mermaid per item 1.7;
  same "rows in, renderable text out" pattern).
- No new verb / engine / MCP tool / HTTP route. SQL stays the API.
- Effort drops M → S.

Cross-cutting infrastructure unlocked: parametrised recipes is net-new
plumbing but pays for itself on the first downstream use. Already-
visible follow-ons captured in the new "Cross-cutting infrastructure
unlocked by item 1.10" paragraph at the end of § 1:

- delete-symbol-preview, extract-function-preview, inline-symbol-
  preview — same recipe-shape pattern; all gated on the same plumbing.
- Parametrising existing static recipes (untested-and-dead
  --params min_coverage=80 instead of hardcoded < 80) — cleanup
  opportunity the same plumbing enables.

This is the second moat-A demonstration in two adjacent grill rounds
(after § 1.7's bounded-input contract on Mermaid). Both prove the
"verdicts are output mode, recipes are the API" framing on real
capabilities — exactly what the (a) plan-PR will need to point at
when reviewers ask "what changed?".
…plugin scope)

Grill-me Q6 outcome (and accounting cleanup): three of five § 6 open
questions are now resolved by prior grill outcomes — § 6 needs to
reflect that, not pretend they're still open.

Resolutions captured:

- Q1 (daemon-default for mcp/serve) — RESOLVED THIS GRILL TURN.
  Default --watch ON for both modes; opt-out via --no-watch /
  CODEMAP_WATCH=0. One-shot CLI defaults preserved (no watcher on
  query/show/snippet). Receipts: stale-index = #1 agent UX complaint
  (fallow.md § 6); chokidar lazy startup validated tiny by PR #46
  6-watcher audit. Flip is a small follow-up PR (flag default + test
  + patch changeset + agent rule update per docs/README.md Rule 10).
  AST-caching measurement parked downstream of the flip.

- Q3 (LSP shim vs standalone) — RESOLVED in § 2.5 reframe earlier
  this grill (commit 0b9d878). Thin shim wrapping shipped engines;
  no engine (would duplicate moat B substrate). Standalone deferred
  to "if VSCode-extension demand emerges."

- Q4 (C.9 plugin contract scope) — RESOLVED via § 5 (b) plan-PR
  pre-locked decisions (commit 6f845ba). Entry-point hints only for
  v1; arbitrary edge injection deferred to v2. Static config only
  per § 3 ergonomic "no JS exec at index time" floor.

§ 6 restructured: "Resolved (2026-05)" subsection at top with full
rationale + receipts; "Still open" subsection below with Q2 (FTS5
default) and Q5 (history table) — the only two genuinely-open
questions left.

§ 2.4 verdict updated to point at the resolved § 6 Q1 anchor instead
of the open-question wording.

Anchor preservation: external links (#6-open-questions) still resolve
to the section heading. New internal anchor (#resolved-2026-05) used
by § 2.4 verdict — single inbound link, no external citations to
break.
Grill-me Q7 outcome: § 6 Q2 (FTS5 opt-in vs default-on) resolved.

Locked in:

- Toggle: BOTH codemap.config.ts `fts5: true` AND --with-fts CLI flag
  at index time. Config-only forces CI / ephemeral workflows to commit
  fts5: true to a config file; CLI-only forces long-term users to
  remember the flag on every --full. Cheap to support both.
- Default: OFF. Backwards-compat — existing users wouldn't see
  .codemap/index.db grow ~30-50% silently on next --full.
- Re-evaluate default in v2 once external-corpus size measurements
  land (bun run benchmark:query shape).

Bug fix in § 2.1: the "off by default to keep cold-start sub-100ms"
framing was a WRONG REASON. FTS5 is index-time cost only; cold-start
reads existing DB and the virtual table doesn't slow startup. Real
reason for default-OFF is index size growth. § 2.1 verdict updated to
reflect this; § 6 Q2 resolution explicitly calls out the wrong-reason
correction so future readers see the diff.

Principle pinned: default-ON is reserved for capabilities without
disk-size tax (Mermaid output, parametrised recipes, complexity
column). FTS5 is the disk-tax exception.

Tree state after this commit:

- § 6 Q1 (daemon-default) — resolved
- § 6 Q2 (FTS5 default) — resolved
- § 6 Q3 (LSP shape) — resolved
- § 6 Q4 (plugin scope) — resolved
- § 6 Q5 (history table) — STILL OPEN (defer-bias confirmed by doc)
…indings

Grill-me Q8 outcome: § 6 Q5 (history table) resolved as DEFERRED, with
the full grill analysis preserved inline so the next reviewer doesn't
have to re-derive why we said no.

Findings captured:

- WHAT it would do — point-in-time index gains a temporal dimension
  ("when did symbol X get @deprecated?", "coverage trend over 50
  commits", "files that became dead this week").
- WHAT audit --base <ref> already covers — pairwise diff serves the
  most-common temporal question (PR-scoped delta) with no schema
  growth. Longitudinal "evolved over commits 1..N" is the unfilled gap.
- TWO SHAPES table — per-commit snapshots (~25 GB on 500-commit
  retention; trivial query cost) vs append-only event log (~5-25 MB
  deltas; heavy recursive-CTE query cost).
- BACKFILL COST — N reindexes (~30s each = ~4 hrs first-run for 500
  commits) is the same for both shapes; deal-breaker today.
- ARCHITECTURE IMPACT — schema bump (minor per pre-v1 lesson), db.ts
  + indexer hooks, retention policy config, deeper git integration.
- WHY DEFER — anti-bloat meta-rule (no recipe demands it); audit
  --base covers common case; backfill prohibitive without paying use
  case; shape-decision wasted without empirical access patterns.
- REVISIT TRIGGERS — TWO consumers shipping jq-based "audit runs over
  time" workflows (mirrors B.5 verdict-threshold deferral pattern), OR
  query_baselines evolution becoming a recurring agent need.

The full analysis is now inline in § 6 Q5 (~30 lines + cost table).
Per user request: don't lose vital information; document grilling
findings for fuller context. Future reviewers see the full reasoning,
not just "deferred" — same posture as § 8 errata's "future readers
can see the diff between v1 and v2."

§ 6 status after this commit: ALL FIVE OPEN QUESTIONS RESOLVED. Q1
(daemon-default), Q2 (FTS5 default), Q3 (LSP shape), Q4 (plugin
scope), Q5 (history table) — every decision the doc was authored to
force is now pinned with rationale and revisit triggers (where
applicable).
Grill-me Q9 outcome: § 1.9's "Recipe usage telemetry" framing was a
gotcha. The word "telemetry" carries upload / aggregation /
surveillance connotations that don't match the actual capability
(purely local recency tracking) — and would either get the feature
rejected sight-unseen by privacy-conscious users / corp installations
OR silently set up substrate for a future "phone home" PR without an
explicit non-goal saying we won't.

Renamed + tightened § 1.9:

- "Recipe usage telemetry" → "Local recipe-recency tracking".
- Table renamed recipe_usage → recipe_recency (named after the value,
  not the act).
- Added 90-day retention bound (caps unbounded growth via per-reindex
  pruning).
- Added opt-out config (`recipe_recency: false` skips the reconciler).
- --recipes-json surface spec'd: {recipe_id, last_run_at,
  run_count_90d}.
- Naming-note paragraph explains why "telemetry" was rejected.

New § 3 ergonomic floor row "No telemetry upload":

- Locks in the privacy posture explicitly. No HTTP-out primitive in
  codebase today (grep-able), but the floor exists to resist
  accumulation pressure — a future "anonymous opt-in usage stats to
  help prioritize recipes" PR would look reasonable without an
  explicit floor.
- Convergent with fallow (probably also doesn't upload) — floor, not
  moat.
- Cross-references item 1.9 as the only usage-data feature; consumers
  can audit the .codemap/index.db location + retention bound.

Lockstep update needed when item 1.9 ships: docs/why-codemap.md
"What Codemap is not" gains "Codemap never uploads usage data" per
docs/README.md Rule 10. Already cross-referenced in § 7 of this doc.
User reframe: codemap is the only SQL-based code index in the market;
inspiration comes from the free and open internet (LSP spec, SQLite
docs, AST tooling), not code-by-code cloning of any peer tool. Drop
fallow as a yardstick throughout.

Vital information preserved (per "don't lose any vital information
that is used to execute the plan"):

- Closed-dead-subgraph motivator for C.9 — kept as an abstract pattern
  description in § 2.3 caveat (N-file packs with self-imports, non-
  zero fan-in, none reachable from real entry). Was previously cited
  to fallow.md § 0; now stands on its own merit.
- LSP read-side capabilities (show / impact / watch) — kept; LSP spec
  upstream is now the protocol authority instead of fallow's
  crates/lsp/.
- Runtime-tracing scope distinction — § 3 floor reframed to anchor on
  "different product class entirely" (live process data vs static
  analysis) instead of "fallow's paid moat."
- Predicate-as-API moat (A) — kept; justification now anchors on
  intrinsic merit (SQL is durable, agents compose any predicate)
  rather than "fallow ships verdicts; we don't."
- Schema-breadth moat (B) — kept; justification now "codemap-specific
  extractions; their richness directly determines what JOINs are
  expressible" rather than "fallow has none of these."

Section-by-section changes:

- HEADER — "Companion docs / Source for deep-dives" replaced with
  "Companion doc" (competitive-scan only) + "Positioning" paragraph
  declaring structural uniqueness.
- § 2.3 original-framing quote — paraphrased to drop the "(e.g.
  fallow, knip, jscpd)" parenthetical; pointers to roadmap.md for the
  full original wording. (roadmap.md itself still has the parenthetical;
  separate-PR scope.)
- § 2.3 caveat — closed-dead-subgraph case described abstractly; no
  source citation needed.
- § 2.5 LSP shim — "fallow has crates/lsp/" → "LSP spec upstream is
  the protocol authority."
- § 3 intro — mission framing rewritten; "equal/surpass fallow"
  language replaced with "extract maximum value from the SQL-index
  architecture; grow the ecosystem" + "only SQL-based code index in
  the market" positioning.
- § 3 Moat A — anchored on intrinsic merit (SQL durable + agent
  composability) instead of fallow comparison.
- § 3 Moat B — anchored on "substrate every recipe layers on; richness
  determines JOIN expressivity" instead of "fallow has none of these."
- § 3 ergonomic floors — dropped all "fallow is also fast" /
  "Convergent with fallow" annotations; reframed runtime-tracing as
  "different product class entirely (live process data, not static
  analysis)" + reframed telemetry-upload as standalone safety promise.
- § 4 — DELETED ENTIRELY ("What to inspect in the fallow source
  tree"). Replaced with "Inspiration sources for plan-PR authoring"
  table listing open specs / primitive sources only (LSP spec, SQLite
  docs, oxc node reference, Lightning CSS, JSON-RPC + MCP spec, TC39
  proposals, existing codemap surface, internal third-party graph
  audits). Discipline statement preserved: every plan PR cites the
  spec / primitive source it took inspiration from.
- § 5 (d) row + T-table T+5w → +7w cell — dropped fallow crates/lsp/
  refs; LSP spec is now the named authority.
- § 6 Q1 — dropped fallow.md § 6 citation; stale-index frequency now
  anchored on PR #46 + PR #56 internal evidence.
- § 6 Q4 — dropped fallow.md § 0 + § 6 citations; closed-dead-subgraph
  case cross-refs § 2.3 caveat instead.
- § 7 cross-references — removed research/fallow.md and fallow
  upstream entries. Added § 4 inspection list as a self-reference.
- § 8 errata § 2.3 row — dropped fallow.md citation; pattern described
  inline.

Net effect: the doc stands on codemap's intrinsic structural
properties. No peer-tool framing remains. The mission is now
self-coherent: extract max value from the SQL-index architecture +
grow the ecosystem, anchored on the unique-in-market positioning.
Fact-check finding: the "structurally unique — only SQL-based code
index in the market" claim doesn't hold. Web search + verification
surfaced a real cohort of SQLite-backed code indexers for AI agents:

- srclight (29 stars) — SQLite FTS5 + tree-sitter + embeddings + MCP,
  42 tools, 11 langs. Pitch identical to codemap's ("AI agents spend
  40-60% tokens on orientation; we eliminate this").
- Sverklo (30 stars) — local-first MCP, symbol graph, blast-radius,
  open-source alternative to Greptile/Sourcegraph.
- ctxpp / ctx++ (17 stars) — Go MCP, tree-sitter, SQLite + FTS +
  vector, blast-radius analysis (= codemap's impact).
- KotaDB (99 stars) — TS + Bun + SQLite — IDENTICAL stack to codemap.
- codemogger (2026) — MCP, tree-sitter, SQLite + FTS + vector,
  semantic search.
- @squirrelsoft/code-index, QuickAST, code-scale-mcp, CodeAgent
  Indexing Engine, Polyglot Indexer MCP, Continue's CodeSnippetsIndex
  — all SQLite-backed code indexers with overlapping surface.

Codemap is one of ~10+, NOT unique. Retracting the claim.

Honest differentiation (after verification):

1. Predicate-as-API — peers ship pre-baked verbs / MCP tools; codemap
   exposes raw SQL + recipes. Genuinely rare in the cohort.
2. Pure structural — no embeddings, no LLM in box. Most peers add
   vector search by default. Genuine differentiation.
3. JS/TS/CSS-ecosystem-deep extraction — CSS variables/classes/
   keyframes, React components.hooks_used, type_members, markers.
   Peers focus on cross-language symbol+call surface via tree-sitter.

The depth axis (3) is structurally enabled by parser choice — oxc
(JS/TS) and lightningcss (CSS) are Rust-based and ecosystem-
specialized; peers using tree-sitter trade depth for breadth.

Where codemap is BEHIND the cohort (not hidden): multi-language
support (codemap = TS/JS/CSS only; peers = 10-15 langs), star count,
embeddings/semantic search, market traction.

Edits applied:

- HEADER positioning paragraph — retracted "structurally unique";
  named the cohort explicitly (srclight, Sverklo, ctxpp, KotaDB,
  codemogger, etc.); spelled out the three differentiation axes;
  added the parser-choice rationale (oxc + lightningcss as the
  structural enabler of axis 3).
- § 3 moat-intro line — replaced "the only SQL-based code index in
  the market" with "specific niche in the SQLite-backed-code-index
  cohort" + the three axes. Reviewer test reframed: eroding either
  moat turns codemap into "yet-another-tool-in-the-cohort instead of
  the predicate-shaped specialist."

Moats A and B themselves required no rewrite — their justifications
(predicate-as-API durability + extracted-structure substrate) hold
under the corrected positioning. The peer cohort discovery actually
sharpens both moats: A is the specialty (raw SQL surface) and B is
the depth axis (richer extraction than tree-sitter cohort).
…aveat

Grill-me Q12 outcome: § 1.4's "fan_in × (100 - coverage_pct)" formula
had two correctness bugs and one accepted modeling limitation:

CORRECTNESS FIXES (must ship):
- Orphans (fan_in=0) scored 0 → "no risk" → wrong (orphans are
  high-risk: dead code or hidden-import targets we don't track).
  Fix: `fan_in + 1` so orphans score on coverage alone.
- NULL coverage_pct propagated through the formula → 100 - NULL = NULL
  → row dropped from ORDER BY → unmeasured-coverage symbols silently
  vanished from the ranking. Fix: COALESCE(coverage_pct, 0) treats
  unmeasured as 0% (high risk).

ACCEPTED v1 TRADE-OFF:
- Linear-in-fan_in (fan_in 100 with 99% coverage = fan_in 1 with 0%
  coverage in the score). Real, but not worth fixing in the bundled
  recipe — users tune via project-local override.

Caveat block in refactor-risk-ranking.md (will accompany the recipe
when (a) ships) names tuning axes for project-local overrides:
- Log-scale fan_in (LOG(fan_in + 1) * 30) for hub-heavy codebases
- Visibility weight (if @public / @internal / @beta JSDoc tags are
  used consistently)
- LOC weight (if test-density varies across files)

Why ship-with-caveat instead of multi-axis composite (Option B):
- Moat A says recipes are saved queries (starting points), not
  authoritative verdicts. Bundled formula gets 80% right; users iterate.
- Anti-bloat meta-rule — every additional axis encodes more opinions;
  shipping minimal forces explicit thought during tuning.
- Ecosystem-specific axes (visibility weight, LOC weight) shouldn't
  be in the bundled default.

Effort stays XS. The .md caveat block lands in the (a) plan PR / impl
PR alongside the .sql; not part of THIS research-note PR's scope.
Grill-me Q13 outcome: § 1.5 was underspecified ("--boundaries <config>
flag on audit OR recipe consuming the config"). Three real questions
needed answering: where the config lives, what shape, recipe-or-flag.

Shape A (directional rules) locked in for v1:

  boundaries: [
    {
      name: "no-cross-feature",
      from_glob: "src/features/*/**",
      to_glob:   "src/features/*/**",
      action: "deny",
      except_self: true,
    },
    ...
  ]

Why A over B (element-types) over C (layers) — honest discriminator:

A and B have IDENTICAL expressiveness (B compiles to A at index time).
The real question is ergonomics-at-scale vs forward-compat / smallest-
viable-config:

- A wins 5 of 6 dimensions: smallest-viable-config (one entry); Zod
  schema simplest; mental-model load (one concept); forward-compat (B
  layers on top later as sugar); backwards-compat (never paint into a
  corner; primitives are durable).
- B wins only "ergonomics at scale" (5+ rules with element reuse) —
  exactly the dimension that can be added later as a sugar layer
  without breaking A.
- C (layer ordering) is most opinionated; only fits layered
  architectures. Not a v1 default.

Decision rule (ship the smallest primitive that doesn't paint into a
corner; layer ergonomics on top later) mirrors § 6 Q5 history-table
defer logic.

Implementation reuses every shipped or in-flight piece of plumbing:

- Zod config slot (existing src/config.ts substrate)
- Index-time reconciler (mirrors recipe_recency from item 1.9)
- New boundary_rules table (moat-B-aligned schema growth)
- Bundled recipe boundary-violations.sql via SQLite GLOB operator
- SARIF output formatter (already shipped) for CI gate

NO new CLI flag — moat-A clean. The verb is query --recipe
boundary-violations --format sarif. Recipe consumes config-as-data;
SARIF output mode handles verdict-shaped CI consumers.

Effort stays S. Element-types / layer sugar deferred to v1.x with
explicit "demand-driven" trigger (mirrors fallow.md B.5 verdict-
threshold deferral pattern, kept in this doc as the recurring
deferral idiom).
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
docs/research/non-goals-reassessment-2026-05.md (1)

44-49: ⚡ Quick win

Add a concrete codemap.config.ts example for the newly referenced options.

You document several options (boundaries, fts5, recipe_recency, watch defaults) but mostly inline. A single runnable config snippet would make this operationally clearer and satisfy docs policy.

Suggested doc addition
+### Example config (for options introduced in this doc)
+
+```ts
+// codemap.config.ts
+export default {
+  fts5: true,                  // enables FTS5 index table at index time
+  recipe_recency: false,       // opt out of local recency tracking
+  boundaries: [
+    { name: "ui-to-data", from_glob: "src/ui/**", to_glob: "src/data/**", action: "deny", except_self: true }
+  ]
+}
+```
+
+CLI equivalents:
+- `codemap index --with-fts`
+- `codemap mcp --no-watch` (or `CODEMAP_WATCH=0`)

As per coding guidelines, "Document all configuration options with examples".

Also applies to: 214-219

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/research/non-goals-reassessment-2026-05.md` around lines 44 - 49, The
docs lack a runnable codemap.config.ts example for the newly referenced options;
add a concrete snippet showing export default { fts5: true, recipe_recency:
false, boundaries: [...] } (including a sample boundary rule with
name/from_glob/to_glob/action/except_self) plus a short “CLI equivalents” line
showing the corresponding flags (e.g. --with-fts, --no-watch or
CODEMAP_WATCH=0); place this example near the paragraphs that reference
boundaries, fts5, recipe_recency and watch defaults so readers can see the exact
config shape and CLI parity.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/research/non-goals-reassessment-2026-05.md`:
- Around line 163-164: The sentence claiming "Codemap is structurally unique
(only SQL-based code index in the market)" conflicts with earlier cohort
framing; change that clause to a consistent phrasing such as "Codemap is
differentiated within the cohort (SQLite-backed among peers)" and ensure the
term "SQL-based" / "SQLite-backed cohort" is used consistently across the doc;
update the specific sentence containing "structurally unique" and any other
occurrences of "only SQL-based" to match the new wording so terminology remains
consistent (look for the string "Codemap is structurally unique" and the
parenthetical "only SQL-based code index in the market").

---

Nitpick comments:
In `@docs/research/non-goals-reassessment-2026-05.md`:
- Around line 44-49: The docs lack a runnable codemap.config.ts example for the
newly referenced options; add a concrete snippet showing export default { fts5:
true, recipe_recency: false, boundaries: [...] } (including a sample boundary
rule with name/from_glob/to_glob/action/except_self) plus a short “CLI
equivalents” line showing the corresponding flags (e.g. --with-fts, --no-watch
or CODEMAP_WATCH=0); place this example near the paragraphs that reference
boundaries, fts5, recipe_recency and watch defaults so readers can see the exact
config shape and CLI parity.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c1ef920f-ef81-4259-853a-245225130baa

📥 Commits

Reviewing files that changed from the base of the PR and between a636eb0 and 983c67f.

📒 Files selected for processing (1)
  • docs/research/non-goals-reassessment-2026-05.md

Comment thread docs/research/non-goals-reassessment-2026-05.md
Grill-me Q14 outcome: three remaining § 1 rows had implicit gotchas
the recipe author would otherwise have to discover during impl. Each
row gets a small clarification — substrate unchanged, effort unchanged.

§ 1.1 components-touching-deprecated:
- Was: "One bundled recipe (components-touching-deprecated)"
- Now: explicit two-path UNION
  - HOOK PATH: components.hooks_used JSON overlap with @deprecated
    symbols (catches deprecated hooks like useDeprecatedThing)
  - CALL PATH: calls.caller_name IN (SELECT name FROM components) ×
    @deprecated symbols by callee_name (catches regular deprecated
    functions called inside components)
- Hook-only variants would ship false-negatives — recipe author needs
  the explicit UNION to avoid the trap.

§ 1.6 unused-type-members:
- Was: "Recipe (unused-type-members) — needs JSON-extraction predicate"
- Now: ADVISORY recipe with explicit caveat block in .md. Output is
  "review these" candidates, NEVER "safe to delete" — TS has multiple
  indirect-usage classes codemap's substrate doesn't track:
    - Indexed access: T['fieldName']
    - keyof T
    - Type spreads: type X = T & {...}
    - Mapped types: {[K in keyof T]: ...}
  These produce false-positives. Recipe is useful as a candidate
  surfacer; agents must verify before deletion.

§ 1.8 more MCP resources:
- Was: hand-wave "add codemap://files/{path} and codemap://symbols/
  {name}"
- Now: spell out disambiguation envelope (reuses {matches,
  disambiguation?} pattern from PR #39 show/snippet) — symbols with
  duplicate names across files (Component, index, default, util-name
  collisions) return all matches with by_kind / files / hint metadata.
  Plus ?in=<path-prefix> query parameter mirroring show --in <path>.
- Without spelling this out, the implementation would have to invent
  disambiguation OR ship a "first match wins" gotcha.

Net: each row's What's-needed cell now contains enough detail that
the recipe / resource author can implement without re-deriving the
JOIN structure or envelope shape. Tactical clarity layered on top of
the structural decisions made in earlier grills.
@SutuSebastian SutuSebastian changed the title docs(research): non-goals reassessment + fallow clone deep-dive map (2026-05) docs(research): non-goals reassessment + cohort positioning + ship sequence (2026-05) May 4, 2026
@SutuSebastian SutuSebastian merged commit 54e3a2c into main May 4, 2026
10 checks passed
@SutuSebastian SutuSebastian deleted the docs/non-goals-reassessment branch May 4, 2026 12:07
SutuSebastian added a commit that referenced this pull request May 4, 2026
…62)

Per Rule 10 (lockstep with PR #58 fallow-decoupling) and the doc-
governance Single source of truth table — non-goals canonical home is
roadmap.md § Non-goals; the recently-merged research note at
docs/research/non-goals-reassessment-2026-05.md retracted the
"structurally unique" claim and dropped fallow as a positioning peer.

The parenthetical "(e.g. fallow, knip, jscpd)" in the static-analysis
non-goal still elevated fallow as a primary peer comparison. Cleanup:

  Before: (e.g. fallow, knip, jscpd)
  After:  (e.g. knip, jscpd)

knip + jscpd are kept because they're generic JS-ecosystem static-
analysis tools that aren't direct peers (knip = unused exports / files;
jscpd = code duplication detector). Both are legitimately "different
product class" without elevating fallow specifically as the yardstick.

This is the smallest possible cleanup; fallow.md closure (separate PR)
handles the in-research-folder framing.
SutuSebastian added a commit that referenced this pull request May 4, 2026
Per the parked follow-up from PR #58 grill (Q10): the cite-the-source-
path discipline in docs/research/non-goals-reassessment-2026-05.md § 4
was honor-system. Promoting to a Tier-2 auto-attached rule per the
agents-tier-system framework so plan-PR / recipe authors get the
inspection list primed automatically.

Files added/changed:

- .agents/rules/plan-pr-inspiration-discipline.md — Tier-2 rule body
  (~30 lines per Tier-2 priming guideline). Frontmatter: globs
  docs/plans/** + templates/recipes/**, alwaysApply: false, description
  with trigger phrases for Cursor's discoverability.

- .cursor/rules/plan-pr-inspiration-discipline.mdc — symlink to the
  source file per agents-first-convention.

- .agents/rules/agents-tier-system.md — added the new rule to the
  Tier 2 list with cross-ref to § 4 as the canonical inspection-sources
  catalogue.

Rule body covers:

1. Why peer-tool cloning dilutes codemap's niche (cohort positioning).
2. Top inspiration sources (LSP spec, SQLite docs, oxc, Lightning CSS,
   JSON-RPC + MCP, TC39, existing codemap surface).
3. Cite-the-source examples (proper pattern: cite spec; not peer-tool
   source path).
4. When-NOT-to-cite-a-peer escape hatch (empirical user-demand
   signals are OK; "X tool does Y so we should too" is not).

Pairs with the research-note § 4 list as the deep reference (no
separate skill needed; the list IS the deep reference). Mirrors the
docs-governance Tier-2 rule pattern (priming layer + skill reference).
SutuSebastian added a commit that referenced this pull request May 4, 2026
 (#61)

PR #58 (just merged) corrected codemap's positioning: not unique, but
in a specific niche of a SQLite-backed-code-index cohort with multiple
peers (srclight, Sverklo, ctxpp, KotaDB, codemogger, etc.). fallow is
one of many, not a yardstick.

Under the new positioning, fallow.md's framing ("adoption candidates
from fallow") is off-mission. Per docs-governance closure pattern
(competitive-scan-2026-04.md precedent), close the doc with a status
header pointing at the new canonical home + lift open items.

Closure rationale captured at the top:

- Status: Closed (2026-05) header explicit
- Cohort positioning summarized + cross-ref to research note for full
  framing
- Body preserved verbatim as historical record (Status snapshot below
  is the authoritative "what actually landed" log)
- New adoption candidates (if any) get authored against open specs +
  primitive sources per non-goals-reassessment-2026-05 § 4, not
  against fallow source tree
- Outstanding open items lifted to canonical homes:
  - C.9 plugin layer → in-flight PR #59 plan
  - C.10 LSP → covered by § 2.5 of research note (thin shim resolved)
  - C.11 coverage → shipped
  - Tier D defers (suppressions, fix engine, dupes, runtime intel) →
    aligned with § 3 ergonomic floors

Original framing preserved verbatim under "Original framing (preserved
verbatim from before 2026-05 closure)" subsection so historical readers
can see what the doc said in its open phase.

Per docs/README.md Rule 8 closing-research lifecycle. fallow.md stays
in repo (not deleted) — historical context git log alone can't
reconstruct.
SutuSebastian added a commit that referenced this pull request May 4, 2026
Per the parallel-plan-PR shape locked in by the just-merged research
note (PR #58, docs/research/non-goals-reassessment-2026-05.md § 5):
this file iterates in parallel with (a) FTS5 + Mermaid shipping;
impl unblocks when its slot arrives in the cadence (T+2w → +5w per
the § 5 T-table).

Skeleton captures:

- 5 PRE-LOCKED DECISIONS (L.1-L.5) carried over from the research
  note, with cross-references to specific § 6 / § 3 / § 2.3 anchors
  so any future challenge to these decisions has to argue against the
  source, not just open them as "open" questions.
- 9 OPEN DECISIONS (Q1-Q9) covering the design surface that needs
  to crystallise during plan iteration: contract shape, discovery
  mechanism, schema delta, reachability algorithm, bundled starters,
  conflict resolution, recipe composition, community-plugin API,
  backwards-compat default semantics. Each gets a Resolution
  subsection as it crystallises (mirrors the research-note § 6
  resolved-vs-open pattern).
- 3-piece HIGH-LEVEL ARCHITECTURE: plugin loader + indexer hook +
  reachability sweep. No CLI changes; no new verb. Recipes consume
  the substrate (moat-A clean per L.3).
- 5 IMPLEMENTATION SLICES (tracer-bullets — schema delta first,
  reachability recipe second, plugin contract third, starter plugins
  fourth, agent rule lockstep update fifth per docs/README.md
  Rule 10).
- TEST APPROACH grounded in existing infrastructure (golden queries
  per docs/golden-queries.md, fixture under fixtures/golden/c9-fixture/
  reproducing the closed-dead-subgraph case).
- 6-row RISKS / NON-GOALS table including the abandonment escape
  hatch (close as Status: Rejected per docs/README.md Rule 8 if
  needed; design surface captured either way).

Plus docs/README.md File Ownership row updated for the plans/ entry —
"Empty until the first plan lands" is no longer accurate after this
file lands. Per docs/README.md Rule 4 (keep ownership tables current
in the same PR as the doc-file change).
SutuSebastian added a commit that referenced this pull request May 4, 2026
…remaining surfaces (#64)

Audit of remaining `[Ff]allow` references after PRs #58, #61, #62
landed found 4 surfaces still treating fallow as a positioning peer
(off-mission under the cohort framing locked in by PR #58):

CLEANED UP:

- docs/why-codemap.md:23 — non-goal parenthetical "(those are different
  products — e.g. fallow, knip, jscpd)" still elevated fallow as the
  primary static-analysis exemplar. Mirrors the PR #62 roadmap.md fix
  (lockstep per docs/README.md Single source of truth — non-goals
  canonical home is roadmap.md; consumer-facing framing in
  why-codemap.md must follow).
  Now: "(those are different products — e.g. knip, jscpd)".

- docs/glossary.md:36 (audit definition) — "Distinct from `fallow
  audit` (that runs code-quality verdicts...)" singled out fallow as
  the comparator. Generalized to "Distinct from code-quality audit
  tools (e.g. knip for unused exports, jscpd for duplication, framework-
  specific complexity linters)". Same product-class point; no peer
  yardstick.

- .agents/rules/docs-governance.md:36 — "(fallow, future plugins)" as
  the canonical example of repo-wide tool adoption was stale (fallow.md
  closed in PR #61). Updated to "(oxlint, future plugins)" + added a
  closure-precedent note pointing at fallow.md's status header and
  non-goals-reassessment-2026-05.md for current positioning.

- .agents/skills/docs-governance/SKILL.md:86,88,136 — same staleness:
  "fallow" as ongoing-tracker example was stale; "fallow audit" in the
  re-derivable test list. Updated to oxlint + generic "static-analysis
  tooling"; preserved the fallow.md cross-ref as the CLOSED precedent
  (research notes that close with status header when peer framing goes
  off-mission).

LEFT ALONE (legitimate):

- docs/why-codemap.md:110-121 (comparison table) — different-product-
  classes consumer framing (Codemap vs fallow vs Aider RepoMap vs LSP).
  Not a peer yardstick under the cohort positioning; "agents can use
  Codemap AND fallow AND LSP" framing is honest about distinct slots.

- docs/research/fallow.md (closed historical) — body preserved per
  PR #61.

- docs/research/competitive-scan-2026-04.md (closed historical scan).

- .agents/lessons.md:16 — "Never commit absolute local user paths"
  lesson with PR #58 historical context referencing the fallow clone
  path. Historical record; preserve.

- .agents/skills/audit-pr-architecture/SKILL.md (5 mentions) —
  recommends `bunx fallow audit` as a static-analysis TOOL during
  PR audits. Different-product-class tool recommendation, not
  positioning. Borderline; left alone for now (could be genericized
  later as a separate concern).

Net effect: every remaining `[Ff]allow` reference in the repo is
either historical (closed research, lessons) or a different-product-
class acknowledgement (consumer comparison table, static-analysis
tool usage). Zero peer-yardstick framing remains in the load-bearing
positioning surfaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant