docs(plans): (a) FTS5 + Mermaid output — plan PR (skeleton)#60
docs(plans): (a) FTS5 + Mermaid output — plan PR (skeleton)#60SutuSebastian merged 1 commit intomainfrom
Conversation
|
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 21 minutes and 35 seconds.Comment |
Per docs/research/non-goals-reassessment-2026-05.md § 5 ship sequence: (a) is the next ship in the cadence track. This plan opens the design surface so impl can iterate against pinned decisions; mirrors the parallel-plan-PR shape from the (b) C.9 plan PR (#59). Skeleton captures: - 6 PRE-LOCKED DECISIONS (L.1-L.6) carried from the research note with deep cross-references: - L.1 FTS5 default OFF (backwards-compat per § 6 Q2) - L.2 Toggle BOTH config + CLI flag (per § 6 Q2) - L.3 Mermaid output mode is moat-A clean (per § 3 Moat A) - L.4 Mermaid bounded-input contract (per § 1.7) - L.5 Bundle one demo recipe text-in-deprecated-functions (per § 2.1) - L.6 Cold-start sub-100ms preserved (per § 3 ergonomic floor) - 7 OPEN DECISIONS (Q1-Q7) covering the design surface that needs to crystallise before impl: source_fts schema (column shape + tokeniser), indexer integration point, --full rebuild semantics on toggle change, Mermaid edge-count threshold default, output target shape (normalised input contract for the formatter), CLI flag precedence vs config, and DB-size telemetry on first FTS5 populate. - HIGH-LEVEL ARCHITECTURE split FTS5 + Mermaid + crosscut: - FTS5: schema bump + always-CREATE virtual table + Zod config field + --with-fts CLI flag + indexer write path + .codemap/.gitignore unchanged. - Mermaid: new formatMermaid() in output-formatters.ts (sibling of SARIF) + bounded-input check + plumbing through CLI / MCP / HTTP. - Crosscut: bundled recipe + schema-bump migration story (pre-v1 patch changeset) + agent rule lockstep update per Rule 10. - 7 IMPLEMENTATION SLICES (tracer-bullets) — substrate first (slice 1 ships FTS5 plumbing without recipe; proves end-to-end before recipe authoring), then demo recipe, then Mermaid formatter, then bound check, then MCP/HTTP plumbing, then docs/agents lockstep, then patch changeset. - TEST APPROACH grounded in existing infrastructure (golden queries per docs/golden-queries.md; integration fixture under fixtures/golden/fts5-fixture/ with @deprecated function + TODO comment + low-coverage file proving the JOIN composes). - 6-row RISKS / NON-GOALS table including the abandonment escape hatch (close as Status: Rejected per Rule 8 if needed). docs/README.md File Ownership row updated for plans/ — Rule 4 discipline: keep ownership tables current in the same PR. (Note: PR #59 also updates this row; rebase will combine both entries.)
528448a to
fe55ac3
Compare
Summary
Opens the (a) FTS5 + Mermaid output plan PR per the shipping cadence in PR #58 (
docs/research/non-goals-reassessment-2026-05.md§ 5). Track-1 first ship after the research note merge.Two non-goal flips in one plan because both are small (~50–150 LoC each) and demonstrate complementary moat alignment:
What's in the skeleton
--with-ftsCLI flagtext-in-deprecated-functions) showing FTS5 ⨯symbols⨯coverageJOINsource_ftsschema, indexer integration,--fullrebuild semantics on toggle change, Mermaid edge-count threshold, formatter input shape, CLI/config precedence, DB-size telemetry.fixtures/golden/fts5-fixture/reproducing the FTS5 JOIN composability.Doc-governance compliance
docs/plans/fts5-mermaid.mdper Rule 3.docs/README.mdFile Ownership row updated per Rule 4. Note: PR #59 also updates this row forc9-plugin-layer.md; the second-merged PR will need a small rebase to combine both entries.Test plan
bun run format:checkpassesdocs/research/non-goals-reassessment-2026-05.mdresolve to existing section anchorsIteration cadence
Each open decision (Q1–Q7) gets resolved via a separate commit on this branch with a "Resolution (YYYY-MM-DD)" subsection added inline (mirrors the research-note § 6 pattern). The plan stays in iterative state until impl-ready; merges with the impl PR per the cadence at T+0 → +1w.
Out of scope (separate PRs)
(b)C.9 plugin layer impl — separate cadence (T+2w → +5w).fallow.mdcleanup,roadmap.mdnon-goals lockstep, Tier-2 plan-PR rule.