Skip to content

docs(roadmap): drop fallow from non-goals "(e.g. …)" parenthetical#62

Merged
SutuSebastian merged 1 commit intomainfrom
docs/roadmap-non-goals-cleanup
May 4, 2026
Merged

docs(roadmap): drop fallow from non-goals "(e.g. …)" parenthetical#62
SutuSebastian merged 1 commit intomainfrom
docs/roadmap-non-goals-cleanup

Conversation

@SutuSebastian
Copy link
Copy Markdown
Contributor

Summary

Drops fallow from the static-analysis non-goal's "(e.g. ...)" parenthetical in docs/roadmap.md § Non-goals. Lockstep with PR #58's fallow-decoupling.

Diff

- (e.g. fallow, knip, jscpd)
+ (e.g. knip, jscpd)

Why

PR #58 corrected codemap's positioning: not "structurally unique," but in a specific niche of a SQLite-backed-code-index cohort (peers: srclight, Sverklo, ctxpp, KotaDB, codemogger, etc.). Under the new positioning, naming fallow specifically as the static-analysis exemplar elevates it as a yardstick — exactly what the new framing rejects.

knip (unused exports / files) and jscpd (code duplication detector) are kept because they're generic JS-ecosystem static-analysis tools that aren't direct peers of codemap's predicate-as-API + JS/TS/CSS-deep-extraction shape. Legitimately "different product class" without peer comparison.

Per docs/README.md Single source of truth table — non-goals canonical home is roadmap.md § Non-goals; lockstep update with research-note framing is required by Rule 10.

Test plan

  • bun run format:check passes
  • One-line edit, low risk

Out of scope

  • docs/research/fallow.md closure — PR #61.
  • Tier-2 plan-PR rule — separate PR.

Per Rule 10 (lockstep with PR #58 fallow-decoupling) and the doc-
governance Single source of truth table — non-goals canonical home is
roadmap.md § Non-goals; the recently-merged research note at
docs/research/non-goals-reassessment-2026-05.md retracted the
"structurally unique" claim and dropped fallow as a positioning peer.

The parenthetical "(e.g. fallow, knip, jscpd)" in the static-analysis
non-goal still elevated fallow as a primary peer comparison. Cleanup:

  Before: (e.g. fallow, knip, jscpd)
  After:  (e.g. knip, jscpd)

knip + jscpd are kept because they're generic JS-ecosystem static-
analysis tools that aren't direct peers (knip = unused exports / files;
jscpd = code duplication detector). Both are legitimately "different
product class" without elevating fallow specifically as the yardstick.

This is the smallest possible cleanup; fallow.md closure (separate PR)
handles the in-research-folder framing.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 4, 2026

⚠️ No Changeset found

Latest commit: 134f538

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 4, 2026

Warning

Rate limit exceeded

@SutuSebastian has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 25 minutes and 52 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8842fc54-ab9e-4546-851e-ca92621d1340

📥 Commits

Reviewing files that changed from the base of the PR and between 54e3a2c and 134f538.

📒 Files selected for processing (1)
  • docs/roadmap.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/roadmap-non-goals-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 25 minutes and 52 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@SutuSebastian SutuSebastian merged commit c6c5bdd into main May 4, 2026
10 checks passed
@SutuSebastian SutuSebastian deleted the docs/roadmap-non-goals-cleanup branch May 4, 2026 12:31
SutuSebastian added a commit that referenced this pull request May 4, 2026
…remaining surfaces (#64)

Audit of remaining `[Ff]allow` references after PRs #58, #61, #62
landed found 4 surfaces still treating fallow as a positioning peer
(off-mission under the cohort framing locked in by PR #58):

CLEANED UP:

- docs/why-codemap.md:23 — non-goal parenthetical "(those are different
  products — e.g. fallow, knip, jscpd)" still elevated fallow as the
  primary static-analysis exemplar. Mirrors the PR #62 roadmap.md fix
  (lockstep per docs/README.md Single source of truth — non-goals
  canonical home is roadmap.md; consumer-facing framing in
  why-codemap.md must follow).
  Now: "(those are different products — e.g. knip, jscpd)".

- docs/glossary.md:36 (audit definition) — "Distinct from `fallow
  audit` (that runs code-quality verdicts...)" singled out fallow as
  the comparator. Generalized to "Distinct from code-quality audit
  tools (e.g. knip for unused exports, jscpd for duplication, framework-
  specific complexity linters)". Same product-class point; no peer
  yardstick.

- .agents/rules/docs-governance.md:36 — "(fallow, future plugins)" as
  the canonical example of repo-wide tool adoption was stale (fallow.md
  closed in PR #61). Updated to "(oxlint, future plugins)" + added a
  closure-precedent note pointing at fallow.md's status header and
  non-goals-reassessment-2026-05.md for current positioning.

- .agents/skills/docs-governance/SKILL.md:86,88,136 — same staleness:
  "fallow" as ongoing-tracker example was stale; "fallow audit" in the
  re-derivable test list. Updated to oxlint + generic "static-analysis
  tooling"; preserved the fallow.md cross-ref as the CLOSED precedent
  (research notes that close with status header when peer framing goes
  off-mission).

LEFT ALONE (legitimate):

- docs/why-codemap.md:110-121 (comparison table) — different-product-
  classes consumer framing (Codemap vs fallow vs Aider RepoMap vs LSP).
  Not a peer yardstick under the cohort positioning; "agents can use
  Codemap AND fallow AND LSP" framing is honest about distinct slots.

- docs/research/fallow.md (closed historical) — body preserved per
  PR #61.

- docs/research/competitive-scan-2026-04.md (closed historical scan).

- .agents/lessons.md:16 — "Never commit absolute local user paths"
  lesson with PR #58 historical context referencing the fallow clone
  path. Historical record; preserve.

- .agents/skills/audit-pr-architecture/SKILL.md (5 mentions) —
  recommends `bunx fallow audit` as a static-analysis TOOL during
  PR audits. Different-product-class tool recommendation, not
  positioning. Borderline; left alone for now (could be genericized
  later as a separate concern).

Net effect: every remaining `[Ff]allow` reference in the repo is
either historical (closed research, lessons) or a different-product-
class acknowledgement (consumer comparison table, static-analysis
tool usage). Zero peer-yardstick framing remains in the load-bearing
positioning surfaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant