CNTRLPLANE-3947: feat(oauth-apiserver): pass release image and auth to verify step

[jubittajohn]

Summary by CodeRabbit

Updates the OpenShift CI verification setup for oauth-apiserver to improve reliability and consistency across master and supported release streams by:

• Mounting the ci-pull-credentials secret into the verify job and configuring REGISTRY_AUTH_FILE to use the mounted .dockerconfigjson for authenticated pulls.
• Introducing an oauth-apiserver-bin-with-oc helper image (built by copying the oc binary) and switching the verify execution to run inside that image.
• Running the verify test step on the openshift-org-gcp cluster profile with explicit resource requests.
• Skipping verify when changes are limited to docs/and common repo metadata paths via skip_if_only_changed.
• Standardizing the verification command to set OPENSHIFT_RELEASE (defaulting from RELEASE_IMAGE_LATEST) and run make verify -k --warn-undefined-variables.

[coderabbitai]

Walkthrough

OpenShift OAuth apiserver CI configurations now set the release environment and mount registry pull credentials. Release 4.23, 5.0, and 5.1 pipelines also build an image containing oc and use structured verification steps with updated filtering and resources.

Changes

OAuth apiserver CI verification

Layer / File(s)	Summary
Verification environment and credentials ci-operator/config/openshift/oauth-apiserver/openshift-oauth-apiserver-{master,release-4.22}.yaml	Verification sets OPENSHIFT_RELEASE, mounts ci-pull-credentials, and configures REGISTRY_AUTH_FILE.
Verification image with oc ci-operator/config/openshift/oauth-apiserver/openshift-oauth-apiserver-release-{4.23,5.0,5.1}.yaml	Release pipelines define cli base images and build oauth-apiserver-bin-with-oc by copying oc into /usr/bin/oc.
Structured release verification ci-operator/config/openshift/oauth-apiserver/openshift-oauth-apiserver-release-{4.23,5.0,5.1}.yaml	Verification uses structured steps, change filters, the openshift-org-gcp cluster profile, the new image, mounted credentials, updated commands, and explicit CPU and memory requests.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• openshift/release#82636: Updates related OpenShift CI verification steps with the same ci-pull-credentials secret mount.

Suggested reviewers: atiratree, kaleemsiddiqu

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Changed files are CI/job YAML only; no Ginkgo It/Describe/Context/When titles or dynamic title construction were added.
Test Structure And Quality	✅ Passed	PR only changes CI operator YAML and generated presubmit configs; no Ginkgo test code or assertions were modified.
Microshift Test Compatibility	✅ Passed	PR only changes ci-operator YAML/job config; no new Ginkgo tests or test bodies were added to evaluate for MicroShift issues.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only changes ci-operator/job YAML; no new Ginkgo/e2e test code was added, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only CI config/job YAML changed; no deployment manifests, controllers, replicas, affinity, selectors, or spread constraints were introduced.
Ote Binary Stdout Contract	✅ Passed	PR only changes CI YAML configs; no binary/runtime code or stdout-writing process setup was modified.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The PR only changes ci-operator YAML for verify jobs; no Go/Ginkgo tests or IPv4/public-internet assumptions were added.
No-Weak-Crypto	✅ Passed	PR only updates CI YAML for verify-step credentials/oc; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons found.
Container-Privileges	✅ Passed	Touched oauth-apiserver CI YAMLs add credentials/oc wiring only; no privileged, hostPID/Network/IPC, allowPrivilegeEscalation, or securityContext fields found.
No-Sensitive-Data-In-Logs	✅ Passed	Changed configs only mount ci-pull-credentials and set REGISTRY_AUTH_FILE; no added echo/printenv/set -x or secret-content logging.
Title check	✅ Passed	The title accurately summarizes the main verify-step change: passing release image input and adding auth for the oauth-apiserver CI jobs.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jubittajohn
Once this PR has been reviewed and has the lgtm label, please assign p0lyn0mial for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/oauth-apiserver/OWNERS
• ci-operator/jobs/openshift/oauth-apiserver/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jubittajohn]

/pj-rehearse pull-ci-openshift-oauth-apiserver-master-verify

[openshift-merge-bot]

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jubittajohn]

/pj-rehearse pull-ci-openshift-oauth-apiserver-release-5.0-verify

[openshift-merge-bot]

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jubittajohn]

/pj-rehearse pull-ci-openshift-oauth-apiserver-release-5.0-images

[openshift-merge-bot]

@jubittajohn: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

[openshift-ci-robot]

@jubittajohn: This pull request references CNTRLPLANE-3947 which is a valid jira issue.

Details

In response to this:

Summary by CodeRabbit

Updates the OpenShift CI verification setup for oauth-apiserver to be more reliable and consistent across master and supported release streams by:

• Mounting ci-pull-credentials into the verify jobs (and setting REGISTRY_AUTH_FILE) so the verification step can authenticate when pulling required images/artifacts.
• Adding an oauth-apiserver-bin-with-oc helper image that bundles the oc binary into the verification environment, then switching verify to run from that image.
• Running verification against the openshift-org-gcp cluster profile, with explicit CPU/memory resource requests.
• Skipping verify when changes are limited to docs/metadata/ownership/license-related paths via skip_if_only_changed.
• Standardizing the verification command usage (e.g., make verify with failure-tolerant behavior where configured, such as make verify -k, and including additional flags in the 5.0 stream).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@jubittajohn: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-oauth-apiserver-release-4.23-verify	openshift/oauth-apiserver	presubmit	Presubmit changed
pull-ci-openshift-oauth-apiserver-release-5.0-verify	openshift/oauth-apiserver	presubmit	Presubmit changed
pull-ci-openshift-oauth-apiserver-release-5.1-verify	openshift/oauth-apiserver	presubmit	Presubmit changed
pull-ci-openshift-oauth-apiserver-release-5.1-e2e-aws	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-5.1-e2e-aws-serial	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-5.1-e2e-aws-upgrade	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-5.1-e2e-component	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-5.1-e2e-gcp-component-serial-disruptive-ote	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-5.1-e2e-gcp-component-serial-ote	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-5.1-images	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-5.1-unit	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-5.1-verify-deps	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-4.23-e2e-aws	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-4.23-e2e-aws-serial	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-4.23-e2e-aws-upgrade	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-4.23-e2e-component	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-4.23-e2e-gcp-component-serial-disruptive-ote	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-4.23-e2e-gcp-component-serial-ote	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-4.23-images	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-4.23-unit	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-4.23-verify-deps	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-4.22-verify	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-master-verify	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-5.0-e2e-aws	openshift/oauth-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-oauth-apiserver-release-5.0-e2e-aws-serial	openshift/oauth-apiserver	presubmit	Ci-operator config changed

A total of 32 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@jubittajohn: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jubittajohn]

/pj-rehearse

[openshift-merge-bot]

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.