OCPBUGS-85429: feat(openshift-apiserver): mount ci-pull-credentials in verify step

[jubittajohn]

To have openshift/openshift-apiserver#666 pass the update verify ci job.

The verify-openapi-spec check pulls binaries from the CI release image on the build farm registry. The cluster profile pull secret only covers external registries (quay.io, registry.redhat.io), not CI-internal registries like registry.build02.ci.openshift.org

Summary by CodeRabbit

Updates OpenShift apiserver CI verification jobs for main and release branches (4.22, 4.23, 5.0, 5.1) to mount the ci-pull-credentials secret at /secrets/ci-pull-credentials and set REGISTRY_AUTH_FILE to the mounted .dockerconfigjson, enabling verify-openapi-spec to pull required binaries from CI release images hosted on build-farm registries (not covered by the cluster profile pull secret).

[openshift-ci-robot]

@jubittajohn: This pull request references Jira Issue OCPBUGS-85429, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

To have openshift/openshift-apiserver#666 pass the update verify ci job.

The verify-openapi-spec check pulls binaries from the CI release image on the build farm registry. The cluster profile pull secret only covers external registries (quay.io, registry.redhat.io), not CI-internal registries like registry.build02.ci.openshift.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 371dde20-a04b-4550-99b2-0577bce0ae29

📥 Commits

Reviewing files that changed from the base of the PR and between 90114de and 7c320c4.

📒 Files selected for processing (5)

• ci-operator/config/openshift/openshift-apiserver/openshift-openshift-apiserver-main.yaml
• ci-operator/config/openshift/openshift-apiserver/openshift-openshift-apiserver-release-4.22.yaml
• ci-operator/config/openshift/openshift-apiserver/openshift-openshift-apiserver-release-4.23.yaml
• ci-operator/config/openshift/openshift-apiserver/openshift-openshift-apiserver-release-5.0.yaml
• ci-operator/config/openshift/openshift-apiserver/openshift-openshift-apiserver-release-5.1.yaml

🚧 Files skipped from review as they are similar to previous changes (4)

• ci-operator/config/openshift/openshift-apiserver/openshift-openshift-apiserver-release-4.22.yaml
• ci-operator/config/openshift/openshift-apiserver/openshift-openshift-apiserver-release-5.0.yaml
• ci-operator/config/openshift/openshift-apiserver/openshift-openshift-apiserver-release-5.1.yaml
• ci-operator/config/openshift/openshift-apiserver/openshift-openshift-apiserver-main.yaml

---

Walkthrough

The OpenShift apiserver CI configurations for main and releases 4.22, 4.23, 5.0, and 5.1 update each verify step with the ci-pull-credentials secret mount and its Docker authentication file path.

Changes

Apiserver CI credential configuration

Layer / File(s)	Summary
Configure verify credential access ci-operator/config/openshift/openshift-apiserver/openshift-openshift-apiserver-*.yaml	Each verify step mounts the ci-pull-credentials secret from the ci namespace at /secrets/ci-pull-credentials and sets REGISTRY_AUTH_FILE to the mounted .dockerconfigjson path.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• openshift/release#82639: Updates corresponding apiserver verify steps with the same registry credential mount.

Suggested reviewers: everettraven, p0lyn0mial

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: mounting ci-pull-credentials in the openshift-apiserver verify step.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: Changes are ci-operator YAML only; no Ginkgo test titles changed, and the only names added are static step labels like verify.
Test Structure And Quality	✅ Passed	Only ci-operator YAML configs changed; no Ginkgo test code or It blocks were modified, so the test-structure checks don't apply.
Microshift Test Compatibility	✅ Passed	Only ci-operator YAML changed; no new Ginkgo tests or MicroShift-sensitive APIs/features were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only updates ci-operator YAML credentials for verify jobs; no Ginkgo/e2e test code was added or changed, so SNO compatibility is not implicated.
Topology-Aware Scheduling Compatibility	✅ Passed	Only ci-operator verify-job YAML changed to add registry credentials; no workload manifests, controllers, or topology-sensitive scheduling fields were modified.
Ote Binary Stdout Contract	✅ Passed	Only ci-operator YAML was changed; no main/init/TestMain/suite code or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only CI YAML changed; no new or modified Ginkgo tests, so the IPv6/disconnected-network check is not applicable.
No-Weak-Crypto	✅ Passed	Changed CI YAMLs only add ci-pull-credentials mounts and REGISTRY_AUTH_FILE; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto code appears.
Container-Privileges	✅ Passed	Only ci-pull-credentials mounts and REGISTRY_AUTH_FILE were added; no privileged, host*, capabilities, or allowPrivilegeEscalation fields were introduced.
No-Sensitive-Data-In-Logs	✅ Passed	Diff only adds ci-pull-credentials mount and REGISTRY_AUTH_FILE to verify steps; no new log/echo/debug output or secret values are introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jubittajohn
Once this PR has been reviewed and has the lgtm label, please assign atiratree for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/openshift-apiserver/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jubittajohn]

/pj-rehearse pull-ci-openshift-openshift-apiserver-main-verify

[openshift-merge-bot]

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

@jubittajohn: job(s): pull-ci-openshift-openshift-apiserver-5.0-verify either don't exist or were not found to be affected, and cannot be rehearsed

[openshift-merge-bot]

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

@jubittajohn: job(s): pull-ci-openshift-openshift-apiserver-4.23-verify either don't exist or were not found to be affected, and cannot be rehearsed

[openshift-merge-bot]

@jubittajohn: job(s): pull-ci-openshift-openshift-apiserver-4.22-verify either don't exist or were not found to be affected, and cannot be rehearsed

[jubittajohn]

/pj-rehearse pull-ci-openshift-openshift-apiserver-release-5.0-verify

[openshift-merge-bot]

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jubittajohn]

/pj-rehearse pull-ci-openshift-openshift-apiserver-release-4.22-verify

[jubittajohn]

/pj-rehearse pull-ci-openshift-openshift-apiserver-release-4.23-verify

[openshift-merge-bot]

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@jubittajohn: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-openshift-apiserver-release-4.23-verify	openshift/openshift-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-openshift-apiserver-release-4.22-verify	openshift/openshift-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-openshift-apiserver-release-5.0-verify	openshift/openshift-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-openshift-apiserver-release-5.1-verify	openshift/openshift-apiserver	presubmit	Ci-operator config changed
pull-ci-openshift-openshift-apiserver-main-verify	openshift/openshift-apiserver	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[jubittajohn]

/pj-rehearse pull-ci-openshift-openshift-apiserver-main-verify

[openshift-merge-bot]

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jubittajohn]

/retest

[openshift-ci]

@jubittajohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ci-operator-config-metadata	7c320c4	link	true	/test ci-operator-config-metadata

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.