ROSAENG-60066: Add splunk-forwarder-operator Prow e2e tests - #82617
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@dustman9000: This pull request references ROSAENG-60066 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe Splunk Forwarder operator CI configuration adds operator image builds, targets the OCP 4.22 CI release, enables optional PKO namespace configuration, and introduces ROSA e2e and scheduled promotion Prow jobs. ROSA e2e steps also export the shared cluster ID when available. ChangesSplunk Forwarder ROSA CI
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant ProwJob
participant rosa_cluster_lease_e2e_workflow
participant ROSACluster
participant OperatorInstall
participant ClusterPackage
ProwJob->>rosa_cluster_lease_e2e_workflow: Start with operator images and lease environment
rosa_cluster_lease_e2e_workflow->>ROSACluster: Acquire ROSA cluster lease
rosa_cluster_lease_e2e_workflow->>OperatorInstall: Run operator installation
OperatorInstall->>ClusterPackage: Apply image and optional namespace configuration
rosa_cluster_lease_e2e_workflow->>ProwJob: Report e2e or promotion result
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@dustman9000: |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse pull-ci-openshift-splunk-forwarder-operator-master-rosa-sts-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-splunk-forwarder-operator-master-rosa-sts-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/pj-rehearse pull-ci-openshift-splunk-forwarder-operator-master-rosa-sts-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-splunk-forwarder-operator-master-rosa-sts-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
607cf7b to
915e7a7
Compare
openshift-merge-bot
Bot
removed
the
rehearsals-ack
|
/pj-rehearse pull-ci-openshift-splunk-forwarder-operator-master-rosa-sts-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
915e7a7 to
11b02ac
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/rosa/operator/install/rosa-operator-install-commands.sh`:
- Around line 198-202: Validate PKO_CONFIG_NAMESPACE before appending it in the
PKO_CONFIG construction block: reject values that do not match the Kubernetes
namespace syntax or exceed 63 characters, including newline-containing values,
and ensure invalid input fails before it can modify the ClusterPackage manifest.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 29a3ab45-e1fc-48fa-89b9-fd1aaa1cd93c
⛔ Files ignored due to path filters (3)
ci-operator/jobs/openshift/splunk-forwarder-operator/openshift-splunk-forwarder-operator-master-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/splunk-forwarder-operator/openshift-splunk-forwarder-operator-master-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/splunk-forwarder-operator/openshift-splunk-forwarder-operator-master-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (3)
ci-operator/config/openshift/splunk-forwarder-operator/openshift-splunk-forwarder-operator-master.yamlci-operator/step-registry/rosa/operator/install/rosa-operator-install-commands.shci-operator/step-registry/rosa/operator/install/rosa-operator-install-ref.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- ci-operator/config/openshift/splunk-forwarder-operator/openshift-splunk-forwarder-operator-master.yaml
|
/pj-rehearse pull-ci-openshift-splunk-forwarder-operator-master-rosa-sts-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
11b02ac to
ad82fcb
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/step-registry/rosa/operator/e2e/rosa-operator-e2e-commands.sh`:
- Line 20: Update the OCM_CLUSTER_ID initialization to read the cluster-id file
into the variable first, preserving the read command’s failure status, then
export OCM_CLUSTER_ID in a separate command so failed reads are not masked
before the e2e binary runs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 0c033714-dda7-485e-a04a-6ba69ba47601
⛔ Files ignored due to path filters (3)
ci-operator/jobs/openshift/splunk-forwarder-operator/openshift-splunk-forwarder-operator-master-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/splunk-forwarder-operator/openshift-splunk-forwarder-operator-master-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/splunk-forwarder-operator/openshift-splunk-forwarder-operator-master-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (4)
ci-operator/config/openshift/splunk-forwarder-operator/openshift-splunk-forwarder-operator-master.yamlci-operator/step-registry/rosa/operator/e2e/rosa-operator-e2e-commands.shci-operator/step-registry/rosa/operator/install/rosa-operator-install-commands.shci-operator/step-registry/rosa/operator/install/rosa-operator-install-ref.yaml
🚧 Files skipped from review as they are similar to previous changes (3)
- ci-operator/step-registry/rosa/operator/install/rosa-operator-install-ref.yaml
- ci-operator/config/openshift/splunk-forwarder-operator/openshift-splunk-forwarder-operator-master.yaml
- ci-operator/step-registry/rosa/operator/install/rosa-operator-install-commands.sh
ad82fcb to
1c171b3
Compare
|
/pj-rehearse pull-ci-openshift-splunk-forwarder-operator-master-rosa-sts-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
b50c3b2 to
ffa138f
Compare
Add rosa-sts-e2e presubmit and promotion-int/stage periodic jobs for splunk-forwarder-operator. Add PKO_CONFIG_NAMESPACE env var to the install step for operators whose PKO manifest uses config.namespace. Add OCM_CLUSTER_ID env var passthrough in e2e ref for operators that need it in test assertions.
ffa138f to
1b5aa24
Compare
|
/pj-rehearse pull-ci-openshift-splunk-forwarder-operator-master-rosa-sts-e2e |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse ack |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bmeng, dustman9000 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dustman9000: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Summary
Jira: https://redhat.atlassian.net/browse/ROSAENG-60066
Test plan
Summary by CodeRabbit
Updated the OpenShift CI infrastructure for
splunk-forwarder-operatorto add ROSA end-to-end coverage using the sharedrosa-cluster-lease-e2e-workflow, including both presubmit validation and post-merge promotion runs.ci-operator/config/openshift/splunk-forwarder-operator/openshift-splunk-forwarder-operator-master.yamlto:base_images.rosa-aws-cli(ci/rosa-aws-cli:latest) and setreleases.latest.candidatetoproduct: ocp,stream: ci,version: "4.22".operator-pkobuilt viaFROM scratch, copyingdeploy_pko/into/package/.operator-e2ethat builds the e2e binary fromtest/e2eusinggo test(into/usr/local/bin/e2e.test).cluster_profile: rosa-e2e-01, and wired toOPERATOR_IMAGE+OPERATOR_PKO_IMAGEplus operator/PKO env configuration) that run the shared e2e workflow:rosa-sts-e2e(presubmit)rosa-sts-e2e-promotion-int(cron;LEASE_ENV: integration)rosa-sts-e2e-promotion-stage(cron;LEASE_ENV: staging)OPERATOR_WAIT_DEPLOYMENTSsince SFO creates DaemonSets rather than secondary Deployments.config.namespace:PKO_CONFIG_NAMESPACEtoci-operator/step-registry/rosa/operator/install/rosa-operator-install-ref.yaml.rosa-operator-install-commands.shto generateClusterPackage.spec.configdynamically (optionally injectingnamespaceviaPKO_CONFIG).rosa-operator-e2e-commands.shnow readsSHARED_DIR/cluster-id(when present) and exports it asOCM_CLUSTER_ID.The CI plan was rehearsed with
pj-rehearse, and includes a Gangway-triggeredpromotion-intrun after merge.