Skip to content

ROSAENG-1332: Add OSD GCP e2e tests for SRE operators - #82649

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
dustman9000:feat/osd-gcp-e2e
Jul 30, 2026
Merged

ROSAENG-1332: Add OSD GCP e2e tests for SRE operators#82649
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
dustman9000:feat/osd-gcp-e2e

Conversation

@dustman9000

@dustman9000 dustman9000 commented Jul 29, 2026

Copy link
Copy Markdown
Member

Summary

  • Add rosa-gcp-e2e presubmit and promotion-int/stage periodic jobs for RMO, CAMO, MUO, OAO, and SFO
  • Uses the same rosa-cluster-lease e2e workflow with LEASE_TYPE=osd-gcp to target the GCP cluster pool
  • GCP lease clusters are provisioned and available (gcp-lease-int-01/02, gcp-lease-staging-01/02)

Jira: https://redhat.atlassian.net/browse/ROSAENG-1332

Test plan

  • pj-rehearse passes for at least one operator GCP e2e job
  • Gangway trigger of a GCP promotion-int job succeeds after merge

Summary by CodeRabbit

Adds GCP-based ROSA CI coverage for five operators—Configure Alertmanager, Managed Upgrade, OCM Agent, Route Monitor, and Splunk Forwarder—by introducing new cluster-lease OSD GCP end-to-end presubmit jobs plus scheduled post-merge promotion jobs. The new jobs reuse the existing rosa-cluster-lease-e2e-workflow with LEASE_TYPE=osd-gcp, set LEASE_ENV to staging for E2E, and schedule promotion runs for integration and staging (cron 0 0 31 2 *) after merge. Promotion jobs report success/failure/error to #rosa-prow-info with templated log links. CI config changes are reflected both in the operator ci-operator/config/...-master.yaml files and the generated ci-operator/jobs/...-master-{presubmits,periodics}.yaml job definitions.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 29, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@dustman9000: This pull request references ROSAENG-1332 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Add rosa-gcp-e2e presubmit and promotion-int/stage periodic jobs for RMO, CAMO, MUO, OAO, and SFO
  • Uses the same rosa-cluster-lease e2e workflow with LEASE_TYPE=osd-gcp to target the GCP cluster pool
  • GCP lease clusters are provisioned and available (gcp-lease-int-01/02, gcp-lease-staging-01/02)

Jira: https://redhat.atlassian.net/browse/ROSAENG-1332

Test plan

  • pj-rehearse passes for at least one operator GCP e2e job
  • Gangway trigger of a GCP promotion-int job succeeds after merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 71243c44-7f1d-4791-9e10-3930c2873bbe

📥 Commits

Reviewing files that changed from the base of the PR and between 8c18613 and e62d920.

⛔ Files ignored due to path filters (10)
  • ci-operator/jobs/openshift/configure-alertmanager-operator/openshift-configure-alertmanager-operator-master-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/configure-alertmanager-operator/openshift-configure-alertmanager-operator-master-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/managed-upgrade-operator/openshift-managed-upgrade-operator-master-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/managed-upgrade-operator/openshift-managed-upgrade-operator-master-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/ocm-agent-operator/openshift-ocm-agent-operator-master-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/ocm-agent-operator/openshift-ocm-agent-operator-master-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/route-monitor-operator/openshift-route-monitor-operator-master-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/route-monitor-operator/openshift-route-monitor-operator-master-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/splunk-forwarder-operator/openshift-splunk-forwarder-operator-master-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/splunk-forwarder-operator/openshift-splunk-forwarder-operator-master-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (5)
  • ci-operator/config/openshift/configure-alertmanager-operator/openshift-configure-alertmanager-operator-master.yaml
  • ci-operator/config/openshift/managed-upgrade-operator/openshift-managed-upgrade-operator-master.yaml
  • ci-operator/config/openshift/ocm-agent-operator/openshift-ocm-agent-operator-master.yaml
  • ci-operator/config/openshift/route-monitor-operator/openshift-route-monitor-operator-master.yaml
  • ci-operator/config/openshift/splunk-forwarder-operator/openshift-splunk-forwarder-operator-master.yaml

Walkthrough

Five OpenShift CI configurations add GCP-based ROSA E2E jobs and scheduled integration/staging promotion jobs. The jobs use the shared cluster lease workflow, osd-gcp leases, existing operator dependencies, and Prow reporting for promotions.

Changes

GCP ROSA lease tests

Layer / File(s) Summary
Base GCP E2E jobs
ci-operator/config/openshift/*/*-master.yaml
Adds non-scheduled osd-gcp-e2e jobs using rosa-cluster-lease-e2e-workflow, osd-gcp leases, cluster profiles, and operator-specific image and environment wiring.
Scheduled promotion jobs
ci-operator/config/openshift/*/*-master.yaml
Adds integration and staging promotion jobs with the shared workflow, cron scheduling, environment-specific lease settings, and #rosa-prow-info success/failure/error reporting.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related PRs

Suggested reviewers: bmeng, anispate, petr-muller

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding OSD GCP e2e tests for SRE operators.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The PR only adds static ci-operator job aliases in YAML; no Ginkgo It/Describe/Context titles or dynamic test-name strings were introduced.
Test Structure And Quality ✅ Passed PR only changes ci-operator YAML job configs; no Go/Ginkgo test files or test logic were added, so this checklist is not applicable.
Microshift Test Compatibility ✅ Passed PR only adds ci-operator job configs for existing workflows; no new Ginkgo test code or APIs/features to assess for MicroShift.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only ci-operator/job YAMLs changed; no new Ginkgo test bodies or SNO-sensitive patterns were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator job/config YAML was added; no deployment manifests, controllers, or topology-sensitive scheduling constraints were introduced.
Ote Binary Stdout Contract ✅ Passed PR only adds/updates ci-operator YAML jobs; no main/init/TestMain or stdout-writing code was changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only CI job configs changed; no new Ginkgo e2e test code or network logic was added to inspect.
No-Weak-Crypto ✅ Passed PR only adds CI YAML jobs; exact weak-crypto and constant-time search in changed files found no matches.
Container-Privileges ✅ Passed No touched manifest/config file adds privileged, hostPID/Network/IPC, allowPrivilegeEscalation, SYS_ADMIN, or root-related security settings.
No-Sensitive-Data-In-Logs ✅ Passed The added CI jobs only set non-secret lease/env values and a generic status URL reporter; no passwords, tokens, PII, or host/customer data appear.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from anispate and bmeng July 29, 2026 23:57
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2026
Add osd-gcp-e2e presubmit and promotion-int/stage periodic jobs for
RMO, CAMO, MUO, OAO, and SFO. Identical to STS e2e configs but with
LEASE_TYPE=osd-gcp to target the GCP cluster pool.
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@dustman9000: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-splunk-forwarder-operator-master-osd-gcp-e2e openshift/splunk-forwarder-operator presubmit Presubmit changed
pull-ci-openshift-ocm-agent-operator-master-osd-gcp-e2e openshift/ocm-agent-operator presubmit Presubmit changed
pull-ci-openshift-configure-alertmanager-operator-master-osd-gcp-e2e openshift/configure-alertmanager-operator presubmit Presubmit changed
pull-ci-openshift-managed-upgrade-operator-master-osd-gcp-e2e openshift/managed-upgrade-operator presubmit Presubmit changed
pull-ci-openshift-route-monitor-operator-master-osd-gcp-e2e openshift/route-monitor-operator presubmit Presubmit changed
periodic-ci-openshift-managed-upgrade-operator-master-osd-gcp-e2e-promotion-int N/A periodic Periodic changed
periodic-ci-openshift-splunk-forwarder-operator-master-osd-gcp-e2e-promotion-int N/A periodic Periodic changed
periodic-ci-openshift-route-monitor-operator-master-osd-gcp-e2e-promotion-int N/A periodic Periodic changed
periodic-ci-openshift-splunk-forwarder-operator-master-osd-gcp-e2e-promotion-stage N/A periodic Periodic changed
periodic-ci-openshift-ocm-agent-operator-master-osd-gcp-e2e-promotion-int N/A periodic Periodic changed
periodic-ci-openshift-managed-upgrade-operator-master-osd-gcp-e2e-promotion-stage N/A periodic Periodic changed
periodic-ci-openshift-configure-alertmanager-operator-master-osd-gcp-e2e-promotion-int N/A periodic Periodic changed
periodic-ci-openshift-route-monitor-operator-master-osd-gcp-e2e-promotion-stage N/A periodic Periodic changed
periodic-ci-openshift-ocm-agent-operator-master-osd-gcp-e2e-promotion-stage N/A periodic Periodic changed
periodic-ci-openshift-configure-alertmanager-operator-master-osd-gcp-e2e-promotion-stage N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dustman9000

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-route-monitor-operator-master-osd-gcp-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@dustman9000: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dustman9000

Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 30, 2026
@bmeng

bmeng commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2026
@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, dustman9000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 05adf7f into openshift:main Jul 30, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants