Skip to content

feat(webkit): roll to r2364 - #42748

Merged
Devin Rousso (dcrousso) merged 1 commit into
mainfrom
roll-into-pw-webkit/2364
Sep 17, 2026
Merged

Devin Rousso (dcrousso) merged 1 commit into
mainfrom
roll-into-pw-webkit/2364

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/74c2e315da1a80b4d75c9893ddff4fb5b47e2538. Build has full platform coverage - check that all tests pass there.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

3 failed
❌ [installation tests] › playwright-cdn.spec.ts:43 › playwright cdn failover should work (https://cdn.playwright.dev/dbazure/download/playwright) @package-installations-macos-latest
❌ [installation tests] › playwright-cdn.spec.ts:43 › playwright cdn failover should work (https://playwright.download.prss.microsoft.com/dbazure/download/playwright) @package-installations-macos-latest
❌ [firefox-library] › library/browsercontext-storage-state.spec.ts:453 › should work when service worker is intefering and the origin is not open @firefox-ubuntu-22.04-node20

11 flaky ⚠️ [installation tests] › playwright-cli.spec.ts:21 › cli should work `@package-installations-ubuntu-latest`
⚠️ [chromium-library] › library/video.spec.ts:664 › screencast › should capture full viewport `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:715 › should indicate current test status `@windows-latest-node22`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:827 › should update state on subsequent run `@windows-latest-node22`

51714 passed, 1247 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I triaged the failing CI tests on this PR.

🟢 Nothing here looks caused by this PR

All three failures are pre-existing and reproduce on other PRs. This is a WebKit roll, and none of the failures are WebKit — the WebKit projects are fully green in this run.

Details

The diff touches browsers.json (WebKit revision) and the WebKit protocol.d.ts. That reaches WebKit only, and every webkit-* project passed. The two failing areas — CDN download on macOS installation tests, and a Firefox service-worker cookie assertion — have no path to the rolled WebKit build.

Pre-existing flake / infra

  • [installation tests] › playwright-cdn.spec.ts:43 › playwright cdn failover should work (…/dbazure/download/playwright) (both CDN variants) @package-installations-macos-latest — CDN/infra, not this PR. npx playwright install exits 1 partway through downloading Chrome for Testing (~182 MiB) from cdn.playwright.dev. Across the CI results db this test is 3 failures in 637 runs, and the other failures are on unrelated PRs feat(webkit): roll to r2362 #42736 (sha 83e739fd) and feat(webkit): roll to r2363 #42737 (sha 5b7b5474) within the last day. The non-failover variant (https://cdn.playwright.dev) is 637/637 green, so this is download flakiness against the dbazure mirror path, not a code change.

  • [firefox-library] › library/browsercontext-storage-state.spec.ts:453 › should work when service worker is intefering and the origin is not open @firefox-ubuntu-22.04-node20 — broken on Firefox already, for about a week. It has failed 51 of 52 runs since 2026-09-10, spanning 20 different PRs. Same on moz-firefox-nightly-library (3/3 failed). Chromium and WebKit pass it 53/53 and 52/52. The failure is a stable assertion mismatch, not a timeout: an extra fromServiceWorker=yes cookie shows up in the storage state under Firefox.

    - Expected  - 0
    + Received  + 4
      Array [
        Object { "name": "foo", "value": "bar" },
    +   Object { "name": "fromServiceWorker", "value": "yes" },
      ]
    

    Worth a separate look as a genuine Firefox bug, but it's orthogonal to this roll.

The 11 flaky tests in the report are all Chromium/Firefox/playwright-test and were rescued on retry.

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [chrome] › mcp/annotate.spec.ts:446 › should switch screencast to -s session on show --annotate @mcp-windows-latest-chrome

8563 passed, 1446 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I triaged the failing CI tests on this PR.

🟢 The single MCP failure is a pre-existing flake

mcp/annotate.spec.ts:446 on @mcp-windows-latest-chrome fails with the same error on unrelated PRs. This is a WebKit roll, and it isn't a WebKit failure — every WebKit MCP project is green.

Details

The diff touches browsers.json (WebKit revision) and the WebKit protocol.d.ts. That reaches WebKit only. In this MCP run, mcp-ubuntu-latest-webkit, mcp-windows-latest-webkit and mcp-macos-latest-webkit all passed, and the one failure is on Chrome for Testing — which the rolled WebKit build can't reach.

Pre-existing flake / infra

  • [chrome] › mcp/annotate.spec.ts:446 › should switch screencast to -s session on show --annotate @mcp-windows-latest-chrome — Windows-only flake in the screencast session switch. Across the CI results db this test is 3 failures in 710 runs (0.4%) on this bot, and the same crash signature shows up on unrelated PRs: fix(chromium): bypass service workers on the storage state page #42664 (sha 68d238eb) on mcp-windows-latest-chrome, and fix(server): dispose temporary iframe element handles after hit-target checks #42655 (sha bee7b73f) on mcp-windows-latest-chromium. Identical error each time — an undefined CDP target while the test waits, then the 180s timeout:

    Error: Cannot read properties of undefined (reading 'endpoint')
    
    Call Log:
    - Test timeout of 180000ms exceeded
    

    It's confined to Windows Chromium-family bots — the same test is 717/717 green on mcp-ubuntu-latest-webkit, 721/721 on mcp-macos-latest-webkit, and 709/709 on mcp-macos-latest-chrome.

Separately, the same file flakes much harder on mcp-windows-latest-firefox (77 failures in 694 runs, a stable toHaveAccessibleName mismatch of "Session first" vs "Session second") — also unrelated to this roll, but worth a look on its own.

The earlier tests 1 report on this PR was triaged green too, so nothing across the run points at the roll.

Triaged by the Playwright bot - agent run

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

3 fatal errors, not part of any test
4 failed
❌ [firefox-library] › library/browsercontext-storage-state.spec.ts:453 › should work when service worker is intefering and the origin is not open @tracing-firefox
❌ [firefox-library] › library/browsercontext-storage-state.spec.ts:453 › should work when service worker is intefering and the origin is not open @firefox-macos-15-large
❌ [firefox-library] › library/browsercontext-storage-state.spec.ts:453 › should work when service worker is intefering and the origin is not open @firefox-windows-latest
❌ [firefox-library] › library/browsercontext-storage-state.spec.ts:453 › should work when service worker is intefering and the origin is not open @firefox-macos-15-xlarge

34 flaky ⚠️ [chromium-page] › page/page-screenshot.spec.ts:504 › page screenshot › should take fullPage screenshots during navigation `@tracing-chromium`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:327 › should report all pages in an existing browser `@msedge-dev-windows-latest`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1915 › should not leak recorders `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/beforeunload.spec.ts:20 › should close browser with beforeunload page `@chrome-windows-latest`
⚠️ [chromium-library] › library/browser.spec.ts:54 › should dispatch page.on(close) upon browser.close and reject evaluate `@chrome-windows-latest`
⚠️ [chromium-library] › library/client-certificates.spec.ts:878 › browser › support http2 if the browser only supports http1.1 `@chrome-windows-latest`
⚠️ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:28 › context.cookies() should work Radoslav Kirilov (@smoke) `@chrome-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:179 › serviceWorker(), and fromServiceWorker() work `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:75 › selector generator › should generate text for `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:288 › selector generator › should use internal:has-text `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:315 › selector generator › should chain text after parent `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:546 › selector generator › should ignore empty aria-label for candidate consideration `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:693 › selector generator › should generate noText: ignore aria-labelledby pointing inside the element `@chrome-macos-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@tracing-firefox`
⚠️ [firefox-page] › page/page-goto.spec.ts:90 › should work with Cross-Origin-Opener-Policy `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:202 › should not print context options method override in nunit if no options were passed `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-javascript.spec.ts:104 › should save the codegen output to a file if specified `@firefox-macos-15-large`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1915 › should not leak recorders `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-windows-latest`
⚠️ [firefox-library] › library/proxy.spec.ts:288 › should bypass proxy for 127.0.0.1 when 127.0.0.1 is in bypass list `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/video.spec.ts:294 › screencast › should capture navigation `@firefox-macos-15-xlarge`
⚠️ [webkit-page] › page/page-network-request.spec.ts:288 › should parse the data if content-type is application/x-www-form-urlencoded `@tracing-webkit`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:121 › should show tracing.group in the action list with location `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:813 › launchServer › should upload a folder `@webkit-macos-15-large`
⚠️ [android-page] › page/page-autowaiting-no-hang.spec.ts:53 › calling window.open and window.close

111369 passed, 4739 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I triaged the failing CI tests on this PR.

🟢 Nothing here looks caused by this PR

All 4 failures are the same Firefox test, and it has been broken on Firefox for six days across 19 other PRs. This is a WebKit roll, and every WebKit project in this run is green.

Details

The diff touches browsers.json (WebKit revision) and the WebKit protocol.d.ts — that reaches the WebKit engine only. The one failing test fails exclusively on Firefox bots, on a code path the rolled WebKit build can't reach, and it was already failing before this PR existed.

Pre-existing flake / infra

  • [firefox-library] › library/browsercontext-storage-state.spec.ts:453 › should work when service worker is intefering and the origin is not open — on @tracing-firefox, @firefox-macos-15-large, @firefox-macos-15-xlarge, @firefox-windows-latest. Grouping the four bots as one story: this is a stable Firefox breakage, not a flake in the usual sense. Across the CI results db it has failed 102 of 103 runs since 2026-09-10, spanning 19 distinct PRs and 34 SHAs (#42421 through this one), and it also fails 3/3 on moz-firefox-nightly-library and 2/2 on bidi-chromium-library. The same test is 421/421 green on Chromium and 102/102 green on WebKit over the same window.

    The failure is a deterministic assertion mismatch rather than a timeout — an extra service-worker cookie leaks into the storage state under Firefox:

    - Expected  - 0
    + Received  + 4
      Array [
        Object { "name": "foo", "value": "bar" },
    +   Object { "name": "fromServiceWorker", "value": "yes" },
      ]
    

    It looks like a genuine Firefox-side bug and deserves its own issue, but it predates this roll by six days and is orthogonal to it.

  • 3 fatal errors, not part of any test — no job in the run actually failed, and the same "fatal errors, not part of any test" line shows up on unrelated PRs (e.g. feat(webkit): roll to r2363 #42737). Reads as worker/teardown noise, not a signal from this diff.

The 34 flaky tests were all rescued on retry, and the WebKit ones among them (page-network-request.spec.ts:288, trace-viewer.spec.ts:121, browsertype-connect.spec.ts:813) are single-bot blips that pass on retry — nothing pointing at r2364.

Worth noting the earlier tests 1 and MCP reports on this PR were triaged green too, so the whole run is clear.

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant