Skip to content

feat(chromium): roll to r1246 - #42757

Merged
Devin Rousso (dcrousso) merged 1 commit into
mainfrom
roll-into-pw-chromium/1246
Sep 17, 2026
Merged

Devin Rousso (dcrousso) merged 1 commit into
mainfrom
roll-into-pw-chromium/1246

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/05a25ef993ff70d6f67609f7d94b0ac795f0f36b. Build has full platform coverage - check that all tests pass there.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

8577 passed, 1446 skipped


Merge workflow run.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

2 failed
❌ [installation tests] › playwright-cdn.spec.ts:43 › playwright cdn failover should work (https://cdn.playwright.dev/dbazure/download/playwright) @package-installations-macos-latest
❌ [installation tests] › playwright-cdn.spec.ts:43 › playwright cdn failover should work (https://playwright.download.prss.microsoft.com/dbazure/download/playwright) @package-installations-macos-latest

3 flaky ⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:173 › should work with Ctrl-clicking `@chromium-ubuntu-22.04-arm-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`

51937 passed, 1247 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 Not this PR — the CDN failover test is red on main too

Hi, I'm the Playwright bot and I triaged the red CI here.

Both failures are installation tests › playwright-cdn.spec.ts:43 › playwright cdn failover should work on package-installations-macos-latest. The roll is a red herring: Chromium r1246 downloads fine in the failing log — it's the WebKit v2364 download that never completes. Same failure on main SHAs that still carry r1245.

Details

Pre-existing / infra

  • [installation tests] › playwright-cdn.spec.ts:43 › playwright cdn failover should work (…cdn.playwright.dev… / …playwright.download.prss.microsoft.com…)npx playwright install exits 1. The stdio shows the roll's own artifacts landing without trouble:

    Chrome for Testing 154.0.8037.0 (playwright chromium v1246) downloaded to …/chromium-1246
    Chrome Headless Shell 154.0.8037.0 (playwright chromium-headless-shell v1246) downloaded to …
    Firefox 155.0 (playwright firefox v1548) downloaded to …
    Downloading WebKit 26.6 (playwright webkit v2364) from https://cdn.playwright.dev/…/webkit-mac-26-arm64.zip
    Downloading WebKit 26.6 (playwright webkit v2364) from https://playwright.download.prss.microsoft.com.does-not-resolve.playwright.dev/…
    

    The run dies on WebKit — a revision this PR doesn't touch — after the failover host (deliberately unresolvable, that's the point of the test) is tried. Byte-identical stdio on main, only with chromium v1245 in place of v1246.

    Same two tests failing where this PR can't be responsible:

    run branch / PR sha bot cdn tests failed
    35252615324 main 8bb2c097 macos-latest 2/7
    35252655560 main 8bb2c097 windows-latest 2/7
    35248755943 main 24b69326 ubuntu-latest 2/7
    35238682839 main bf9d04f2 windows-latest 2/7
    35252759302 feat(screencast): style action decorations, keep cursor visible #42758 379bc114 macos-latest 2/7
    35242918717 feat(video): allow recording video at a custom fps #42752 b0447581 windows-latest 2/7

    It's not macOS-specific either — it lands on whichever OS bot draws the short straw, which is the shape of a CDN/network problem rather than a code one. The last fully green stretch for this file is around f4244842 (09-16 23:16) and earlier.

Everything else

The 3 flaky results (Ctrl-click page event on Chromium, third-party Partitioned; cookies on Firefox) all passed on retry and are long-standing regulars; nothing there points at r1246.

The earlier "tests 2" report on this PR — all of library/coverage.spec.ts on the tracing-* bots — was triaged separately and is likewise pre-existing.

Verified against the aggregated CI results DB, topped up to include this PR's runs.

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

39 failed
❌ [chromium-library] › library/coverage.spec.ts:34 › should collect istanbul coverage into the trace @tracing-chromium
❌ [chromium-library] › library/coverage.spec.ts:55 › should collect coverage per trace chunk @tracing-chromium
❌ [chromium-library] › library/coverage.spec.ts:81 › should report maps once and counters incrementally @tracing-chromium
❌ [chromium-library] › library/coverage.spec.ts:109 › should accumulate counters across pulls and keep never hit files @tracing-chromium
❌ [chromium-library] › library/coverage.spec.ts:135 › should collect coverage of a page closed by in-page script @tracing-chromium
❌ [chromium-library] › library/coverage.spec.ts:157 › should not double count a stash picked up twice @tracing-chromium
❌ [chromium-library] › library/coverage.spec.ts:179 › should discard stashes of other sessions @tracing-chromium
❌ [chromium-library] › library/coverage.spec.ts:199 › should collect coverage of an origin left without a page @tracing-chromium
❌ [chromium-library] › library/coverage.spec.ts:229 › should pull counters as the actions go @tracing-chromium
❌ [chromium-library] › library/coverage.spec.ts:246 › should not collect coverage without the option @tracing-chromium
❌ [chromium-library] › library/coverage.spec.ts:259 › should count only the hits after start @tracing-chromium
❌ [chromium-library] › library/coverage.spec.ts:276 › should stop collecting when tracing stops @tracing-chromium
❌ [chromium-library] › library/coverage.spec.ts:293 › should surface a failure to stash the coverage @tracing-chromium
❌ [firefox-library] › library/coverage.spec.ts:34 › should collect istanbul coverage into the trace @tracing-firefox
❌ [firefox-library] › library/coverage.spec.ts:55 › should collect coverage per trace chunk @tracing-firefox
❌ [firefox-library] › library/coverage.spec.ts:81 › should report maps once and counters incrementally @tracing-firefox
❌ [firefox-library] › library/coverage.spec.ts:109 › should accumulate counters across pulls and keep never hit files @tracing-firefox
❌ [firefox-library] › library/coverage.spec.ts:135 › should collect coverage of a page closed by in-page script @tracing-firefox
❌ [firefox-library] › library/coverage.spec.ts:157 › should not double count a stash picked up twice @tracing-firefox
❌ [firefox-library] › library/coverage.spec.ts:179 › should discard stashes of other sessions @tracing-firefox
❌ [firefox-library] › library/coverage.spec.ts:199 › should collect coverage of an origin left without a page @tracing-firefox
❌ [firefox-library] › library/coverage.spec.ts:229 › should pull counters as the actions go @tracing-firefox
❌ [firefox-library] › library/coverage.spec.ts:246 › should not collect coverage without the option @tracing-firefox
❌ [firefox-library] › library/coverage.spec.ts:259 › should count only the hits after start @tracing-firefox
❌ [firefox-library] › library/coverage.spec.ts:276 › should stop collecting when tracing stops @tracing-firefox
❌ [firefox-library] › library/coverage.spec.ts:293 › should surface a failure to stash the coverage @tracing-firefox
❌ [webkit-library] › library/coverage.spec.ts:34 › should collect istanbul coverage into the trace @tracing-webkit
❌ [webkit-library] › library/coverage.spec.ts:55 › should collect coverage per trace chunk @tracing-webkit
❌ [webkit-library] › library/coverage.spec.ts:81 › should report maps once and counters incrementally @tracing-webkit
❌ [webkit-library] › library/coverage.spec.ts:109 › should accumulate counters across pulls and keep never hit files @tracing-webkit
❌ [webkit-library] › library/coverage.spec.ts:135 › should collect coverage of a page closed by in-page script @tracing-webkit
❌ [webkit-library] › library/coverage.spec.ts:157 › should not double count a stash picked up twice @tracing-webkit
❌ [webkit-library] › library/coverage.spec.ts:179 › should discard stashes of other sessions @tracing-webkit
❌ [webkit-library] › library/coverage.spec.ts:199 › should collect coverage of an origin left without a page @tracing-webkit
❌ [webkit-library] › library/coverage.spec.ts:229 › should pull counters as the actions go @tracing-webkit
❌ [webkit-library] › library/coverage.spec.ts:246 › should not collect coverage without the option @tracing-webkit
❌ [webkit-library] › library/coverage.spec.ts:259 › should count only the hits after start @tracing-webkit
❌ [webkit-library] › library/coverage.spec.ts:276 › should stop collecting when tracing stops @tracing-webkit
❌ [webkit-library] › library/coverage.spec.ts:293 › should surface a failure to stash the coverage @tracing-webkit

39 flaky ⚠️ [chromium-page] › page/workers.spec.ts:63 › should have timestamp on worker console messages `@msedge-dev-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chromium-macos-15-large`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:110 › selector generator › should use description from aria-describedby `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:165 › selector generator › should try to improve text by shortening `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:356 › selector generator › should use nested ordinals `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:422 › selector generator › should prioritize attributes correctly › role `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:467 › selector generator › should match in deep shadow dom `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:703 › selector generator › should generate noText: description from external aria-describedby `@chrome-macos-latest`
⚠️ [chromium-library] › library/selectors-register.spec.ts:29 › should work `@chrome-macos-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@tracing-firefox`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:208 › should print context options method override in xunit if options were passed `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-java.spec.ts:125 › should print a valid basic program in junit `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-javascript.spec.ts:51 › should work with --http-credentials `@firefox-macos-15-large`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1915 › should not leak recorders `@firefox-macos-15-large`
⚠️ [firefox-page] › page/page-goto.spec.ts:90 › should work with Cross-Origin-Opener-Policy `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-reuse.spec.ts:200 › reuse connect › should not cache resources `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1915 › should not leak recorders `@firefox-macos-15-xlarge`
⚠️ [webkit-library] › library/playwright-client.spec.ts:26 › should connect from a page and drive the same browser `@tracing-webkit`
⚠️ [webkit-page] › page/page-autowaiting-basic.spec.ts:79 › should await form-post on click `@tracing-webkit`
⚠️ [webkit-library] › library/defaultbrowsercontext-1.spec.ts:48 › context.addCookies() should work `@webkit-windows-latest`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1695 › should highlight locator in iframe while typing `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1987 › canvas disabled title `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1997 › canvas clipping `@webkit-macos-15-xlarge`
⚠️ [webkit-page] › page/page-screenshot.spec.ts:356 › page screenshot › should work for canvas `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:813 › launchServer › should upload a folder `@webkit-macos-15-large`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:288 › run-server › should send default User-Agent and X-Playwright-Browser headers with connect request `@webkit-macos-15-large`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1915 › should not leak recorders `@webkit-macos-15-large`
⚠️ [android-page] › page/page-wait-for-navigation.spec.ts:249 › should fail when frame detaches

111775 passed, 4739 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 Not this PR — coverage.spec.ts is red on main too

Hi, I'm the Playwright bot and I triaged the red CI here.

All 39 failures in the latest "tests 2" report are one story: every test in library/coverage.spec.ts fails on the three tracing-* bots with Error: tracing.start: Tracing has been already started. The same 39 failures land on main SHAs that predate this roll, and a Chromium binary bump can't explain identical failures under Firefox and WebKit.

Details

The diff is two lines in packages/playwright-core/browsers.jsonchromium and chromium-headless-shell from r1245 to r1246. No product code, so the blast radius is Chromium behaviour and browser download/install.

Pre-existing / infra

  • [chromium-library|firefox-library|webkit-library] › library/coverage.spec.ts — all 13 tests × 3 browsers, on tracing-chromium / tracing-firefox / tracing-webkit, every one with Error: tracing.start: Tracing has been already started. The tracing-* bots already start tracing for the run and these tests call context.tracing.start({ coverage: true }) themselves, so the file fails deterministically in that mode — not a flake, a missing guard.

    From the results DB (topped up to include this PR's runs), same file in "tests 2":

    run branch / PR sha failed / passed
    35252655589 main 8bb2c097 39 / 208
    35252615395 main 8bb2c097 39 / 221
    35248755916 main 24b69326 39 / 221
    35238682759 main bf9d04f2 (this PR's base) 39 / 221
    35195191888 main f1ea64bd 39 / 221
    35161427909 main f4244842 39 / 221
    35245460369 this PR 60621bc9 39 / 221

    The counterpart "tests 1" run on each of those SHAs — including this PR's 35245460423 — has the same file fully green (104 passed, 0 failed), which is what makes the red workflow-specific rather than change-specific.

Everything else

The 39 flaky results all passed on retry — third-party Partitioned; cookies on Firefox, trace-viewer canvas and screenshot on WebKit, service-worker interception and selector-generator on Chromium. The usual regulars; nothing there points at r1246.

The earlier "tests 1" report on this PR (playwright-cdn.spec.ts:43 › playwright cdn failover should work) is also not the roll — the failing log downloads chromium v1246 fine and dies on the WebKit v2364 fetch, and the same two tests are red on main at 8bb2c097, 24b69326 and bf9d04f2.

Report: tests 2 merge run 35261932458.

Triaged by the Playwright bot - agent run

@dcrousso
Devin Rousso (dcrousso) merged commit ad9c859 into main Sep 17, 2026
122 of 131 checks passed
@dcrousso
Devin Rousso (dcrousso) deleted the roll-into-pw-chromium/1246 branch September 17, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant