Skip to content

test: fix click tests on android - #42726

Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:test-fix-android-click-tests
Sep 15, 2026
Merged

Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:test-fix-android-click-tests

Conversation

@dgozman

Copy link
Copy Markdown
Collaborator

Summary

  • Anchor the fixed header with bottom: 50px instead of calc(100vh - 50px): on Android 100vh exceeds innerHeight, so the header covered the whole viewport and the click could never succeed.
  • Skip the iframe retention test on Android, where requestGC() is not enough to release the iframe.

- Anchor the fixed header with bottom instead of a vh-based height, since 100vh
  exceeds innerHeight on Android and covered the whole viewport.
- Skip the iframe retention test on Android.
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [firefox-library] › library/browsercontext-storage-state.spec.ts:453 › should work when service worker is intefering and the origin is not open @firefox-ubuntu-22.04-node20

8 flaky ⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:179 › serviceWorker(), and fromServiceWorker() work `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:664 › screencast › should capture full viewport `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`

51719 passed, 1247 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 The one failure is pre-existing — it's broken on main too

browsercontext-storage-state.spec.ts:453 on Firefox fails on every run in the CI results db, including plain main pushes. Nothing here points at this PR.

Details

This PR touches two test files only — tests/page/page-click-scroll.spec.ts (CSS in an inline fixture) and tests/page/page-click.spec.ts (an Android skip). It changes no product code and no shared helper, so it can't reach a browsercontext-storage-state service-worker test.

Pre-existing flake / infra

The 8 flaky results in the report (service worker network events, screencast video, beforeunload dialogs, partitioned cookies) all passed on retry and sit in library code this PR doesn't touch.

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [firefox] › mcp/cli-drag.spec.ts:19 › drag between elements @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-session.spec.ts:54 › idle timeout shuts the session down @mcp-windows-latest-firefox

8562 passed, 1446 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 Both failures are pre-existing Windows/Firefox flakes

cli-drag.spec.ts:19 and cli-session.spec.ts:54 both fail on plain main pushes with the exact same errors. This PR touches two test files and no product code, so it can't reach them.

Details

The PR changes only tests/page/page-click-scroll.spec.ts (inline CSS fixture) and tests/page/page-click.spec.ts (an Android skip). No product code, no shared helper — nothing that the MCP CLI suite exercises.

Pre-existing flake / infra

Both look like the Windows Firefox bot being slow enough that a shutdown/settle step loses its race. Worth someone fixing on main, but not this PR's doing.

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants