Repository navigation
oceanbench: add oceanmedia player - #873
Merged
Merged
Conversation
This was referenced Oct 13, 2026
elliot-ausocean
force-pushed
the
pr873
branch
from
October 13, 2026 06:47
6029a1a to
53e2073
Compare
ao-david
approved these changes
Oct 14, 2026
Member
There was a problem hiding this comment.
Is this whole directory just a copy of the dependency? And if so, why don't we just import via NPM?
Collaborator
Author
There was a problem hiding this comment.
It is mostly a copy. There are a few changes to the skin (primarily adding DVR functionality). Vendoring the skin like this is the recommended way to modify built-in skins.
elliot-ausocean
force-pushed
the
pr871
branch
from
October 20, 2026 02:49
25ce200 to
5366fff
Compare
This change adds a player for oceanmedia streams to oceanbench. This uses video.js as this is what we will be switching to in ausoceantv (as vidstack is no longer supported and the authors recommend using video.js). The default video.js live player skin has been vendored so that we can customise it.
elliot-ausocean
force-pushed
the
pr873
branch
from
October 20, 2026 03:08
53e2073 to
07197c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a player for oceanmedia streams to oceanbench. This uses video.js as this is what we will be switching to in ausoceantv (as vidstack is no longer supported and the authors recommend using video.js). The default video.js live player skin has been vendored so that we can customise it.