Repository navigation
oceanmedia: fix delta updates and make URLs stable - #871
Merged
Merged
Conversation
This was referenced Oct 13, 2026
trekhopton
approved these changes
Oct 13, 2026
elliot-ausocean
force-pushed
the
pr871
branch
from
October 13, 2026 05:54
4a69387 to
25ce200
Compare
elliot-ausocean
force-pushed
the
pr870
branch
from
October 13, 2026 05:54
1927f13 to
d54f872
Compare
This was referenced Oct 13, 2026
elliot-ausocean
force-pushed
the
pr870
branch
2 times, most recently
from
October 20, 2026 02:46
c3d0c61 to
94fb6a3
Compare
This change fixes delta updates - namely changing skipped segments to use an equals instead of a colon and always providing a segment even if there isn't a new one ready yet. It also makes URLs stable by using a redirect to a signed URL instead of a signed URL directly. This is important as players need a stable URL to match up segments in delta requests. It also has the benefit in that we don't need to sign every URL which reduces the amount of processing we need to do.
elliot-ausocean
force-pushed
the
pr871
branch
from
October 20, 2026 02:49
25ce200 to
5366fff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes delta updates - namely changing skipped segments to use an equals instead of a colon and always providing a segment even if there isn't a new one ready yet. It also makes URLs stable by using a redirect to a signed URL instead of a signed URL directly. This is important as players need a stable URL to match up segments in delta requests. It also has the benefit in that we don't need to sign every URL which reduces the amount of processing we need to do.