Skip to content

Fix Swift 6 sample concurrency issues#99

Merged
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/swift6/sample-concurrency-cleanup
Jun 16, 2026
Merged

Fix Swift 6 sample concurrency issues#99
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/swift6/sample-concurrency-cleanup

Conversation

@kieran-osgood-shopify

@kieran-osgood-shopify kieran-osgood-shopify commented May 13, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

Just some final @mainactor cleanup for the sample app

How to test


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in platforms/swift/ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from kieran-osgood/swift6/swiftformat-cleanup to graphite-base/99 May 13, 2026 20:06
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/sample-concurrency-cleanup branch from 57c6e61 to adb910a Compare May 13, 2026 20:06
@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from graphite-base/99 to kieran-osgood/swift6/generated-jsonany-sendable May 13, 2026 20:07
@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from kieran-osgood/swift6/generated-jsonany-sendable to graphite-base/99 May 14, 2026 08:48
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/sample-concurrency-cleanup branch from adb910a to 6e4c264 Compare May 14, 2026 08:48
@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from graphite-base/99 to kieran-osgood/swift6/swiftformat-cleanup May 14, 2026 08:48
@kieran-osgood-shopify kieran-osgood-shopify added the #gsd:50662 Rebase Checkout Kit on UCP label May 14, 2026
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/sample-concurrency-cleanup branch from 6e4c264 to 9ee9385 Compare June 10, 2026 16:53
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/swiftformat-cleanup branch from 0bd6938 to c5dd132 Compare June 10, 2026 16:53
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.66% (319/348) 87.86% (181/206) 100% (82/82)

@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/sample-concurrency-cleanup branch from 9ee9385 to a14d3d3 Compare June 11, 2026 08:54
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/swiftformat-cleanup branch from c5dd132 to 5ec7916 Compare June 11, 2026 08:54
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/sample-concurrency-cleanup branch from a14d3d3 to 6af3d02 Compare June 11, 2026 09:33
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/swiftformat-cleanup branch 2 times, most recently from 41039f3 to 767def5 Compare June 11, 2026 10:01
@kieran-osgood-shopify kieran-osgood-shopify marked this pull request as ready for review June 16, 2026 10:51
@kieran-osgood-shopify kieran-osgood-shopify requested a review from a team as a code owner June 16, 2026 10:51
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch from c7f177c to f6527d6 Compare June 16, 2026 10:56
@kieran-osgood-shopify kieran-osgood-shopify marked this pull request as draft June 16, 2026 11:06
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/sample-concurrency-cleanup branch from 87da37c to 63053fe Compare June 16, 2026 11:11
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch 2 times, most recently from 11aff32 to 976677b Compare June 16, 2026 11:11
@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from kieran-osgood/swift6/test-compile-cleanup to graphite-base/99 June 16, 2026 11:15
@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from graphite-base/99 to kieran-osgood/swift6/test-compile-cleanup June 16, 2026 11:19
@kieran-osgood-shopify kieran-osgood-shopify marked this pull request as ready for review June 16, 2026 11:20
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch from 11aff32 to 467a508 Compare June 16, 2026 11:30
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/sample-concurrency-cleanup branch from 63053fe to 4672eff Compare June 16, 2026 11:30
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch 2 times, most recently from fce70a4 to fc7e4e1 Compare June 16, 2026 11:38
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/sample-concurrency-cleanup branch from 4672eff to 8259bad Compare June 16, 2026 11:38
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch 2 times, most recently from d7d08ab to 64d8ae2 Compare June 16, 2026 11:50
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/sample-concurrency-cleanup branch from 8259bad to 2e323e0 Compare June 16, 2026 13:05
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch from 64d8ae2 to 6153213 Compare June 16, 2026 13:05
@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from kieran-osgood/swift6/test-compile-cleanup to graphite-base/99 June 16, 2026 13:29
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/sample-concurrency-cleanup branch from 2e323e0 to 4ff6707 Compare June 16, 2026 13:30
@graphite-app graphite-app Bot changed the base branch from graphite-base/99 to main June 16, 2026 13:30
@graphite-app

graphite-app Bot commented Jun 16, 2026

Copy link
Copy Markdown

Merge activity

  • Jun 16, 1:30 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Jun 16, 1:51 PM UTC: @kieran-osgood-shopify merged this pull request with Graphite.

@kieran-osgood-shopify kieran-osgood-shopify merged commit adeefa1 into main Jun 16, 2026
38 of 41 checks passed
@kieran-osgood-shopify kieran-osgood-shopify deleted the kieran-osgood/swift6/sample-concurrency-cleanup branch June 16, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants