Skip to content

Isolate wallet controllers to the main actor#89

Merged
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/swift6/mainactor-wallet-layer
Jun 16, 2026
Merged

Isolate wallet controllers to the main actor#89
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/swift6/mainactor-wallet-layer

Conversation

@kieran-osgood-shopify

@kieran-osgood-shopify kieran-osgood-shopify commented May 13, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

How to test

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)
Releasing a new Swift version?
  • I have bumped the version in platforms/swift/ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

This was referenced May 13, 2026
Merged
Merged
Merged
Merged
Merged
@kieran-osgood-shopify Graphite App

kieran-osgood-shopify commented May 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced May 13, 2026
Merged
Merged
Merged
Closed
Closed
Merged
@kieran-osgood-shopify kieran-osgood-shopify added the #gsd:50662 Rebase Checkout Kit on UCP label May 14, 2026
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/mainactor-wallet-layer branch from 0cf239b to 84e4cae Compare June 10, 2026 16:53
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/storefront-sendable-cache branch from 9eec6dd to aecdfa8 Compare June 10, 2026 16:53
@github-actions

github-actions Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 91.66% (319/348) 87.86% (181/206) 100% (82/82)

@kieran-osgood-shopify kieran-osgood-shopify mentioned this pull request Jun 10, 2026
Closed
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/mainactor-wallet-layer branch from 84e4cae to c77e3ad Compare June 11, 2026 08:54
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/storefront-sendable-cache branch from aecdfa8 to a2a8f7d Compare June 11, 2026 08:54
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/mainactor-wallet-layer branch from c77e3ad to f3249fc Compare June 11, 2026 09:33
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/storefront-sendable-cache branch from a2a8f7d to 3dce64e Compare June 11, 2026 09:33
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/mainactor-wallet-layer branch from f3249fc to 7f0027d Compare June 11, 2026 10:01
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/storefront-sendable-cache branch from 3dce64e to 3dbd021 Compare June 11, 2026 10:01
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/mainactor-wallet-layer branch from 7f0027d to 9a262e2 Compare June 11, 2026 10:23
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/storefront-sendable-cache branch from 3dbd021 to 3afa77a Compare June 11, 2026 10:23
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/mainactor-wallet-layer branch from 9a262e2 to 87ef06a Compare June 11, 2026 10:32
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/storefront-sendable-cache branch from 3afa77a to 37a6f41 Compare June 11, 2026 10:32
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/mainactor-wallet-layer branch from 87ef06a to 9881338 Compare June 11, 2026 13:08
@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from kieran-osgood/swift6/storefront-sendable-cache to graphite-base/89 June 11, 2026 15:02
@kieran-osgood-shopify kieran-osgood-shopify mentioned this pull request Jun 11, 2026
Merged
11 tasks
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/applepay-configuration-environment-value branch from 9c3861b to 877d467 Compare June 15, 2026 13:36
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/mainactor-wallet-layer branch from 560b63e to 3802349 Compare June 15, 2026 13:36
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/applepay-configuration-environment-value branch from 877d467 to f8cfa26 Compare June 15, 2026 13:51
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/mainactor-wallet-layer branch from 3802349 to 2ad9cff Compare June 15, 2026 13:51
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/applepay-configuration-environment-value branch from f8cfa26 to 06180b5 Compare June 15, 2026 14:08
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/mainactor-wallet-layer branch from 2ad9cff to 1a0ebc2 Compare June 15, 2026 14:08
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/applepay-configuration-environment-value branch from 06180b5 to db6d494 Compare June 15, 2026 14:39
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/mainactor-wallet-layer branch from 1a0ebc2 to c7b966e Compare June 15, 2026 14:39
@kieran-osgood-shopify kieran-osgood-shopify marked this pull request as ready for review June 15, 2026 16:52
@kieran-osgood-shopify kieran-osgood-shopify requested a review from a team as a code owner June 15, 2026 16:52
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/mainactor-wallet-layer branch from c7b966e to 7caa036 Compare June 16, 2026 08:49
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/applepay-configuration-environment-value branch from db6d494 to 297b04a Compare June 16, 2026 08:49
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/mainactor-wallet-layer branch from 7caa036 to c7444ee Compare June 16, 2026 09:07
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/applepay-configuration-environment-value branch 2 times, most recently from 40fc6e7 to 57b8638 Compare June 16, 2026 10:41
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/mainactor-wallet-layer branch from c7444ee to 517d853 Compare June 16, 2026 10:42
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/applepay-configuration-environment-value branch 2 times, most recently from f4f109d to 2d5f5d7 Compare June 16, 2026 10:55
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/mainactor-wallet-layer branch from 517d853 to 1a5514a Compare June 16, 2026 10:55
@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from kieran-osgood/swift6/applepay-configuration-environment-value to graphite-base/89 June 16, 2026 11:10
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/mainactor-wallet-layer branch from 1a5514a to 06a7d37 Compare June 16, 2026 11:10
@graphite-app graphite-app Bot changed the base branch from graphite-base/89 to main June 16, 2026 11:10
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/mainactor-wallet-layer branch from 06a7d37 to 499f839 Compare June 16, 2026 11:10
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/mainactor-wallet-layer branch from 499f839 to 49a1481 Compare June 16, 2026 11:11
@kieran-osgood-shopify kieran-osgood-shopify merged commit 99c4322 into main Jun 16, 2026
24 checks passed
@kieran-osgood-shopify Graphite App

kieran-osgood-shopify commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

@kieran-osgood-shopify kieran-osgood-shopify deleted the kieran-osgood/swift6/mainactor-wallet-layer branch June 16, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markmur markmur markmur approved these changes

Assignees

No one assigned

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kieran-osgood-shopify @markmur