Skip to content

Fix Swift 6 test target isolation#91

Merged
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/swift6/test-compile-cleanup
Jun 16, 2026
Merged

Fix Swift 6 test target isolation#91
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/swift6/test-compile-cleanup

Conversation

@kieran-osgood-shopify

@kieran-osgood-shopify kieran-osgood-shopify commented May 13, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

Just a few test updates to ensure UI tests run on mainactor and we use async test setup and cleanup in preparation for swift 6

How to test


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in platforms/swift/ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.66% (319/348) 87.86% (181/206) 100% (82/82)

@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch from 3d0e770 to b001eee Compare June 11, 2026 08:54
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/passkit-protocol-compat branch from 6072481 to a0e4139 Compare June 11, 2026 08:54
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch from b001eee to c0dce06 Compare June 11, 2026 09:33
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/passkit-protocol-compat branch from a0e4139 to fb1320d Compare June 11, 2026 09:33
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch from c0dce06 to d7ee28f Compare June 11, 2026 10:01
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/passkit-protocol-compat branch from fb1320d to a58d36b Compare June 11, 2026 10:01
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch 2 times, most recently from 9235da6 to d0215be Compare June 11, 2026 10:32
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/passkit-protocol-compat branch from 0e6b530 to ae1e7d9 Compare June 11, 2026 10:32
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch 2 times, most recently from 9ad1ab3 to cfdcc01 Compare June 12, 2026 10:58
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/passkit-protocol-compat branch 2 times, most recently from 33c15e1 to 1dc84eb Compare June 12, 2026 12:54
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/passkit-protocol-compat branch from f64080e to ae2b8ee Compare June 16, 2026 08:49
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch from e74da1f to ac14afa Compare June 16, 2026 09:07
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/passkit-protocol-compat branch 2 times, most recently from 576d6d1 to ac8762f Compare June 16, 2026 10:42
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch from ac14afa to c7f177c Compare June 16, 2026 10:43
@kieran-osgood-shopify kieran-osgood-shopify marked this pull request as ready for review June 16, 2026 10:53
@kieran-osgood-shopify kieran-osgood-shopify requested a review from a team as a code owner June 16, 2026 10:53
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/passkit-protocol-compat branch from ac8762f to 84b782e Compare June 16, 2026 10:55
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch from c7f177c to f6527d6 Compare June 16, 2026 10:56
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/passkit-protocol-compat branch 2 times, most recently from bc67637 to 6251997 Compare June 16, 2026 11:11
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch 4 times, most recently from 11aff32 to 467a508 Compare June 16, 2026 11:30
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/passkit-protocol-compat branch 2 times, most recently from 019f130 to 6c98d4c Compare June 16, 2026 11:32
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch 2 times, most recently from fce70a4 to fc7e4e1 Compare June 16, 2026 11:38
@kieran-osgood-shopify kieran-osgood-shopify changed the base branch from kieran-osgood/swift6/passkit-protocol-compat to graphite-base/91 June 16, 2026 11:50
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch from fc7e4e1 to d7d08ab Compare June 16, 2026 11:50
@graphite-app graphite-app Bot changed the base branch from graphite-base/91 to main June 16, 2026 11:50
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch from d7d08ab to 64d8ae2 Compare June 16, 2026 11:50
@kieran-osgood-shopify kieran-osgood-shopify force-pushed the kieran-osgood/swift6/test-compile-cleanup branch from 64d8ae2 to 6153213 Compare June 16, 2026 13:05
@kieran-osgood-shopify kieran-osgood-shopify merged commit cbfd5c2 into main Jun 16, 2026
24 checks passed

Copy link
Copy Markdown
Contributor Author

Merge activity

@kieran-osgood-shopify kieran-osgood-shopify deleted the kieran-osgood/swift6/test-compile-cleanup branch June 16, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants