feat: add abstract workflows for coverage, linting, testing, reuse, and scorecard - #34
seantronsen wants to merge 5 commits into
Conversation
…nd scorecard Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
synackd
left a comment
There was a problem hiding this comment.
Largely looks good, thanks for the contribution!
Just a couple of small things and improvement ideas.
| - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: fsfe/reuse-action@676e2d560c9a403aa252096d99fcab3e1132b0f5 # v6.0.0 |
There was a problem hiding this comment.
I didn't see a way to do this in the official REUSE action, but it's nice to be able to see which files are non-compliant. I managed to do this in the ochami CLI with a more manual approach if you'd like to reference it. See:
https://github.com/OpenCHAMI/ochami/blob/main/.github/workflows/reuse.yaml
There was a problem hiding this comment.
Wondering if we should allow overriding the REUSE version and default to 6.2.0.
There was a problem hiding this comment.
I worry that will cause maintenance headaches. Aside from the helper bot updating versions, it would be pretty easy to forget to update the reuse version in repo X. Then for N unique repos...
I think it could be a nice-to-have, but w.r.t. maintenance, the cons outweigh the pros for me.
There was a problem hiding this comment.
I worry that will cause maintenance headaches.
How is it different than remembering to update the hard-coded version as you have it?
There was a problem hiding this comment.
I worry that will cause maintenance headaches.
How is it different than remembering to update the hard-coded version as you have it?
It would only be hardcoded in this repo as opposed to needing N repos to remember to update another value. Of course, either way N repos will need to keep the workflow ref up to date.
There was a problem hiding this comment.
I worry that will cause maintenance headaches.
How is it different than remembering to update the hard-coded version as you have it?
It would only be hardcoded in this repo as opposed to needing N repos to remember to update another value. Of course, either way N repos will need to keep the workflow ref up to date.
Right, and it would still only be defined here as the default. Other repos could change it for temporary purposes, but the default version would have its source of truth here.
There was a problem hiding this comment.
In other repos, you would just leave the default unless there was an issue with the version, in which case the input would allow temporary change.
There was a problem hiding this comment.
@synackd you drive a hard bargain, but I see your point. I'm still stuck at the office, but I'll get it implemented once I get back home.
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Description
Please include a summary of the change and which issue is fixed.
Also include relevant motivation and context.
Fixes #27, #28, #29, #30
Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryType of Change