Repository navigation
Generate the Core client types from the schema - #554
Merged
Merged
Conversation
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/core/v1client types are now generated fromcontracts/agents-api/core.openapi.yaml, the same way #549 generates the/v1types. Hand-written duplicates are deleted.make openapimakesscripts/openapi-splitalso write the Core document as JSON into its temporary directory.scripts/generate-public-api.py --corethen projects the definitions that the Core paths reach intopackages/agents-client/src/generated/core-api.ts.public-api.ts.binding:"required",extensions:"x-nullable",enums:) on the Core response types now declare presence, nullability and closed sets. They are inert at runtime.admin-types.ts,sandbox-client.ts,core-metrics.ts,session-diagnostics.tsand the projections use the generated types and field lists. Hand-written shapes and validators are deleted.apps/web/src/lib/admin-view.tsare deleted. Pages read the client types and format RFC 3339 throughepochSeconds. The wrappers and name checks that had no callers are removed.contracts/agents-api/index.md+ zh).What the schema now enforces that it did not before:
diskis required;api_keyis non-null, andresource_typeandactionare closed sets;SandboxNodeDiagnostichas no empty value;NodeUpdate.max_retainedis optional.Checks:
go build,go vetand the focused Go tests pass;generate-public-api.test.pypasses;make check-openapishows no drift;Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.