Skip to content

Settle the generated client review findings - #556

Merged
SaladDay merged 1 commit into
mainfrom
fix/generated-client-review
Oct 8, 2026
Merged

SaladDay merged 1 commit into
mainfrom
fix/generated-client-review

Conversation

@SaladDay

@SaladDay SaladDay commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes from the batched blind review of #549 and #554.

  • Generator. core_module now raises when a package-prefixed name or a hoisted inline enum would replace another type. Before, a second schema silently overwrote the first, and --check and tsc still passed. A test covers both cases.
  • Subagent events. agent.session.subagent.* events no longer carry a top-level session_id. The pinned schema allows only type, event_id and subagent, and the Subagent already names the Session.
  • Core errors. CoreAPIError.code and .param are always sent (nullable), so they are now tagged binding:"required".
  • Docs. The coverage ledger (English and zh) states the swag tag convention for /core/v1 responses.

Checks: generator tests (16), the v1 and api tests, make check-openapi, client tsc and the translation check.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@SaladDay
SaladDay merged commit d3a58f5 into main Oct 8, 2026
1 check passed
@SaladDay
SaladDay deleted the fix/generated-client-review branch October 8, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant