Repository navigation
Settle the generated client review findings - #556
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the batched blind review of #549 and #554.
core_modulenow raises when a package-prefixed name or a hoisted inline enum would replace another type. Before, a second schema silently overwrote the first, and--checkandtscstill passed. A test covers both cases.agent.session.subagent.*events no longer carry a top-levelsession_id. The pinned schema allows onlytype,event_idandsubagent, and the Subagent already names the Session.CoreAPIError.codeand.paramare always sent (nullable), so they are now taggedbinding:"required"./core/v1responses.Checks: generator tests (16), the
v1and api tests,make check-openapi, clienttscand the translation check.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.