Repository navigation
Sync main d3a58f53 into the cutover - #558
Merged
Merged
Conversation
make openapi now projects the public schema onto packages/agents-client/src/generated/public-api.ts: each schema's TypeScript type, each enum's values and each object's field names, with required lists and per-union field maps. make check-openapi rejects a stale copy. The emitter takes a parsed schema dict and accepts the Swagger 2.0 forms of the Core document (x-nullable, allOf, any ref prefix), so the /core/v1 projection can reuse it. The client aliases the generated types and validates responses with the generated field sets and enums instead of hand-written copies. Where the schema and the validators disagreed, the schema wins: snapshot events carry no session_id, Item events require output_index, terminal Turn events require usage, list envelopes are complete, input_image is accepted in user messages, and older-Core allowances are gone. The client no longer re-checks limits Core enforces. Core now sends turn_id null on Environment events, null cwd, output, exit_code and duration_ms on command_execution Items, and param null on the stream interruption error, as the pinned schema requires.
# Conflicts: # contracts/agents-api/zh/index.md # packages/agents-client/src/admin-projection.ts # packages/agents-client/src/admin-types.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges
maind3a58f5 (#549, #554, #556: the public and Core client types generated from the schemas) into the cutover.Conflicts:
contracts/agents-api/zh/index.md: the source hash was recomputed from the merged ledger.packages/agents-client/src/admin-types.tsandadmin-projection.ts: took main's generated types and field lists.make openapiregeneratedcore-api.tsfrom the cutover schema, soExecutorConnectionno longer haslast_seen_at.Checks:
go build ./...andgo vet ./services/core/....go testforapi,deployment/...andsandbox.make check-openapi check-names check-docs check-ci.tsc --noEmitinagents-clientandapps/web.agents-clientvitest: 712 passed.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.